Mailing List Archive: ext

ext_todo patch

Aug 20, 2015, 9:37 AM

Post #1 of 3 (1660 views)

ive installed a fresh qmail with netqmail-1.06 and have applied these
patches:
big-concurrency.patch
netqmail-1.06-channels.patch
qmail-1.03_outgoingips.patch

with no issues, verifying they all work.

then i applied:
big-todo.103.patch (http://www.qmail.org/big-todo.103.patch)
and got these errors:

[root@new-host-2 netqmail-1.06]# patch < ../ext_todo-20030105.patch
patching file EXTTODO
patching file EXTTODO-INFO
patching file FILES
Hunk #1 FAILED at 431.
1 out of 1 hunk FAILED -- saving rejects to file FILES.rej
patching file Makefile
Hunk #2 FAILED at 705.
Hunk #3 FAILED at 757.
Hunk #4 succeeded at 817 (offset 7 lines).
Hunk #5 FAILED at 1511.
Hunk #6 FAILED at 1576.
Hunk #7 succeeded at 1615 (offset 8 lines).
4 out of 7 hunks FAILED -- saving rejects to file Makefile.rej
patching file TARGETS
Hunk #1 FAILED at 385.
1 out of 1 hunk FAILED -- saving rejects to file TARGETS.rej
patching file hier.c
Hunk #1 succeeded at 121 (offset 13 lines).
patching file install-big.c
Hunk #1 succeeded at 121 (offset 13 lines).
patching file qmail-send.c
Hunk #1 succeeded at 1234 (offset 19 lines).
Hunk #2 succeeded at 1455 (offset 16 lines).
Hunk #3 succeeded at 1729 (offset 87 lines).
Hunk #4 succeeded at 1902 (offset 193 lines).
patching file qmail-start.c
Hunk #1 succeeded at 9 (offset 1 line).
Hunk #2 FAILED at 21.
Hunk #3 succeeded at 64 with fuzz 2 (offset 21 lines).
Hunk #4 succeeded at 103 with fuzz 2 (offset 26 lines).
Hunk #5 succeeded at 137 with fuzz 2 (offset 19 lines).
Hunk #6 FAILED at 155.
2 out of 6 hunks FAILED -- saving rejects to file qmail-start.c.rej
patching file qmail-todo.c
[root@new-host-2 netqmail-1.06]#

i also applied the big-todo.103.patch with no errors.

obviously ext_todo didn't work, however i can see what the patch was
trying to do and it appears i can apply the changes manually? is that a
safe thing to do or is it something more to it? looks like problems
with these 4 files: FILES, Makefile, TARGETS, and qmail-start.c. Do the
patches and 'make' process use FILES and TARGETS?

i can supply the .rej files for anyone interested in helping out.

thanks
kirk

Re: ext_todo patch [ In reply to ]

kirk at icapsolutions

Aug 20, 2015, 11:05 AM

Post #2 of 3 (1629 views)

Permalink

After some investigating and hacking - changing the order of patches and
applying netqmail-1.06-channels.patch last - we discovered
netqmail-1.06-channels.patch is stepping on ext_todo-20030105.patch .
While we may not necessarily need the channels patch, it would be a nice
addition to the mix to get it working. I took a peek at the .rej code
and all but qmail-send.c is trivial. Not sure if i can get qmail-send
working by manually patching from the .rej file as it looks a bit beyond
my scope of expertise.
I'm wondering if anyone has the combo "netqmail-1.06-channels.patch" and
"ext_todo-20030105.patch" working together?

Thanks
Kirk

On 8/20/2015 9:37 AM, kirk wrote:
> ive installed a fresh qmail with netqmail-1.06 and have applied these
> patches:
> big-concurrency.patch
> netqmail-1.06-channels.patch
> qmail-1.03_outgoingips.patch
>
> with no issues, verifying they all work.
>
> then i applied:
> big-todo.103.patch (http://www.qmail.org/big-todo.103.patch)
> and got these errors:
>
> [root@new-host-2 netqmail-1.06]# patch < ../ext_todo-20030105.patch
> patching file EXTTODO
> patching file EXTTODO-INFO
> patching file FILES
> Hunk #1 FAILED at 431.
> 1 out of 1 hunk FAILED -- saving rejects to file FILES.rej
> patching file Makefile
> Hunk #2 FAILED at 705.
> Hunk #3 FAILED at 757.
> Hunk #4 succeeded at 817 (offset 7 lines).
> Hunk #5 FAILED at 1511.
> Hunk #6 FAILED at 1576.
> Hunk #7 succeeded at 1615 (offset 8 lines).
> 4 out of 7 hunks FAILED -- saving rejects to file Makefile.rej
> patching file TARGETS
> Hunk #1 FAILED at 385.
> 1 out of 1 hunk FAILED -- saving rejects to file TARGETS.rej
> patching file hier.c
> Hunk #1 succeeded at 121 (offset 13 lines).
> patching file install-big.c
> Hunk #1 succeeded at 121 (offset 13 lines).
> patching file qmail-send.c
> Hunk #1 succeeded at 1234 (offset 19 lines).
> Hunk #2 succeeded at 1455 (offset 16 lines).
> Hunk #3 succeeded at 1729 (offset 87 lines).
> Hunk #4 succeeded at 1902 (offset 193 lines).
> patching file qmail-start.c
> Hunk #1 succeeded at 9 (offset 1 line).
> Hunk #2 FAILED at 21.
> Hunk #3 succeeded at 64 with fuzz 2 (offset 21 lines).
> Hunk #4 succeeded at 103 with fuzz 2 (offset 26 lines).
> Hunk #5 succeeded at 137 with fuzz 2 (offset 19 lines).
> Hunk #6 FAILED at 155.
> 2 out of 6 hunks FAILED -- saving rejects to file qmail-start.c.rej
> patching file qmail-todo.c
> [root@new-host-2 netqmail-1.06]#
>
> i also applied the big-todo.103.patch with no errors.
>
> obviously ext_todo didn't work, however i can see what the patch was
> trying to do and it appears i can apply the changes manually? is that
> a safe thing to do or is it something more to it? looks like problems
> with these 4 files: FILES, Makefile, TARGETS, and qmail-start.c. Do
> the patches and 'make' process use FILES and TARGETS?
>
> i can supply the .rej files for anyone interested in helping out.
>
> thanks
> kirk
>

Re: ext_todo patch [ In reply to ]

kirk at icapsolutions

Aug 20, 2015, 1:33 PM

Post #3 of 3 (1632 views)

Permalink

And here's yet another problem. After successfully patching:
patch < ../ext_todo-20030105.patch
patch < ../big-todo.103.patch
patch < ../big-concurrency.patch
patch < ../qmail-1.03_outgoingips.patch

I now get this in the log files:

2015-08-20 13:18:40.601699500 warning: qmail-todo: unable to stat mess/0/0
...
2015-08-20 13:18:40.601699500 warning: qmail-todo: unable to stat
mess/210/210

note: doesn't seem to matter if i change conf-split=23 or 211 ... same
result in log files only less 0-22.

and of course nothing is working. any clues? i've been hacking away
and by removing the flag in the Makefile:
#DEFINES=-DEXTERNAL_TODO # use to enable external todo

and recompiling, everything works fine.

cant seem to get the big-todo working, what have i done wrong?

thanks,
kirk

On 8/20/2015 11:05 AM, kirk wrote:
> After some investigating and hacking - changing the order of patches
> and applying netqmail-1.06-channels.patch last - we discovered
> netqmail-1.06-channels.patch is stepping on ext_todo-20030105.patch .
> While we may not necessarily need the channels patch, it would be a
> nice addition to the mix to get it working. I took a peek at the .rej
> code and all but qmail-send.c is trivial. Not sure if i can get
> qmail-send working by manually patching from the .rej file as it looks
> a bit beyond my scope of expertise.
> I'm wondering if anyone has the combo "netqmail-1.06-channels.patch"
> and "ext_todo-20030105.patch" working together?
>
> Thanks
> Kirk
>
>
> On 8/20/2015 9:37 AM, kirk wrote:
>> ive installed a fresh qmail with netqmail-1.06 and have applied these
>> patches:
>> big-concurrency.patch
>> netqmail-1.06-channels.patch
>> qmail-1.03_outgoingips.patch
>>
>> with no issues, verifying they all work.
>>
>> then i applied:
>> big-todo.103.patch (http://www.qmail.org/big-todo.103.patch)
>> and got these errors:
>>
>> [root@new-host-2 netqmail-1.06]# patch < ../ext_todo-20030105.patch
>> patching file EXTTODO
>> patching file EXTTODO-INFO
>> patching file FILES
>> Hunk #1 FAILED at 431.
>> 1 out of 1 hunk FAILED -- saving rejects to file FILES.rej
>> patching file Makefile
>> Hunk #2 FAILED at 705.
>> Hunk #3 FAILED at 757.
>> Hunk #4 succeeded at 817 (offset 7 lines).
>> Hunk #5 FAILED at 1511.
>> Hunk #6 FAILED at 1576.
>> Hunk #7 succeeded at 1615 (offset 8 lines).
>> 4 out of 7 hunks FAILED -- saving rejects to file Makefile.rej
>> patching file TARGETS
>> Hunk #1 FAILED at 385.
>> 1 out of 1 hunk FAILED -- saving rejects to file TARGETS.rej
>> patching file hier.c
>> Hunk #1 succeeded at 121 (offset 13 lines).
>> patching file install-big.c
>> Hunk #1 succeeded at 121 (offset 13 lines).
>> patching file qmail-send.c
>> Hunk #1 succeeded at 1234 (offset 19 lines).
>> Hunk #2 succeeded at 1455 (offset 16 lines).
>> Hunk #3 succeeded at 1729 (offset 87 lines).
>> Hunk #4 succeeded at 1902 (offset 193 lines).
>> patching file qmail-start.c
>> Hunk #1 succeeded at 9 (offset 1 line).
>> Hunk #2 FAILED at 21.
>> Hunk #3 succeeded at 64 with fuzz 2 (offset 21 lines).
>> Hunk #4 succeeded at 103 with fuzz 2 (offset 26 lines).
>> Hunk #5 succeeded at 137 with fuzz 2 (offset 19 lines).
>> Hunk #6 FAILED at 155.
>> 2 out of 6 hunks FAILED -- saving rejects to file qmail-start.c.rej
>> patching file qmail-todo.c
>> [root@new-host-2 netqmail-1.06]#
>>
>> i also applied the big-todo.103.patch with no errors.
>>
>> obviously ext_todo didn't work, however i can see what the patch was
>> trying to do and it appears i can apply the changes manually? is that
>> a safe thing to do or is it something more to it? looks like
>> problems with these 4 files: FILES, Makefile, TARGETS, and
>> qmail-start.c. Do the patches and 'make' process use FILES and TARGETS?
>>
>> i can supply the .rej files for anyone interested in helping out.
>>
>> thanks
>> kirk
>>
>