Mailing List Archive

bpo-45195: Fix test_readline.test_nonascii() (GH-28329) (GH-28984)
https://github.com/python/cpython/commit/1d8cb01e23ab5fc626d4deda216f9a9a19a644a2
commit: 1d8cb01e23ab5fc626d4deda216f9a9a19a644a2
branch: 3.8
author: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
committer: ambv <lukasz@langa.pl>
date: 2021-10-19T21:14:36+02:00
summary:

bpo-45195: Fix test_readline.test_nonascii() (GH-28329) (GH-28984)

Fix test_readline.test_nonascii(): sometimes, the newline character
is not written at the end, so don't expect it in the output.
(cherry picked from commit 797c8eb9ef511f0c25f10a453b35c4d2fe383c30)

Co-authored-by: Victor Stinner <vstinner@python.org>

files:
A Misc/NEWS.d/next/Tests/2021-09-14-13-16-18.bpo-45195.EyQR1G.rst
M Lib/test/test_readline.py

diff --git a/Lib/test/test_readline.py b/Lib/test/test_readline.py
index 67ee9b7f7cfb1..3574657cf3635 100644
--- a/Lib/test/test_readline.py
+++ b/Lib/test/test_readline.py
@@ -232,7 +232,9 @@ def display(substitution, matches, longest_match_length):
self.assertIn(b"matches ['t\\xebnt', 't\\xebxt']\r\n", output)
expected = br"'[\xefnserted]|t\xebxt[after]'"
self.assertIn(b"result " + expected + b"\r\n", output)
- self.assertIn(b"history " + expected + b"\r\n", output)
+ # bpo-45195: Sometimes, the newline character is not written at the
+ # end, so don't expect it in the output.
+ self.assertIn(b"history " + expected, output)

# We have 2 reasons to skip this test:
# - readline: history size was added in 6.0
diff --git a/Misc/NEWS.d/next/Tests/2021-09-14-13-16-18.bpo-45195.EyQR1G.rst b/Misc/NEWS.d/next/Tests/2021-09-14-13-16-18.bpo-45195.EyQR1G.rst
new file mode 100644
index 0000000000000..16a1f4440483c
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2021-09-14-13-16-18.bpo-45195.EyQR1G.rst
@@ -0,0 +1,3 @@
+Fix test_readline.test_nonascii(): sometimes, the newline character is not
+written at the end, so don't expect it in the output. Patch by Victor
+Stinner.

_______________________________________________
Python-checkins mailing list
Python-checkins@python.org
https://mail.python.org/mailman/listinfo/python-checkins