Mailing List Archive

https://github.com/python/cpython/commit/6a273fdc2a36f52fb70359149eff014f1b6b08d4
commit: 6a273fdc2a36f52fb70359149eff014f1b6b08d4
branch: master
author: pxinwr <peixing.xin@windriver.com>
committer: miss-islington <31488909+miss-islington@users.noreply.github.com>
date: 2020-11-28T14:06:36-08:00
summary:

bpo-31904: skip some tests related to fifo on VxWorks (GH-23473)



On VxWork RTOS, FIFO must be created under directory "/fifos/". Some test cases related to fifo is invalid on VxWorks. So skip them.

files:
A Misc/NEWS.d/next/Tests/2020-11-23-11-11-29.bpo-31904.V3sUZk.rst
M Lib/test/test_pathlib.py
M Lib/test/test_shutil.py

diff --git a/Lib/test/test_pathlib.py b/Lib/test/test_pathlib.py
index 5e5e065b988aa..7f7f72c625806 100644
--- a/Lib/test/test_pathlib.py
+++ b/Lib/test/test_pathlib.py
@@ -2219,6 +2219,8 @@ def test_is_fifo_false(self):
self.assertIs((P / 'fileA\x00').is_fifo(), False)

@unittest.skipUnless(hasattr(os, "mkfifo"), "os.mkfifo() required")
+ @unittest.skipIf(sys.platform == "vxworks",
+ "fifo requires special path on VxWorks")
def test_is_fifo_true(self):
P = self.cls(BASE, 'myfifo')
try:
diff --git a/Lib/test/test_shutil.py b/Lib/test/test_shutil.py
index 890f2c7d406c2..df7fbedf24a7c 100644
--- a/Lib/test/test_shutil.py
+++ b/Lib/test/test_shutil.py
@@ -683,6 +683,8 @@ def custom_cpfun(a, b):
# Issue #3002: copyfile and copytree block indefinitely on named pipes
@unittest.skipUnless(hasattr(os, "mkfifo"), 'requires os.mkfifo()')
@os_helper.skip_unless_symlink
+ @unittest.skipIf(sys.platform == "vxworks",
+ "fifo requires special path on VxWorks")
def test_copytree_named_pipe(self):
os.mkdir(TESTFN)
try:
@@ -1206,6 +1208,8 @@ def test_dont_copy_file_onto_symlink_to_itself(self):

# Issue #3002: copyfile and copytree block indefinitely on named pipes
@unittest.skipUnless(hasattr(os, "mkfifo"), 'requires os.mkfifo()')
+ @unittest.skipIf(sys.platform == "vxworks",
+ "fifo requires special path on VxWorks")
def test_copyfile_named_pipe(self):
try:
os.mkfifo(TESTFN)
diff --git a/Misc/NEWS.d/next/Tests/2020-11-23-11-11-29.bpo-31904.V3sUZk.rst b/Misc/NEWS.d/next/Tests/2020-11-23-11-11-29.bpo-31904.V3sUZk.rst
new file mode 100644
index 0000000000000..7202cfa3f3f4c
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2020-11-23-11-11-29.bpo-31904.V3sUZk.rst
@@ -0,0 +1 @@
+skip some tests related to fifo on VxWorks

_______________________________________________
Python-checkins mailing list
Python-checkins@python.org
https://mail.python.org/mailman/listinfo/python-checkins