Mailing List Archive

[issue43811] Run GHA CI with multiple OpenSSL versions
New submission from Christian Heimes <lists@cheimes.de>:

CI only tests one OpenSSL version, but Python supports multiple versions of OpenSSL. OpenSSL 1.0.2, 1.1.0, 1.1.1, and 3.0.0 have different APIs and behave differently. We should run minimal tests with all major OpenSSL versions to ensure that Python compiles and works with supported versions.

This will slow down CI a bit. I figured out how to include ccache to speed up compilation a lot. With populated ccache configure + make takes less than 30 seconds instead of 90 seconds.

I also noticed that GHA action configuration compiles Python with custom OpenSSL but fails to set rpath / LD_LIBRARY_PATH. I think this means that we compile with custom OpenSSL but actual tests use OSS' OpenSSL libraries.

----------
assignee: christian.heimes
components: SSL, Tests
messages: 390825
nosy: christian.heimes
priority: normal
severity: normal
status: open
title: Run GHA CI with multiple OpenSSL versions
type: behavior
versions: Python 3.10, Python 3.8, Python 3.9

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue43811>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue43811] Run GHA CI with multiple OpenSSL versions [ In reply to ]
Christian Heimes <lists@cheimes.de> added the comment:

Github selects required actions based on the "name" attribute of a job. Therefore I decided to keep the default "Ubuntu" job and moved the additional OpenSSL tests to another job.

For future reference, my first approach was:

strategy:
fail-fast: false
matrix:
openssl_ver: [1.1.1k, 1.0.2u, 1.1.0l, 3.0.0-alpha14]
include:
- openssl_ver: 1.1.1k
testmode: 'full'
...
- name: Tests
run: xvfb-run make buildbottest TESTOPTS="-j4 -uall,-cpu"
if: ${{ matrix.testmode == 'full' }}
- name: SSL tests
run: ./python Lib/test/ssltests.py
if: ${{ matrix.testmode != 'full' }}

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue43811>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue43811] Run GHA CI with multiple OpenSSL versions [ In reply to ]
Change by Christian Heimes <lists@cheimes.de>:


----------
keywords: +patch
pull_requests: +24094
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25360

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue43811>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue43811] Run GHA CI with multiple OpenSSL versions [ In reply to ]
Christian Heimes <lists@cheimes.de> added the comment:

The new checks are only executed when one or more OpenSSL-related files are modified. The checks run a handful of networking and hashing test suites. All SSL checks are optional. This PR also introduces ccache to speed up compilation. In common cases it speeds up configure and compile time from about 90 seconds to less than 30 seconds.

----------
dependencies: +Run GHA CI with multiple OpenSSL versions

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue43811>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue43811] Run GHA CI with multiple OpenSSL versions [ In reply to ]
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment:


New changeset 8fa1489365e7af8b90286c97db55a2dc60a05cde by Christian Heimes in branch 'master':
bpo-43811: Test multiple OpenSSL versions on GHA (GH-25360)
https://github.com/python/cpython/commit/8fa1489365e7af8b90286c97db55a2dc60a05cde


----------
nosy: +miss-islington

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue43811>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue43811] Run GHA CI with multiple OpenSSL versions [ In reply to ]
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>:


----------
pull_requests: +24124
pull_request: https://github.com/python/cpython/pull/25391

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue43811>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue43811] Run GHA CI with multiple OpenSSL versions [ In reply to ]
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>:


----------
pull_requests: +24125
pull_request: https://github.com/python/cpython/pull/25392

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue43811>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue43811] Run GHA CI with multiple OpenSSL versions [ In reply to ]
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment:


New changeset 5ce227f3a767e6e44e7c41e0c845a83cf7777ca4 by Miss Islington (bot) in branch '3.9':
[3.9] bpo-43811: Test multiple OpenSSL versions on GHA (GH-25360) (GH-25391)
https://github.com/python/cpython/commit/5ce227f3a767e6e44e7c41e0c845a83cf7777ca4


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue43811>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue43811] Run GHA CI with multiple OpenSSL versions [ In reply to ]
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment:


New changeset a607815eb07582deb3c5818be881a98abe25a100 by Miss Islington (bot) in branch '3.8':
[3.8] bpo-43811: Test multiple OpenSSL versions on GHA (GH-25360) (GH-25392)
https://github.com/python/cpython/commit/a607815eb07582deb3c5818be881a98abe25a100


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue43811>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue43811] Run GHA CI with multiple OpenSSL versions [ In reply to ]
Change by Christian Heimes <lists@cheimes.de>:


----------
dependencies: -Run GHA CI with multiple OpenSSL versions
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue43811>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com