Mailing List Archive: [issue42144] A missing "goto" in the _ssl module!

[issue42144] A missing "goto" in the _ssl module!

Oct 24, 2020, 9:51 PM

Post #1 of 8 (47 views)

New submission from Zackery Spytz <zspytz@gmail.com>:

In the _ssl_configure_hostname() function, there's a missing "goto error;" if
SSL_set_tlsext_host_name() fails.

----------
assignee: christian.heimes
components: Extension Modules, SSL
messages: 379562
nosy: ZackerySpytz, christian.heimes
priority: normal
severity: normal
status: open
title: A missing "goto" in the _ssl module!
versions: Python 3.10, Python 3.8, Python 3.9

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue42144>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

[issue42144] A missing "goto" in the _ssl module! [ In reply to ]

Oct 24, 2020, 9:53 PM

Post #2 of 8 (47 views)

Change by Zackery Spytz <zspytz@gmail.com>:

----------
keywords: +patch
pull_requests: +21876
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22959

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue42144>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

[issue42144] A missing "goto" in the _ssl module! [ In reply to ]

Oct 25, 2020, 11:02 AM

Post #3 of 8 (47 views)

miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment:

New changeset c32f2976b8f4034724c3270397aa16f38daf470f by Zackery Spytz in branch 'master':
bpo-42144: Add a missing "goto error;" in the _ssl module (GH-22959)
https://github.com/python/cpython/commit/c32f2976b8f4034724c3270397aa16f38daf470f

----------
nosy: +miss-islington

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue42144>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

[issue42144] A missing "goto" in the _ssl module! [ In reply to ]

Oct 25, 2020, 11:02 AM

Post #4 of 8 (47 views)

Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>:

----------
pull_requests: +21891
pull_request: https://github.com/python/cpython/pull/22974

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue42144>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

[issue42144] A missing "goto" in the _ssl module! [ In reply to ]

Oct 25, 2020, 11:02 AM

Post #5 of 8 (47 views)

Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>:

----------
pull_requests: +21892
pull_request: https://github.com/python/cpython/pull/22975

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue42144>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

[issue42144] A missing "goto" in the _ssl module! [ In reply to ]

Oct 25, 2020, 11:21 AM

Post #6 of 8 (47 views)

miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment:

New changeset 8e980ecfb7b42063ed41d665288aff69f0ed7fdc by Miss Skeleton (bot) in branch '3.8':
bpo-42144: Add a missing "goto error;" in the _ssl module (GH-22959)
https://github.com/python/cpython/commit/8e980ecfb7b42063ed41d665288aff69f0ed7fdc

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue42144>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

[issue42144] A missing "goto" in the _ssl module! [ In reply to ]

Oct 25, 2020, 11:23 AM

Post #7 of 8 (47 views)

miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment:

New changeset 83c86cf54b36a7325f615f5adf22b28e48f0e72d by Miss Skeleton (bot) in branch '3.9':
bpo-42144: Add a missing "goto error;" in the _ssl module (GH-22959)
https://github.com/python/cpython/commit/83c86cf54b36a7325f615f5adf22b28e48f0e72d

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue42144>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

[issue42144] A missing "goto" in the _ssl module! [ In reply to ]

Oct 25, 2020, 1:38 PM

Post #8 of 8 (47 views)

Christian Heimes <lists@cheimes.de> added the comment:

Thanks, excellent finding.

----------
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> behavior

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue42144>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com