Mailing List Archive

Ned Deily <nad@python.org> added the comment:

Indeed, the backport to 3.7 slipped through the cracks somehow; we should fix that. Thanks for bringing this up!

----------
resolution: fixed ->
stage: resolved -> backport needed
status: closed -> open

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue33786>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>:


----------
nosy: +miss-islington
nosy_count: 7.0 -> 8.0
pull_requests: +21003
stage: backport needed -> patch review
pull_request: https://github.com/python/cpython/pull/21878

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue33786>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Ned Deily <nad@python.org> added the comment:


New changeset cf79cbf4479e395bf7c4df2907f5a444639b4f6f by Miss Islington (bot) in branch '3.7':
bpo-33786: Fix asynchronous generators to handle GeneratorExit in athrow() (GH-7467) (GH-21878)
https://github.com/python/cpython/commit/cf79cbf4479e395bf7c4df2907f5a444639b4f6f


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue33786>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Ned Deily <nad@python.org> added the comment:

I'm still not sure exactly what happened here but it looks like the backport to 3.7 (PR 7506) from the original fix in master (pre-3.8) (PR 7467) failed but the backport to 3.6 (PR 7507) succeeded. And then it was backported a second time to 3.6 (PR 7514) which also succeeded but had no effect since there were no intervening changes to those files. So it may be that PR 7514 was intended to be for 3.7 instead of 3.6. In any case, a fresh backport from master to 3.7 (PR 21878) succeeded and tests pass, so into 3.7 it goes for release in 3.7.9.

----------
priority: release blocker ->
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue33786>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

Andrew Svetlov <andrew.svetlov@gmail.com> added the comment:

Thank you very much, Ned!

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue33786>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com