Mailing List Archive

[issue40275] test.support has way too many imports
STINNER Victor <vstinner@python.org> added the comment:


New changeset a7f5d93bb6906d0f999248b47295d3a59b130f4d by Hai Shi in branch 'master':
bpo-40275: Use new test.support helper submodules in tests (GH-21449)
https://github.com/python/cpython/commit/a7f5d93bb6906d0f999248b47295d3a59b130f4d


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
STINNER Victor <vstinner@python.org> added the comment:


New changeset bb0424b122e3d222a558bd4177ce37befd3e0347 by Hai Shi in branch 'master':
bpo-40275: Use new test.support helper submodules in tests (GH-21451)
https://github.com/python/cpython/commit/bb0424b122e3d222a558bd4177ce37befd3e0347


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
STINNER Victor <vstinner@python.org> added the comment:


New changeset 4660597b51b3d14ce6269d0ed865ab7e22c6ae1f by Hai Shi in branch 'master':
bpo-40275: Use new test.support helper submodules in tests (GH-21448)
https://github.com/python/cpython/commit/4660597b51b3d14ce6269d0ed865ab7e22c6ae1f


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
Change by hai shi <shihai1991@126.com>:


----------
pull_requests: +20870
pull_request: https://github.com/python/cpython/pull/21727

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
STINNER Victor <vstinner@python.org> added the comment:


New changeset 604bba1f8fe32479c89b9824b2231cc4480dd110 by Hai Shi in branch 'master':
bpo-40275: Use new test.support helper submodules in tests (GH-21452)
https://github.com/python/cpython/commit/604bba1f8fe32479c89b9824b2231cc4480dd110


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
STINNER Victor <vstinner@python.org> added the comment:


New changeset c7decc27d529c04a4e6b2922e3f3f9419b920f63 by Hai Shi in branch 'master':
bpo-40275: Use new test.support helper submodules in tests (GH-21727)
https://github.com/python/cpython/commit/c7decc27d529c04a4e6b2922e3f3f9419b920f63


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
Change by hai shi <shihai1991@126.com>:


----------
pull_requests: +20895
pull_request: https://github.com/python/cpython/pull/21743

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
STINNER Victor <vstinner@python.org> added the comment:


New changeset 79bb2c93f2d81702fdf1f93720369e18a76b7d1a by Hai Shi in branch 'master':
bpo-40275: Use new test.support helper submodules in tests (GH-21743)
https://github.com/python/cpython/commit/79bb2c93f2d81702fdf1f93720369e18a76b7d1a


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
Change by hai shi <shihai1991@126.com>:


----------
pull_requests: +20908
pull_request: https://github.com/python/cpython/pull/21764

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
STINNER Victor <vstinner@python.org> added the comment:


New changeset 598a951844122678de2596dbc1e0e09e2be65fd2 by Hai Shi in branch 'master':
bpo-40275: Use new test.support helper submodules in tests (GH-21764)
https://github.com/python/cpython/commit/598a951844122678de2596dbc1e0e09e2be65fd2


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
Change by hai shi <shihai1991@126.com>:


----------
pull_requests: +20917
pull_request: https://github.com/python/cpython/pull/21772

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
STINNER Victor <vstinner@python.org> added the comment:


New changeset fcce8c649a14f7a81fae82f9f203bb5b5ee0c205 by Hai Shi in branch 'master':
bpo-40275: Use new test.support helper submodules in tests (GH-21772)
https://github.com/python/cpython/commit/fcce8c649a14f7a81fae82f9f203bb5b5ee0c205


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
Change by hai shi <shihai1991@126.com>:


----------
pull_requests: +20922
pull_request: https://github.com/python/cpython/pull/21771

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
STINNER Victor <vstinner@python.org> added the comment:


New changeset d94af3f7ed98e6bfb4bf5f918f464b5e23d3ed1b by Hai Shi in branch 'master':
bpo-40275: Remove test helpers aliases in test.support (GH-21771)
https://github.com/python/cpython/commit/d94af3f7ed98e6bfb4bf5f918f464b5e23d3ed1b


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
Change by hai shi <shihai1991@126.com>:


----------
pull_requests: +20927
pull_request: https://github.com/python/cpython/pull/21785

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
STINNER Victor <vstinner@python.org> added the comment:


New changeset c6f282f3b1cb6da6febc3b8b6d2dc1ef714dbbf7 by Hai Shi in branch 'master':
bpo-40275: Use new test.support helper submodules in tests (GH-21785)
https://github.com/python/cpython/commit/c6f282f3b1cb6da6febc3b8b6d2dc1ef714dbbf7


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
Terry J. Reedy <tjreedy@udel.edu> added the comment:

PR-21771 "Remove test helpers aliases in test.support" was just merged. It needs an immediate followup to document the new locations of constants and functions. The now dead entries in test.suppport doc must be moved into new support module docs, with whatever revisions. As of this moment, the module index has
test
test.support
test.support.script_helper
So temp_dir, for instance, is still documented as part of test.support, which it no longer is, instead of the undocumented test.support.os_helper, where it now exclusively resides.

----------
nosy: +terry.reedy

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
hai shi <shihai1991@126.com> added the comment:

Hi, terry. When creating the new test helpers, the docs have been updated.
such as: https://docs.python.org/3.10/library/test.html#module-test.support.os_helper

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
Pablo Galindo Salgado <pablogsal@gmail.com> added the comment:

PR21771 has broken a considerable amount of buildbopts so we would need to revert it if is not fixed in 24 hours

----------
nosy: +pablogsal

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
Pablo Galindo Salgado <pablogsal@gmail.com> added the comment:

>> This PR has broken a considerable amount of build bots, so we would need to revert it if is not fixed in 24 hours

Whops, sorry I just saw that this is being fixed here #21785, apologies then!

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
Terry J. Reedy <tjreedy@udel.edu> added the comment:

Sorry, I forgot that for the website, 3.x means 3.8, which has only 1 x_helper module. 3.9 has 3 and 3.10 has 7.

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
Terry J. Reedy <tjreedy@udel.edu> added the comment:

The buildbots were fixed with PR-21785. '#' prefixes an issue on bpo, a PR on github. Confusing, especially now that PR #s are catching up to issue #s.

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
hai shi <shihai1991@126.com> added the comment:

# Confusing, especially now that PR #s are catching up to issue #s.
Maybe we need redefine the matching rule(I am not sure about it).

----------
versions: +Python 3.10 -Python 3.9

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
STINNER Victor <vstinner@python.org> added the comment:

test__osx_support and test_selectors are broken, examples:

https://github.com/python/cpython/pull/21806/checks?check_run_id=966438645

2020-08-10T12:04:20.7613070Z ======================================================================
2020-08-10T12:04:20.7613710Z ERROR: test__remove_unsupported_archs (test.test__osx_support.Test_OSXSupport)
2020-08-10T12:04:20.7616560Z ----------------------------------------------------------------------
2020-08-10T12:04:20.7617240Z Traceback (most recent call last):
2020-08-10T12:04:20.7617860Z File "/Users/runner/work/cpython/cpython/Lib/test/test__osx_support.py", line 23, in setUp
2020-08-10T12:04:20.7618560Z self.env = test.support.EnvironmentVarGuard()
2020-08-10T12:04:20.7621650Z AttributeError: module 'test.support' has no attribute 'EnvironmentVarGuard'

and

2020-08-10T12:01:40.0736200Z ======================================================================
2020-08-10T12:01:40.0738440Z ERROR: test_register_bad_fd (test.test_selectors.KqueueSelectorTestCase)
2020-08-10T12:01:40.0742700Z ----------------------------------------------------------------------
2020-08-10T12:01:40.0744640Z Traceback (most recent call last):
2020-08-10T12:01:40.0747460Z File "/Users/runner/work/cpython/cpython/Lib/test/test_selectors.py", line 539, in test_register_bad_fd
2020-08-10T12:01:40.0753630Z bad_f = support.make_bad_fd()
2020-08-10T12:01:40.0757650Z AttributeError: module 'test.support' has no attribute 'make_bad_fd'

Hai Shi: Would you mind to investigate this issue?

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue40275] test.support has way too many imports [ In reply to ]
hai shi <shihai1991@126.com> added the comment:

> Hai Shi: Would you mind to investigate this issue?
Oh, sure, I will check the test cases again.

----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue40275>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com

1 2  View All