Mailing List Archive

[issue36982] Add support for extended color functions in ncurses 6.1
Ned Deily <nad@python.org> added the comment:

PR 17536 was based on the original PR 13534 and has now gone through a couple of rounds of code review. Other than a missing doc change, everything in PR 13534 is covered (and updated) in PR 17536 so I've closed the original PR. Other than adding the doc change and a final core developer review of the last requested changes, this *should* be good to go.

We really need to get this merged since, without it, Python builds fail with the newer versions of ncurses now in most distributions. Once it is merged into master for 3.10, ?ukasz can provide direction about whether and when it should be backported to 3.9 and/or 3.8.

----------
nosy: +hpj, lukasz.langa, ned.deily, serhiy.storchaka
priority: normal -> critical
stage: patch review -> commit review
versions: +Python 3.10, Python 3.9

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue36982>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue36982] Add support for extended color functions in ncurses 6.1 [ In reply to ]
Ned Deily <nad@python.org> added the comment:


New changeset da4e09fff6b483fe858997da5599c25397107ca1 by Hans Petter Jansson in branch 'master':
bpo-36982: Add support for extended color functions in ncurses 6.1 (GH-17536)
https://github.com/python/cpython/commit/da4e09fff6b483fe858997da5599c25397107ca1


----------

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue36982>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue36982] Add support for extended color functions in ncurses 6.1 [ In reply to ]
Ned Deily <nad@python.org> added the comment:

> We really need to get this merged since, without it, Python builds fail with the newer versions of ncurses now in most distributions.

That is a bit of an overstatment on my part. What is true is that test_curses fails on 3.9 and 3.8 when run with ncurses 6.1+. It is also true that the relevant parts of test_curses are often skipped in CI and buildbot runs as described in Issue12669 so a test failure is often not seen.

> ?ukasz can provide direction about whether and when it should be backported to 3.9 and/or 3.8.

We discussed this and decided that a backport to 3.8 was out-of-scope but a backport in time for 3.9.0 might be OK. Alas, I had forgotten that other changes have gone into master for 3.10 prior to this merge which complicates a backport to 3.9, enough that we shouldn't be trying to throw this in just prior to 3.9.0rc1.

Thanks everyone for the work on this!

----------
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
versions: -Python 3.8, Python 3.9

_______________________________________
Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue36982>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com