Mailing List Archive: process for merge during freeze?

process for merge during freeze?

May 16, 2023, 5:51 AM

Post #1 of 4 (144 views)

Once upon a time the process was "ask the pumpking." But we have a
different governance model now and I'm not sure whom to ask. The
things I see getting merged look like a reasonable union of safe and
important, but I don't know how the decision to merge is getting made.
I do have this PR:

https://github.com/Perl/perl5/pull/21046

that I would like to see get in before 5.38. It's safe in that it
only affects one platform and it does fix a build failure in a new
platform/architecture combination. But it seems rude to merge during
freeze without asking, so I'm asking.

Re: process for merge during freeze? [ In reply to ]

fawaka at gmail

May 16, 2023, 7:10 AM

Post #2 of 4 (144 views)

Permalink

On Tue, May 16, 2023 at 2:51?PM Craig A. Berry <craig.a.berry@gmail.com>
wrote:

> Once upon a time the process was "ask the pumpking." But we have a
> different governance model now and I'm not sure whom to ask. The
> things I see getting merged look like a reasonable union of safe and
> important, but I don't know how the decision to merge is getting made.
> I do have this PR:
>
> https://github.com/Perl/perl5/pull/21046
>
> that I would like to see get in before 5.38. It's safe in that it
> only affects one platform and it does fix a build failure in a new
> platform/architecture combination. But it seems rude to merge during
> freeze without asking, so I'm asking.
>

I would argue that anything that is appropriate for backporting is
appropriate to merge at this stage.

Leon

Re: process for merge during freeze? [ In reply to ]

perl5 at tux

May 16, 2023, 7:39 AM

Post #3 of 4 (144 views)

Permalink

On Tue, 16 May 2023 16:10:18 +0200, Leon Timmermans <fawaka@gmail.com> wrote:

> On Tue, May 16, 2023 at 2:51?PM Craig A. Berry <craig.a.berry@gmail.com>
> wrote:
>
> > Once upon a time the process was "ask the pumpking." But we have a
> > different governance model now and I'm not sure whom to ask. The
> > things I see getting merged look like a reasonable union of safe and
> > important, but I don't know how the decision to merge is getting made.
> > I do have this PR:
> >
> > https://github.com/Perl/perl5/pull/21046
> >
> > that I would like to see get in before 5.38. It's safe in that it
> > only affects one platform and it does fix a build failure in a new
> > platform/architecture combination. But it seems rude to merge during
> > freeze without asking, so I'm asking.
>
> I would argue that anything that is appropriate for backporting is
> appropriate to merge at this stage.

I agree

> Leon

--
H.Merijn Brand https://tux.nl Perl Monger http://amsterdam.pm.org/
using perl5.00307 .. 5.37 porting perl5 on HP-UX, AIX, and Linux
https://tux.nl/email.html http://qa.perl.org https://www.test-smoke.org

Re: process for merge during freeze? [ In reply to ]

craig.a.berry at gmail

May 16, 2023, 2:58 PM

Post #4 of 4 (144 views)

Permalink

On Tue, May 16, 2023 at 9:40?AM <perl5@tux.freedom.nl> wrote:
>
> On Tue, 16 May 2023 16:10:18 +0200, Leon Timmermans <fawaka@gmail.com> wrote:
>
> > On Tue, May 16, 2023 at 2:51?PM Craig A. Berry <craig.a.berry@gmail.com>
> > wrote:
> >
> > > Once upon a time the process was "ask the pumpking." But we have a
> > > different governance model now and I'm not sure whom to ask. The
> > > things I see getting merged look like a reasonable union of safe and
> > > important, but I don't know how the decision to merge is getting made.
> > > I do have this PR:
> > >
> > > https://github.com/Perl/perl5/pull/21046
> > >
> > > that I would like to see get in before 5.38. It's safe in that it
> > > only affects one platform and it does fix a build failure in a new
> > > platform/architecture combination. But it seems rude to merge during
> > > freeze without asking, so I'm asking.
> >
> > I would argue that anything that is appropriate for backporting is
> > appropriate to merge at this stage.
>
> I agree

Thanks for the replies, and thanks to all four people who showed up on
GitHub to approve the PR! I've merged it.