Mailing List Archive

Impending Doom ^W Merge on `feature-class` branch
Hi all,

Having had a Christmas break, I've now got around again to finishing
off the last of the failing tests and addressing all the PR comments on
my feature-class branch PR:

https://github.com/Perl/perl5/pull/20647

I believe I still have one comment to look at (Yves' point about
#ifdef-guarding the new symbols).

I intend to merge this in sometime near the start of next week (from
Mon 6th Feb onwards), so we can get this in in time for 5.37.9's
release and give it some more real-world testing.

I've been keeping my Feature::Compat::Class module updated in line with
it, so hopefully when that's out that will be able to use it too.

I've still got to write the `perldelta` entry (and that'll be a fun one
to think through) but aside from that and the #ifdef mentioned above,
I'm not aware of anything else left to do.

If anyone else has anything I may have missed here, let me know by then.

--
Paul "LeoNerd" Evans

leonerd@leonerd.org.uk | https://metacpan.org/author/PEVANS
http://www.leonerd.org.uk/ | https://www.tindie.com/stores/leonerd/
Re: Impending Doom ^W Merge on `feature-class` branch [ In reply to ]
On 2023-02-03 4:43 p.m., Paul "LeoNerd" Evans wrote:
> Having had a Christmas break, I've now got around again to finishing
> off the last of the failing tests and addressing all the PR comments on
> my feature-class branch PR:
>
> https://github.com/Perl/perl5/pull/20647
>
> I intend to merge this in sometime near the start of next week (from
> Mon 6th Feb onwards), so we can get this in in time for 5.37.9's
> release and give it some more real-world testing.

Thank you! I look forward to using this. -- Darren Duncan
Re: Impending Doom ^W Merge on `feature-class` branch [ In reply to ]
On Sat, Feb 4, 2023 at 4:44 AM Paul "LeoNerd" Evans <leonerd@leonerd.org.uk>
wrote:

>
> I intend to merge this in sometime near the start of next week (from
> Mon 6th Feb onwards), so we can get this in in time for 5.37.9's
> release and give it some more real-world testing.
>
>
That's good news!
I'm tracking this PR (and other Corinna-related stuff) closely as everyone
else excited about the new object system.
Re: Impending Doom ^W Merge on `feature-class` branch [ In reply to ]
On Sat, Feb 04, 2023 at 12:43:43AM +0000, Paul "LeoNerd" Evans wrote:
> Having had a Christmas break, I've now got around again to finishing
> off the last of the failing tests and addressing all the PR comments on
> my feature-class branch PR:
...
> If anyone else has anything I may have missed here, let me know by then.

I haven't even begun to look at this area yet, so I have not yet formed
opinions on whether the design or the implementation are sound. But I'm
unlikely to get round to doing this soon, so you might as well go ahead
anyway.

Expect at some point in the future, Internet Explorer meme-like, some
retrospective and possibly out of date comments.

--
Overhead, without any fuss, the stars were going out.
-- Arthur C Clarke
Re: Impending Doom ^W Merge on `feature-class` branch [ In reply to ]
On Sat, 4 Feb 2023 12:44:13 +0000
Dave Mitchell <davem@iabyn.com> wrote:

> Expect at some point in the future, Internet Explorer meme-like, some
> retrospective and possibly out of date comments.

No worries. I fully anticipate that the whole thing will remain marked
"experimental" for quite some time, as it'll be a while until we settle
down all of the design decisions and work out if it's all correct. I
expect there may well be significant rethinks somewhere along the way,
so that's all fine.

--
Paul "LeoNerd" Evans

leonerd@leonerd.org.uk | https://metacpan.org/author/PEVANS
http://www.leonerd.org.uk/ | https://www.tindie.com/stores/leonerd/
Re: Impending Doom ^W Merge on `feature-class` branch [ In reply to ]
On Sat, 4 Feb 2023 00:43:43 +0000
"Paul \"LeoNerd\" Evans" <leonerd@leonerd.org.uk> wrote:

> I believe I still have one comment to look at (Yves' point about
> #ifdef-guarding the new symbols).

This part is now done, and force-pushed once more.

> I intend to merge this in sometime near the start of next week (from
> Mon 6th Feb onwards), so we can get this in in time for 5.37.9's
> release and give it some more real-world testing.

I'm now in the middle of a final test run, checking that unit tests
pass at every commit in the PR. The intention is not to squash them all
down to a single commit this time, because the history is still
interesting here. I'll probably merge it by hand on commandline by
doing `merge --no-ff` to preserve the identity of the history inside
it, while making it appear on the mainline as a single commit for
rebase/bisect purposes.

Hoping to get that merged before the end of the weekend now.

--
Paul "LeoNerd" Evans

leonerd@leonerd.org.uk | https://metacpan.org/author/PEVANS
http://www.leonerd.org.uk/ | https://www.tindie.com/stores/leonerd/
Re: Impending Doom ^W Merge on `feature-class` branch [ In reply to ]
On Thu, 9 Feb 2023 12:59:00 +0000
"Paul \"LeoNerd\" Evans" <leonerd@leonerd.org.uk> wrote:

> Hoping to get that merged before the end of the weekend now.

And we are done :)

Well, done-ish. The actual code is merged, but now I'm writing up the
perldelta entry.

https://github.com/Perl/perl5/pull/20795

--
Paul "LeoNerd" Evans

leonerd@leonerd.org.uk | https://metacpan.org/author/PEVANS
http://www.leonerd.org.uk/ | https://www.tindie.com/stores/leonerd/