Hi all,
I wrote an RFC about making booleans trackable:
https://github.com/Perl/RFCs/pull/3
I then implemented it in a PR:
https://github.com/Perl/perl5/pull/19040
This has been reviewed by Tony C, but aside from that there hasn't been
too much comment. I'd like to progress this into moving forward.
There's already been some excitement around it; I've seen some draft
PRs from things like JSON encoders that are lined up ready to use this
new feature to improve their output.
I'd like to suggest therefore that:
** If there's no other comments by about this time next week, **
** I shall merge the PR. **
Reminder: comments about whether or not the *idea* is good should go
on the RFC *AND NOT THE PR*. Comments on the PR should be restricted
just to whether the actual code has actually implemented the concept of
the idea in the right way. But both kinds are still useful :)
## Request - More Testing
I'm keen to avoid a repeat of the try/catch value context bug (5.34.0
released with an annoying bug that could have been caught with a bit
more user testing). Therefore it'd be *really helpful* if as many
people as actually care about this issue, could help test it.
The code is sitting on this branch:
https://github.com/leonerd/perl5/tree/stable-bool
Build that up, test it against existing code. It shouldn't have any
(measurable) impact on performance, and shouldn't result in any
observable behaviour change of existing code which handles boolean
values. In addition, if you have anything that could be described as
"data serialisation" - perhaps emitting JSON, YAML, binary-encoded
values, whatever... it would be good to test that out as well, and
maybe also experiment with using the new Scalar::Util::isbool() perl
function (or the SvIsBOOL() XS macro in C code) and see if that
generally behaves sensibly. It would be great if more people than just
me have actually tested it before it hits blead. ;)
--
Paul "LeoNerd" Evans
leonerd@leonerd.org.uk | https://metacpan.org/author/PEVANS
http://www.leonerd.org.uk/ | https://www.tindie.com/stores/leonerd/
I wrote an RFC about making booleans trackable:
https://github.com/Perl/RFCs/pull/3
I then implemented it in a PR:
https://github.com/Perl/perl5/pull/19040
This has been reviewed by Tony C, but aside from that there hasn't been
too much comment. I'd like to progress this into moving forward.
There's already been some excitement around it; I've seen some draft
PRs from things like JSON encoders that are lined up ready to use this
new feature to improve their output.
I'd like to suggest therefore that:
** If there's no other comments by about this time next week, **
** I shall merge the PR. **
Reminder: comments about whether or not the *idea* is good should go
on the RFC *AND NOT THE PR*. Comments on the PR should be restricted
just to whether the actual code has actually implemented the concept of
the idea in the right way. But both kinds are still useful :)
## Request - More Testing
I'm keen to avoid a repeat of the try/catch value context bug (5.34.0
released with an annoying bug that could have been caught with a bit
more user testing). Therefore it'd be *really helpful* if as many
people as actually care about this issue, could help test it.
The code is sitting on this branch:
https://github.com/leonerd/perl5/tree/stable-bool
Build that up, test it against existing code. It shouldn't have any
(measurable) impact on performance, and shouldn't result in any
observable behaviour change of existing code which handles boolean
values. In addition, if you have anything that could be described as
"data serialisation" - perhaps emitting JSON, YAML, binary-encoded
values, whatever... it would be good to test that out as well, and
maybe also experiment with using the new Scalar::Util::isbool() perl
function (or the SvIsBOOL() XS macro in C code) and see if that
generally behaves sensibly. It would be great if more people than just
me have actually tested it before it hits blead. ;)
--
Paul "LeoNerd" Evans
leonerd@leonerd.org.uk | https://metacpan.org/author/PEVANS
http://www.leonerd.org.uk/ | https://www.tindie.com/stores/leonerd/