Mailing List Archive: Request for comments on a pep8 problem

Request for comments on a pep8 problem

Aug 3, 2012, 7:11 AM

Post #1 of 4 (1263 views)

Yesterday, I submitted https://review.openstack.org/#/c/10736/ to sync
up an openstack-common change to policy.py; however, the pep8
configuration for quantum does not match the pep8 configuration for the
openstack-common project, and an error is raised. Other projects (in
particular, nova) exempt the openstack/common directory from the pep8
check, but I guess Quantum doesn't have that set up, yet. I wanted to
check here first, however, before I start working on a patch to
accomplish that.

So, does anyone have any problem with exempting the openstack/common
directory from pep8 checks, since anything in openstack/common has
already been checked and tested within the openstack-common project?
--
Kevin L. Mitchell <kevin.mitchell@rackspace.com>

--
Mailing list: https://launchpad.net/~netstack
Post to : netstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~netstack
More help : https://help.launchpad.net/ListHelp

Re: Request for comments on a pep8 problem [ In reply to ]

gkotton at redhat

Aug 3, 2012, 7:48 AM

Post #2 of 4 (1236 views)

Permalink

On 08/03/2012 05:11 PM, Kevin L. Mitchell wrote:
> Yesterday, I submitted https://review.openstack.org/#/c/10736/ to sync
> up an openstack-common change to policy.py; however, the pep8
> configuration for quantum does not match the pep8 configuration for the
> openstack-common project, and an error is raised. Other projects (in
> particular, nova) exempt the openstack/common directory from the pep8
> check, but I guess Quantum doesn't have that set up, yet. I wanted to
> check here first, however, before I start working on a patch to
> accomplish that.

Sadly this is not the first time that this has happened.
Please look at
https://github.com/openstack/quantum/commit/5fcf6ccd952f74d77f6735831c778d33dfcd6136
for a way in which this was handled when there was problematic common
code (it is a temporary measure til these are addressed in the common code).

Will you also be fixing the pep8 issues in the common code?

Thanks
Gary
> So, does anyone have any problem with exempting the openstack/common
> directory from pep8 checks, since anything in openstack/common has
> already been checked and tested within the openstack-common project?

--
Mailing list: https://launchpad.net/~netstack
Post to : netstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~netstack
More help : https://help.launchpad.net/ListHelp

Re: Request for comments on a pep8 problem [ In reply to ]

kevin.mitchell at rackspace

Aug 3, 2012, 7:57 AM

Post #3 of 4 (1235 views)

Permalink

On Fri, 2012-08-03 at 17:48 +0300, Gary Kotton wrote:
> Will you also be fixing the pep8 issues in the common code?

When the pep8 running in openstack-common reports the issue, yes, it
will make sense to fix it. Since I have already synchronized nova and
glance, I'm highly reluctant to make the necessary change. I'll also
point out that the particular condition that pep8 is reporting here is
all over the place in nova and probably also in glanceâ€¦
--
Kevin L. Mitchell <kevin.mitchell@rackspace.com>

--
Mailing list: https://launchpad.net/~netstack
Post to : netstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~netstack
More help : https://help.launchpad.net/ListHelp

Re: [openstack-dev] Request for comments on a pep8 problem [ In reply to ]

mordred at inaugust

Aug 3, 2012, 8:16 AM

Post #4 of 4 (1238 views)

Permalink

On 08/03/2012 09:57 AM, Kevin L. Mitchell wrote:
> On Fri, 2012-08-03 at 17:48 +0300, Gary Kotton wrote:
>> Will you also be fixing the pep8 issues in the common code?
>
> When the pep8 running in openstack-common reports the issue, yes, it
> will make sense to fix it. Since I have already synchronized nova and
> glance, I'm highly reluctant to make the necessary change. I'll also
> point out that the particular condition that pep8 is reporting here is
> all over the place in nova and probably also in glanceâ€¦

If we keep openstack-common testing against latest pep8 (even when it's
a pita) it should allow us to drop that code into any of the projects
without worrying about which version they've caught up to.

Also - I hear that one of these days we're going to make a library out
of openstack common ... how's that coming Mark?

Monty

--
Mailing list: https://launchpad.net/~netstack
Post to : netstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~netstack
More help : https://help.launchpad.net/ListHelp