Mailing List Archive

[PATCH] Include fix
commit 73734a17849bb04a411e6eb29071ecc6dc80efee
Author: Thomas Koeller <thomas@koeller.dyndns.org>
Date: Thu Jan 27 15:26:01 2022 +0100

Include fix

auth.h uses the HostStatus type defined in hostfile.h, which therefore
has to be included.

Signed-off-by: Thomas Koeller <thomas@koeller.dyndns.org>

diff --git a/auth.h b/auth.h
index a65d8fd0..edac85b2 100644
--- a/auth.h
+++ b/auth.h
@@ -40,6 +40,8 @@
#include <krb5.h>
#endif

+#include "hostfile.h"
+
struct passwd;
struct ssh;
struct sshbuf;
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: [PATCH] Include fix [ In reply to ]
> On Jan 27, 2022, at 07:01, Thomas Köller <thomas@koeller.dyndns.org> wrote:
>
> ?commit 73734a17849bb04a411e6eb29071ecc6dc80efee
[...]
> Include fix
>
> auth.h uses the HostStatus type defined in hostfile.h, which therefore
> has to be included.
[...]
> diff --git a/auth.h b/auth.h
> index a65d8fd0..edac85b2 100644
> --- a/auth.h
> +++ b/auth.h
> @@ -40,6 +40,8 @@
[...]

@Thomas, you'll have more likelihood of your patches being accepted if you follow the [OpenSSH bug reporting process][*], so they can be tracked and assigned to a release.

[*]: https://www.openssh.com/report.html
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: [PATCH] Include fix [ In reply to ]
Hi Jim,

thanks for the pointer. However, after reading the document it is
unclear to me what I should have done differently - can you please give
a hint? Is it that I should have used bugzilla?

Am 27.01.22 um 20:29 schrieb Jim Knoble:
>
>> On Jan 27, 2022, at 07:01, Thomas Köller <thomas@koeller.dyndns.org> wrote:
>>
>> ?commit 73734a17849bb04a411e6eb29071ecc6dc80efee
> [...]
>> Include fix
>>
>> auth.h uses the HostStatus type defined in hostfile.h, which therefore
>> has to be included.
> [...]
>> diff --git a/auth.h b/auth.h
>> index a65d8fd0..edac85b2 100644
>> --- a/auth.h
>> +++ b/auth.h
>> @@ -40,6 +40,8 @@
> [...]
>
> @Thomas, you'll have more likelihood of your patches being accepted if you follow the [OpenSSH bug reporting process][*], so they can be tracked and assigned to a release.
>
> [*]: https://www.openssh.com/report.html
> _______________________________________________
> openssh-unix-dev mailing list
> openssh-unix-dev@mindrot.org
> https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: [PATCH] Include fix [ In reply to ]
On Fri, 28 Jan 2022 at 07:46, Thomas Köller <thomas@koeller.dyndns.org>
wrote:

> thanks for the pointer. However, after reading the document it is
> unclear to me what I should have done differently - can you please give
> a hint? Is it that I should have used bugzilla?
>

In this case either is fine. Bugzilla is preferable for anything
non-trivial (having all of the context in one place helps, especially if
it's something that needs rework, we can't look at for a while or needs
tracking over time).

For this specific diff: in most cases we put the required includes in the
.c file. Is there some case where your change is needed to compile?

--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: [PATCH] Include fix [ In reply to ]
On 1/27/22 23:24, Darren Tucker wrote:
> On Fri, 28 Jan 2022 at 07:46, Thomas Köller <thomas@koeller.dyndns.org>
> wrote:
>
>> thanks for the pointer. However, after reading the document it is
>> unclear to me what I should have done differently - can you please give
>> a hint? Is it that I should have used bugzilla?
>>
>
> In this case either is fine. Bugzilla is preferable for anything
> non-trivial (having all of the context in one place helps, especially if
> it's something that needs rework, we can't look at for a while or needs
> tracking over time).

Let me chime in, since I've too posted patches the other day:

https://lists.mindrot.org/pipermail/openssh-unix-dev/2022-January/039930.html

(for unknown reason patch 1/2 is not threaded correctly in the archive)

Are my chances higher if I create a bug and attach patches to it?

Thanks,
Michal

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: [PATCH] Include fix [ In reply to ]
Am 27.01.22 um 23:24 schrieb Darren Tucker:
> For this specific diff: in most cases we put the required includes in
the .c file. Is there some case where your change is needed to compile?

Yes, of course. It is the auth.h header itself that uses a typedef
(HostStatus) from hostfile.h, so including just auth.h without prior
inclusion of hostfile.h leads to a compilation error. That's what the
patch comment tries to express...

I came across this (and the problem addressed by the other patch I
submitted today, which is very similar) writing an extension to sshd
(which I plan to propose when it's ready). This extension adds some new
.c files, and there the two problems surfaced.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: [PATCH] Include fix [ In reply to ]
Am 27.01.22 um 23:24 schrieb Darren Tucker:
> In this case either is fine.  Bugzilla is preferable for anything
> non-trivial (having all of the context in one place helps, especially if
> it's something that needs rework, we can't look at for a while or needs
> tracking over time).

I now uploaded the patch series I was working on to bugzilla:
https://bugzilla.mindrot.org/show_bug.cgi?id=3384. It also contains the
include fixes and therefore I retract this patch and also
https://lists.mindrot.org/pipermail/openssh-unix-dev/2022-January/039946.html.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev