Mailing List Archive

Call for testing: OpenSSH 8.5
Hi,

OpenSSH 8.5p1 is almost ready for release, so we would appreciate testing
on as many platforms and systems as possible. This is a bugfix release.

Snapshot releases for portable OpenSSH are available from
http://www.mindrot.org/openssh_snap/

The OpenBSD version is available in CVS HEAD:
http://www.openbsd.org/anoncvs.html

Portable OpenSSH is also available via git using the
instructions at http://www.openssh.com/portable.html#cvs
At https://anongit.mindrot.org/openssh.git/ or via a mirror at Github:
https://github.com/openssh/openssh-portable

Running the regression tests supplied with Portable OpenSSH does not
require installation and is a simply:

$ ./configure && make tests

Live testing on suitable non-production systems is also appreciated.
Please send reports of success or failure to
openssh-unix-dev@mindrot.org. Security bugs should be reported
directly to openssh@openssh.com.

Below is a summary of changes. More detail may be found in the ChangeLog
in the portable OpenSSH tarballs.

Thanks to the many people who contributed to this release.

Security
========

* Portable sshd(8): Prevent excessively long username going to PAM.

This is a mitigation for a buffer overflow in Solaris' PAM username
handling (CVE-2020-14871), and is only enabled for Sun-derived PAM
implementations. This is not a problem in sshd itself, it only
prevents sshd from being used as a vector to attack Solaris' PAM.
It does not prevent the bug in PAM from being exploited via some
other PAM application. GHPR#212

Potentially-incompatible changes
================================

This release includes a number of changes that may affect existing
configurations:

* ssh(1), sshd(8): this release changes the first-preference signature
algorithm from ECDSA to ED25519.

* ssh(1), sshd(8): set the TOS/DSCP specified in the configuration
for interactive use prior to TCP connect. The connection phase of
the SSH session is time-sensitive and often explicitly interactive.
The ultimate interactive/bulk TOS/DSCP will be set after
authentication completes.

* ssh(1), sshd(8): remove the pre-standardization cipher
rijndael-cbc@lysator.liu.se. It is an alias for aes256-cbc before
it was standardized in RFC4253 (2006), has been deprecated and
disabled by default since OpenSSH 7.2 (2016) and was only briefly
documented in ssh.1 in 2001.

* ssh(1), sshd(8): update/replace the experimental post-quantum
hybrid key exchange method based on Streamlined NTRU Prime coupled
with X25519.

The previous sntrup4591761x25519-sha512@tinyssh.org method is
replaced with sntrup761x25519-sha512@openssh.com. Per its
designers, the sntrup4591761 algorithm was superseded almost two
years ago by sntrup761.

(note this both the updated method and the one that it replaced are
disabled by default)

* ssh(1): disable CheckHostIP by default. It provides insignificant
benefits while making key rotation significantly more difficult,
especially for hosts behind IP-based load-balancers.

Changes since OpenSSH 8.4
=========================

New features
------------

* ssh(1): this release enables UpdateHostkeys by default subject to
some conservative preconditions:
- The key was matched in the UserKnownHostsFile (and not in the
GlobalKnownHostsFile).
- The same key does not exist under another name.
- A certificate host key is not in use.
- known_hosts contains no matching wildcard hostname pattern.
- VerifyHostKeyDNS is not enabled.

We expect some of these conditions will be modified or relaxed in
future.

* ssh(1), sshd(8): add a new LogVerbose configuration directive for
that allows forcing maximum debug logging by file/function/line
pattern-lists.

* ssh(1): when prompting the user to accept a new hostkey, display
any other host names/addresses already associated with the key.

* ssh(1): allow UserKnownHostsFile=none to indicate that no
known_hosts file should be used to identify host keys.

* ssh(1): add a ssh_config KnownHostsCommand that allows the client
to obtain known_hosts data from a command in addition to the usual
files.

* ssh(1): for FIDO keys, if a signature operation fails with a
"incorrect PIN" reason and no PIN was initially requested from the
user, then request a PIN and retry the operation. This supports
some biometric devices that fall back to requiring PIN when reading
of the biometric failed, and devices that require PINs for all
hosted credentials.

* sshd(8): implement client address-based rate-limiting via new
sshd_config(5) PerSourceMaxStartups and PerSourceNetBlockSize
directives that fine-grained control than the global MaxStartups
limit.

Bugfixes
--------

* ssh(1): Prefix keyboard interactive prompts with "(user@host)" to
make it easier to determine which connection they are associated
with in cases like scp -3, ProxyJump, etc. bz#3224

* sshd(8): fix sshd_config SetEnv directives located inside Match
blocks. GHPR#201

* ssh(1): when requesting a FIDO token touch on stderr, inform the
user once the touch has been recorded.

* ssh(1): prevent integer overflow when ridiculously large
ConnectTimeout values are specified, capping the effective value
(for most platforms) at 24 days. bz#3229

* ssh(1): consider the ECDSA key subtype when ordering host key
algorithms in the client,

* ssh(1), sshd(8): rename the PubkeyAcceptedKeyTypes keyword to
PubkeyAcceptedAlgorithms. The previous name incorrectly suggested
that it control allowed key algorithms, when this option actually
specifies the signature algorithms that are accepted. The previous
name remains available as an alias. bz#3253

* ssh(1), sshd(8): similarly, rename HostbasedKeyTypes (ssh) and
HostbasedAcceptedKeyTypes (sshd) to HostbasedAcceptedAlgorithms.

* sftp-server(8): add missing lsetstat@openssh.com documentation
and advertisement in the server's SSH2_FXP_VERSION hello packet.

* ssh(1), sshd(8): more strictly enforce KEX state-machine by
banning packet types once they are received. Fixes memleak caused
by duplicate SSH2_MSG_KEX_DH_GEX_REQUEST (oss-fuzz #30078).

* sftp(1): allow the full range of UIDs/GIDs for chown/chgrp on 32bit
platforms instead of being limited by LONG_MAX. bz#3206

* Minor man page fixes (capitalization, commas, etc.) bz#3223

* sftp(1): when doing an sftp recursive upload or download of a
read-only directory, ensure that the directory is created with
write and execute permissions in the interim so that the transfer
can actually complete, then set the directory permission as the
final step. bz#3222

* ssh-keygen(1): document the -Z, check the validity of its argument
earlier and provide a better error message if it's not correct.
bz#2879

* ssh(1): ignore comments at the end of config lines in ssh_config,
similar to what we already do for sshd_config. bz#2320

* sshd_config(5): mention that DisableForwarding is valid in a
sshd_config Match block. bz3239

* sftp(1): fix incorrect sorting of "ls -ltr" under some
circumstances. bz3248.

* ssh(1), sshd(8): fix potential integer truncation of (unlikely)
timeout values. bz#3250

* ssh(1): make hostbased authentication send the signature algorithm
in its SSH2_MSG_USERAUTH_REQUEST packets instead of the key type.
This make HostbasedAcceptedAlgorithms do what it is supposed to -
filter on signature algorithm and not key type.

Portability
-----------

* sshd(8): add a number of platform-specific syscalls to the Linux
seccomp-bpf sandbox. bz#3232 bz#3260

* sshd(8): remove debug message from sigchld handler that could cause
deadlock on some platforms. bz#3259

* Sync contrib/ssh-copy-id with upstream.

* unittests: add a hostname function for systems that don't have it.
Some systems don't have a hostname command (it's not required by
POSIX). The do have uname -n (which is), but not all of those have
it report the FQDN.

OpenSSH is brought to you by Markus Friedl, Niels Provos, Theo de
Raadt, Kevin Steves, Damien Miller, Darren Tucker, Jason McIntyre,
Tim Rice and Ben Lindstrom.

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On 2/23/21 2:46 AM, Damien Miller wrote:
> * ssh(1), sshd(8): rename the PubkeyAcceptedKeyTypes keyword to
> PubkeyAcceptedAlgorithms. The previous name incorrectly suggested
> that it control allowed key algorithms, when this option actually
> specifies the signature algorithms that are accepted. The previous
> name remains available as an alias. bz#3253

There is still one place in the manual page that refers to this meaning
as key types in last snap:

commit c0a8a29c2487a2fcf83fdcd7a76cbdbe76fa7f73
Author: Jakub Jelen <jjelen@redhat.com>
Date: Tue Feb 23 21:38:24 2021 +0100

sshd_config: Fix reference to algorithms as keys

diff --git a/sshd_config.5 b/sshd_config.5
index 108027b5..6376db10 100644
--- a/sshd_config.5
+++ b/sshd_config.5
@@ -1517,7 +1517,7 @@ sk-ecdsa-sha2-nistp256@openssh.com,
rsa-sha2-512,rsa-sha2-256,ssh-rsa
.Ed
.Pp
-The list of available key types may also be obtained using
+The list of available signature algorithsm may also be obtained using
.Qq ssh -Q PubkeyAcceptedAlgorithms .
.It Cm PubkeyAuthOptions
Sets one or more public key authentication options.


Regards,
--
Jakub Jelen
Senior Software Engineer
Crypto Team, Security Engineering
Red Hat, Inc.

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On 2/23/21 9:40 PM, Jakub Jelen wrote:
> On 2/23/21 2:46 AM, Damien Miller wrote:
>>   * ssh(1), sshd(8): rename the PubkeyAcceptedKeyTypes keyword to
>>     PubkeyAcceptedAlgorithms. The previous name incorrectly suggested
>>     that it control allowed key algorithms, when this option actually
>>     specifies the signature algorithms that are accepted. The previous
>>     name remains available as an alias. bz#3253
>
> There is still one place in the manual page that refers to this meaning
> as key types in last snap:
>
> commit c0a8a29c2487a2fcf83fdcd7a76cbdbe76fa7f73
> Author: Jakub Jelen <jjelen@redhat.com>
> Date:   Tue Feb 23 21:38:24 2021 +0100
>
>     sshd_config: Fix reference to algorithms as keys
>
> diff --git a/sshd_config.5 b/sshd_config.5
> index 108027b5..6376db10 100644
> --- a/sshd_config.5
> +++ b/sshd_config.5
> @@ -1517,7 +1517,7 @@ sk-ecdsa-sha2-nistp256@openssh.com,
>  rsa-sha2-512,rsa-sha2-256,ssh-rsa
>  .Ed
>  .Pp
> -The list of available key types may also be obtained using
> +The list of available signature algorithsm may also be obtained using
>  .Qq ssh -Q PubkeyAcceptedAlgorithms .
>  .It Cm PubkeyAuthOptions
>  Sets one or more public key authentication options.
>
>
> Regards,

Obviously, the same is also in the ssh_config so attaching another
attempt also with a fixed typo in the previous.

commit a981cef1296d77ce70d371ba1fe3d4e5b64ee79d
Author: Jakub Jelen <jjelen@redhat.com>
Date: Tue Feb 23 21:38:24 2021 +0100

sshd_config: Fix reference to algorithms as keys

diff --git a/ssh_config.5 b/ssh_config.5
index 1a36427d..73401583 100644
--- a/ssh_config.5
+++ b/ssh_config.5
@@ -1422,7 +1422,7 @@ sk-ecdsa-sha2-nistp256@openssh.com,
rsa-sha2-512,rsa-sha2-256,ssh-rsa
.Ed
.Pp
-The list of available key types may also be obtained using
+The list of available signature algorithms types may also be obtained using
.Qq ssh -Q PubkeyAcceptedAlgorithms .
.It Cm PubkeyAuthentication
Specifies whether to try public key authentication.
diff --git a/sshd_config.5 b/sshd_config.5
index 108027b5..8deb162d 100644
--- a/sshd_config.5
+++ b/sshd_config.5
@@ -1517,7 +1517,7 @@ sk-ecdsa-sha2-nistp256@openssh.com,
rsa-sha2-512,rsa-sha2-256,ssh-rsa
.Ed
.Pp
-The list of available key types may also be obtained using
+The list of available signature algorithms may also be obtained using
.Qq ssh -Q PubkeyAcceptedAlgorithms .
.It Cm PubkeyAuthOptions
Sets one or more public key authentication options.


Regards,
--
Jakub Jelen
Senior Software Engineer
Crypto Team, Security Engineering
Red Hat, Inc.

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On Tue, 23 Feb 2021, Jakub Jelen wrote:

> On 2/23/21 9:40 PM, Jakub Jelen wrote:
> > On 2/23/21 2:46 AM, Damien Miller wrote:
> >>   * ssh(1), sshd(8): rename the PubkeyAcceptedKeyTypes keyword to
> >>     PubkeyAcceptedAlgorithms. The previous name incorrectly suggested
> >>     that it control allowed key algorithms, when this option actually
> >>     specifies the signature algorithms that are accepted. The previous
> >>     name remains available as an alias. bz#3253
> >
> > There is still one place in the manual page that refers to this meaning
> > as key types in last snap:
> >
> > commit c0a8a29c2487a2fcf83fdcd7a76cbdbe76fa7f73
> > Author: Jakub Jelen <jjelen@redhat.com>
> > Date:   Tue Feb 23 21:38:24 2021 +0100
> >
> >     sshd_config: Fix reference to algorithms as keys
> >
> > diff --git a/sshd_config.5 b/sshd_config.5
> > index 108027b5..6376db10 100644
> > --- a/sshd_config.5
> > +++ b/sshd_config.5
> > @@ -1517,7 +1517,7 @@ sk-ecdsa-sha2-nistp256@openssh.com,
> >  rsa-sha2-512,rsa-sha2-256,ssh-rsa
> >  .Ed
> >  .Pp
> > -The list of available key types may also be obtained using
> > +The list of available signature algorithsm may also be obtained using
> >  .Qq ssh -Q PubkeyAcceptedAlgorithms .
> >  .It Cm PubkeyAuthOptions
> >  Sets one or more public key authentication options.
> >
> >
> > Regards,
>
> Obviously, the same is also in the ssh_config so attaching another
> attempt also with a fixed typo in the previous.

Thanks - I have fixed these and a few more that were lurking under
HostbasedAcceptedAlgorithms and HostKeyAlgorithms.

-d
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On 2021-02-23 at 12:46 +1100, Damien Miller wrote:
> OpenSSH 8.5p1 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible. This is a bugfix release.

Ubuntu 20.04/amd64: all tests passed [openssh-SNAP-20210224.tar.gz]

> * ssh(1), sshd(8): rename the PubkeyAcceptedKeyTypes keyword to
> PubkeyAcceptedAlgorithms. The previous name incorrectly suggested
> that it control allowed key algorithms, when this option actually
> specifies the signature algorithms that are accepted. The previous
> name remains available as an alias. bz#3253

Seeing this available in the server, something I'd somehow missed, led
me to test it out.

Not a regression but an existing issue (seen in 8.3p1), unknown if bug
or comprehension issue but reporting now to fix either docs or code
before release:

# /etc/ssh/sshd_config:
PubkeyAcceptedAlgorithms -ssh-rsa,-ssh-rsa-cert-*,-rsa*

# command-line:
sshd -T | grep -i '^PubkeyAcceptedKeyTypes'

pubkeyacceptedkeytypes ssh-ed25519-cert-v01@openssh.com,ecdsa-sha2-nistp256-cert-v01@openssh.com,ecdsa-sha2-nistp384-cert-v01@openssh.com,ecdsa-sha2-nistp521-cert-v01@openssh.com,sk-ssh-ed25519-cert-v01@openssh.com,sk-ecdsa-sha2-nistp256-cert-v01@openssh.com,rsa-sha2-512-cert-v01@openssh.com,rsa-sha2-256-cert-v01@openssh.com,ssh-rsa-cert-v01@openssh.com,ssh-ed25519,ecdsa-sha2-nistp256,ecdsa-sha2-nistp384,ecdsa-sha2-nistp521,sk-ssh-ed25519@openssh.com,sk-ecdsa-sha2-nistp256@openssh.com,rsa-sha2-512,rsa-sha2-256

So besides the option not being renamed or duplicated under both names
for compatibility ... the glob removals don't work, and attempts to
remove rsa-sha2-256 explicitly don't work here either. Something seems
to be adding them back in?

-Phil
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On Tue, Feb 23, 2021 at 07:08:05PM -0500, Phil Pennock wrote:
[...]
> # command-line:
> sshd -T | grep -i '^PubkeyAcceptedKeyTypes'
>
> pubkeyacceptedkeytypes [...]
>
> So besides the option not being renamed or duplicated

They should not be duplicated, but the not being renamed is an
oversight on my part (the old names are still listed first, so the
config dumper finds them ahead of the new names).

diff --git a/readconf.c b/readconf.c
index b0a85097..a05be047 100644
--- a/readconf.c
+++ b/readconf.c
@@ -308,10 +308,10 @@ static struct {
{ "revokedhostkeys", oRevokedHostKeys },
{ "fingerprinthash", oFingerprintHash },
{ "updatehostkeys", oUpdateHostkeys },
- { "hostbasedkeytypes", oHostbasedAcceptedAlgorithms }, /* obsolete */
{ "hostbasedalgorithms", oHostbasedAcceptedAlgorithms },
- { "pubkeyacceptedkeytypes", oPubkeyAcceptedAlgorithms }, /* obsolete */
+ { "hostbasedkeytypes", oHostbasedAcceptedAlgorithms }, /* obsolete */
{ "pubkeyacceptedalgorithms", oPubkeyAcceptedAlgorithms },
+ { "pubkeyacceptedkeytypes", oPubkeyAcceptedAlgorithms }, /* obsolete */
{ "ignoreunknown", oIgnoreUnknown },
{ "proxyjump", oProxyJump },
{ "securitykeyprovider", oSecurityKeyProvider },
diff --git a/servconf.c b/servconf.c
index b782ccbb..7e94d2d7 100644
--- a/servconf.c
+++ b/servconf.c
@@ -559,13 +559,13 @@ static struct {
{ "rhostsrsaauthentication", sDeprecated, SSHCFG_ALL },
{ "hostbasedauthentication", sHostbasedAuthentication, SSHCFG_ALL },
{ "hostbasedusesnamefrompacketonly", sHostbasedUsesNameFromPacketOnly, SSHCFG_ALL },
- { "hostbasedacceptedkeytypes", sHostbasedAcceptedAlgorithms, SSHCFG_ALL }, /* obsolete */
{ "hostbasedacceptedalgorithms", sHostbasedAcceptedAlgorithms, SSHCFG_ALL },
+ { "hostbasedacceptedkeytypes", sHostbasedAcceptedAlgorithms, SSHCFG_ALL }, /* obsolete */
{ "hostkeyalgorithms", sHostKeyAlgorithms, SSHCFG_GLOBAL },
{ "rsaauthentication", sDeprecated, SSHCFG_ALL },
{ "pubkeyauthentication", sPubkeyAuthentication, SSHCFG_ALL },
- { "pubkeyacceptedkeytypes", sPubkeyAcceptedAlgorithms, SSHCFG_ALL }, /* obsolete */
{ "pubkeyacceptedalgorithms", sPubkeyAcceptedAlgorithms, SSHCFG_ALL },
+ { "pubkeyacceptedkeytypes", sPubkeyAcceptedAlgorithms, SSHCFG_ALL }, /* obsolete */
{ "pubkeyauthoptions", sPubkeyAuthOptions, SSHCFG_ALL },
{ "dsaauthentication", sPubkeyAuthentication, SSHCFG_GLOBAL }, /* alias */
#ifdef KRB5

--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On Wed, 24 Feb 2021 at 11:16, Phil Pennock <phil.pennock@globnix.org> wrote:
> # /etc/ssh/sshd_config:
> PubkeyAcceptedAlgorithms -ssh-rsa,-ssh-rsa-cert-*,-rsa*

"If the specified list begins with a '-' character, then the
specified key types (including wildcards)will be removed from the
default set instead of replacing them."

Only the first "-" indicates the specified patterns are to be removed,
the other ones form part of the patterns and thus don't match any
algorithms. You probably want something like:

$ sudo ./sshd -T -o 'PubkeyAcceptedAlgorithms
-ssh-rsa,ssh-rsa-cert-*,rsa*' | grep -i PubkeyAcceptedAlgorithms
pubkeyacceptedalgorithms
ssh-ed25519-cert-v01@openssh.com,ecdsa-sha2-nistp256-cert-v01@openssh.com,ecdsa-sha2-nistp384-cert-v01@openssh.com,ecdsa-sha2-nistp521-cert-v01@openssh.com,sk-ssh-ed25519-cert-v01@openssh.com,sk-ecdsa-sha2-nistp256-cert-v01@openssh.com,ssh-ed25519,ecdsa-sha2-nistp256,ecdsa-sha2-nistp384,ecdsa-sha2-nistp521,sk-ssh-ed25519@openssh.com,sk-ecdsa-sha2-nistp256@openssh.com

--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On 2021-02-25 at 00:51 +1100, Darren Tucker wrote:
> "If the specified list begins with a '-' character, then the
> specified key types (including wildcards)will be removed from the
> default set instead of replacing them."

So, comprehension issue, I was being illiterate. Thank you, sorry for
that bit of noise.

-Phil, consoling himself that at least one real issue got fixed
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On 2/23/21 2:46 AM, Damien Miller wrote:
> Hi,
>
> OpenSSH 8.5p1 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible. This is a bugfix release.

Hi,
could you also update the ssh-copy-id from Phil?

https://gitlab.com/phil_hands/ssh-copy-id

There were couple of commits since the last update that would be helpful
to bring in.

Added Phil to CC just to make sure there are no other things that he
would like to merge before. There are just couple of issues related to
the usage of the -s switch now.

Regards,
--
Jakub Jelen
Senior Software Engineer
Crypto Team, Security Engineering
Red Hat, Inc.

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On Thu, 25 Feb 2021 at 20:00, Jakub Jelen <jjelen@redhat.com> wrote:
> Hi,
> could you also update the ssh-copy-id from Phil?

I just pulled in all of the changes from Phil's tree as of right now.
Please let me know if there are any other last minute additions that
should go in before the release.

--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
Dear Darren,

If the proposed Edwards solution (
https://github.com/openssh/openssh-portable/pull/230) is not too big, I'd
like to clean it up and get it added.

On Thu, Feb 25, 2021 at 3:13 PM Darren Tucker <dtucker@dtucker.net> wrote:

> On Thu, 25 Feb 2021 at 20:00, Jakub Jelen <jjelen@redhat.com> wrote:
> > Hi,
> > could you also update the ssh-copy-id from Phil?
>
> I just pulled in all of the changes from Phil's tree as of right now.
> Please let me know if there are any other last minute additions that
> should go in before the release.
>
> --
> Darren Tucker (dtucker at dtucker.net)
> GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
> Good judgement comes with experience. Unfortunately, the experience
> usually comes from bad judgement.
> _______________________________________________
> openssh-unix-dev mailing list
> openssh-unix-dev@mindrot.org
> https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
>
>

--
Dmitry Belyavskiy
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On Fri, 26 Feb 2021 at 01:21, Dmitry Belyavskiy <dbelyavs@redhat.com> wrote:
> If the proposed Edwards solution (https://github.com/openssh/openssh-portable/pull/230) is not too big, I'd like to clean it up and get it added.

I'll defer to Damien but to me that looks too big to go in this late
in the release cycle.

--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On 2/25/21 3:11 PM, Darren Tucker wrote:
> On Thu, 25 Feb 2021 at 20:00, Jakub Jelen <jjelen@redhat.com> wrote:
>> Hi,
>> could you also update the ssh-copy-id from Phil?
>
> I just pulled in all of the changes from Phil's tree as of right now.
> Please let me know if there are any other last minute additions that
> should go in before the release.

Thank you.

Now, I have all the test results (from the first snap) with our patches
and I did not notice any unexpected failures.

Thanks,
--
Jakub Jelen
Senior Software Engineer
Crypto Team, Security Engineering
Red Hat, Inc.

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On Fri, 26 Feb 2021, Darren Tucker wrote:

> On Fri, 26 Feb 2021 at 01:21, Dmitry Belyavskiy <dbelyavs@redhat.com> wrote:
> > If the proposed Edwards solution (https://github.com/openssh/openssh-portable/pull/230) is not too big, I'd like to clean it up and get it added.
>
> I'll defer to Damien but to me that looks too big to go in this late
> in the release cycle.

yes, it's too late in the cycle for this. We also don't have any
hardware to test it against - experience has made me reticent to ship
anything to do with PKCS#11 that we can test against only a single
software implementation.

A bigger problem however is libcrypto compatibility. The last time I
checked, libressl lacks the EVP_PKEY functionality for ED25519 keys.
They were considering it then, but I'll have to check back and see
what the status is.

-d
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On Feb 23 12:46, Damien Miller wrote:
> Hi,
>
> OpenSSH 8.5p1 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible. This is a bugfix release.

Builds OOTB on Cygwin, all tests pass.


Thanks,
Corinna

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
Dear Damien,

Is it still possible to include the ssh_config improvements which I proposed last Sunday on this mailing list?

For your convenience, I also created a pull request:

https://github.com/openssh/openssh-portable/pull/231


Best regards,
Volker


Damien Miller wrote:
> Hi,
>
> OpenSSH 8.5p1 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible. This is a bugfix release.
>
> Snapshot releases for portable OpenSSH are available from
> http://www.mindrot.org/openssh_snap/
>
> The OpenBSD version is available in CVS HEAD:
> http://www.openbsd.org/anoncvs.html
>
> Portable OpenSSH is also available via git using the
> instructions at http://www.openssh.com/portable.html#cvs
> At https://anongit.mindrot.org/openssh.git/ or via a mirror at Github:
> https://github.com/openssh/openssh-portable
>
> Running the regression tests supplied with Portable OpenSSH does not
> require installation and is a simply:
>
> $ ./configure && make tests
>
> Live testing on suitable non-production systems is also appreciated.
> Please send reports of success or failure to
> openssh-unix-dev@mindrot.org. Security bugs should be reported
> directly to openssh@openssh.com.
>
> Below is a summary of changes. More detail may be found in the ChangeLog
> in the portable OpenSSH tarballs.
>
> Thanks to the many people who contributed to this release.
>
> Security
> ========
>
> * Portable sshd(8): Prevent excessively long username going to PAM.
>
> This is a mitigation for a buffer overflow in Solaris' PAM username
> handling (CVE-2020-14871), and is only enabled for Sun-derived PAM
> implementations. This is not a problem in sshd itself, it only
> prevents sshd from being used as a vector to attack Solaris' PAM.
> It does not prevent the bug in PAM from being exploited via some
> other PAM application. GHPR#212
>
> Potentially-incompatible changes
> ================================
>
> This release includes a number of changes that may affect existing
> configurations:
>
> * ssh(1), sshd(8): this release changes the first-preference signature
> algorithm from ECDSA to ED25519.
>
> * ssh(1), sshd(8): set the TOS/DSCP specified in the configuration
> for interactive use prior to TCP connect. The connection phase of
> the SSH session is time-sensitive and often explicitly interactive.
> The ultimate interactive/bulk TOS/DSCP will be set after
> authentication completes.
>
> * ssh(1), sshd(8): remove the pre-standardization cipher
> rijndael-cbc@lysator.liu.se. It is an alias for aes256-cbc before
> it was standardized in RFC4253 (2006), has been deprecated and
> disabled by default since OpenSSH 7.2 (2016) and was only briefly
> documented in ssh.1 in 2001.
>
> * ssh(1), sshd(8): update/replace the experimental post-quantum
> hybrid key exchange method based on Streamlined NTRU Prime coupled
> with X25519.
>
> The previous sntrup4591761x25519-sha512@tinyssh.org method is
> replaced with sntrup761x25519-sha512@openssh.com. Per its
> designers, the sntrup4591761 algorithm was superseded almost two
> years ago by sntrup761.
>
> (note this both the updated method and the one that it replaced are
> disabled by default)
>
> * ssh(1): disable CheckHostIP by default. It provides insignificant
> benefits while making key rotation significantly more difficult,
> especially for hosts behind IP-based load-balancers.
>
> Changes since OpenSSH 8.4
> =========================
>
> New features
> ------------
>
> * ssh(1): this release enables UpdateHostkeys by default subject to
> some conservative preconditions:
> - The key was matched in the UserKnownHostsFile (and not in the
> GlobalKnownHostsFile).
> - The same key does not exist under another name.
> - A certificate host key is not in use.
> - known_hosts contains no matching wildcard hostname pattern.
> - VerifyHostKeyDNS is not enabled.
>
> We expect some of these conditions will be modified or relaxed in
> future.
>
> * ssh(1), sshd(8): add a new LogVerbose configuration directive for
> that allows forcing maximum debug logging by file/function/line
> pattern-lists.
>
> * ssh(1): when prompting the user to accept a new hostkey, display
> any other host names/addresses already associated with the key.
>
> * ssh(1): allow UserKnownHostsFile=none to indicate that no
> known_hosts file should be used to identify host keys.
>
> * ssh(1): add a ssh_config KnownHostsCommand that allows the client
> to obtain known_hosts data from a command in addition to the usual
> files.
>
> * ssh(1): for FIDO keys, if a signature operation fails with a
> "incorrect PIN" reason and no PIN was initially requested from the
> user, then request a PIN and retry the operation. This supports
> some biometric devices that fall back to requiring PIN when reading
> of the biometric failed, and devices that require PINs for all
> hosted credentials.
>
> * sshd(8): implement client address-based rate-limiting via new
> sshd_config(5) PerSourceMaxStartups and PerSourceNetBlockSize
> directives that fine-grained control than the global MaxStartups
> limit.
>
> Bugfixes
> --------
>
> * ssh(1): Prefix keyboard interactive prompts with "(user@host)" to
> make it easier to determine which connection they are associated
> with in cases like scp -3, ProxyJump, etc. bz#3224
>
> * sshd(8): fix sshd_config SetEnv directives located inside Match
> blocks. GHPR#201
>
> * ssh(1): when requesting a FIDO token touch on stderr, inform the
> user once the touch has been recorded.
>
> * ssh(1): prevent integer overflow when ridiculously large
> ConnectTimeout values are specified, capping the effective value
> (for most platforms) at 24 days. bz#3229
>
> * ssh(1): consider the ECDSA key subtype when ordering host key
> algorithms in the client,
>
> * ssh(1), sshd(8): rename the PubkeyAcceptedKeyTypes keyword to
> PubkeyAcceptedAlgorithms. The previous name incorrectly suggested
> that it control allowed key algorithms, when this option actually
> specifies the signature algorithms that are accepted. The previous
> name remains available as an alias. bz#3253
>
> * ssh(1), sshd(8): similarly, rename HostbasedKeyTypes (ssh) and
> HostbasedAcceptedKeyTypes (sshd) to HostbasedAcceptedAlgorithms.
>
> * sftp-server(8): add missing lsetstat@openssh.com documentation
> and advertisement in the server's SSH2_FXP_VERSION hello packet.
>
> * ssh(1), sshd(8): more strictly enforce KEX state-machine by
> banning packet types once they are received. Fixes memleak caused
> by duplicate SSH2_MSG_KEX_DH_GEX_REQUEST (oss-fuzz #30078).
>
> * sftp(1): allow the full range of UIDs/GIDs for chown/chgrp on 32bit
> platforms instead of being limited by LONG_MAX. bz#3206
>
> * Minor man page fixes (capitalization, commas, etc.) bz#3223
>
> * sftp(1): when doing an sftp recursive upload or download of a
> read-only directory, ensure that the directory is created with
> write and execute permissions in the interim so that the transfer
> can actually complete, then set the directory permission as the
> final step. bz#3222
>
> * ssh-keygen(1): document the -Z, check the validity of its argument
> earlier and provide a better error message if it's not correct.
> bz#2879
>
> * ssh(1): ignore comments at the end of config lines in ssh_config,
> similar to what we already do for sshd_config. bz#2320
>
> * sshd_config(5): mention that DisableForwarding is valid in a
> sshd_config Match block. bz3239
>
> * sftp(1): fix incorrect sorting of "ls -ltr" under some
> circumstances. bz3248.
>
> * ssh(1), sshd(8): fix potential integer truncation of (unlikely)
> timeout values. bz#3250
>
> * ssh(1): make hostbased authentication send the signature algorithm
> in its SSH2_MSG_USERAUTH_REQUEST packets instead of the key type.
> This make HostbasedAcceptedAlgorithms do what it is supposed to -
> filter on signature algorithm and not key type.
>
> Portability
> -----------
>
> * sshd(8): add a number of platform-specific syscalls to the Linux
> seccomp-bpf sandbox. bz#3232 bz#3260
>
> * sshd(8): remove debug message from sigchld handler that could cause
> deadlock on some platforms. bz#3259
>
> * Sync contrib/ssh-copy-id with upstream.
>
> * unittests: add a hostname function for systems that don't have it.
> Some systems don't have a hostname command (it's not required by
> POSIX). The do have uname -n (which is), but not all of those have
> it report the FQDN.
>
> OpenSSH is brought to you by Markus Friedl, Niels Provos, Theo de
> Raadt, Kevin Steves, Damien Miller, Darren Tucker, Jason McIntyre,
> Tim Rice and Ben Lindstrom.
>
> _______________________________________________
> openssh-unix-dev mailing list
> openssh-unix-dev@mindrot.org
> https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

--
Volker Diels-Grabsch
----<<<((()))>>>----
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On Fri, 26 Feb 2021, Volker Diels-Grabsch wrote:

> Dear Damien,
>
> Is it still possible to include the ssh_config improvements which I
> proposed last Sunday on this mailing list?

No sorry, but I'll look at the right after release. We'll be doing
another release in 2-3 months, so not long to wait.

-d
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
In NetBSD-current, I get the following:

ok known hosts command
all t-exec passed
BUILDDIR=`pwd`; cd ./regress || exit $?; EGREP='/usr/bin/grep -E' make .OBJDIR="${BUILDDIR}/regress" .CURDIR="`pwd`" BUILDDIR="${BUILDDIR}" OBJ="${BUILDDIR}/regress/" PATH="${BUILDDIR}:${PATH}" TEST_ENV=MALLOC_OPTIONS="AJRX" TEST_MALLOC_OPTIONS="AJRX" TEST_SSH_SCP="${BUILDDIR}/scp" TEST_SSH_SSH="${BUILDDIR}/ssh" TEST_SSH_SSHD="${BUILDDIR}/sshd" TEST_SSH_SSHAGENT="${BUILDDIR}/ssh-agent" TEST_SSH_SSHADD="${BUILDDIR}/ssh-add" TEST_SSH_SSHKEYGEN="${BUILDDIR}/ssh-keygen" TEST_SSH_SSHPKCS11HELPER="${BUILDDIR}/ssh-pkcs11-helper" TEST_SSH_SSHKEYSCAN="${BUILDDIR}/ssh-keyscan" TEST_SSH_SFTP="${BUILDDIR}/sftp" TEST_SSH_PKCS11_HELPER="${BUILDDIR}/ssh-pkcs11-helper" TEST_SSH_SK_HELPER="${BUILDDIR}/ssh-sk-helper" TEST_SSH_SFTPSERVER="${BUILDDIR}/sftp-server" TEST_SSH_PLINK="plink" TEST_SSH_PUTTYGEN="puttygen" TEST_SSH_CONCH="conch" TEST_SSH_IPV6="yes" TEST_SSH_UTF8="yes" TEST_SSH_ECC="yes" TEST_SHELL="sh" EXEEXT="" interop-tests && echo all interop-tests pas!
sed
run test putty-transfer.sh ...
putty interop tests not enabled
run test putty-ciphers.sh ...
putty interop tests not enabled
run test putty-kex.sh ...
putty interop tests not enabled
run test conch-ciphers.sh ...
conch interop tests not enabled
all interop-tests passed
cc -o regress/misc/kexfuzz/kexfuzz -L. -Lopenbsd-compat/ -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack -fstack-protector-strong regress/misc/kexfuzz/kexfuzz.o ssh-sk-client.o -lssh -lopenbsd-compat -lssh -lopenbsd-compat -lcrypt -lcrypto -lutil -lz
ld: regress/misc/kexfuzz/kexfuzz.o: in function `do_send_and_receive':
/home/htodd/openssh/regress/misc/kexfuzz/kexfuzz.c:117: undefined reference to `debug'
ld: /home/htodd/openssh/regress/misc/kexfuzz/kexfuzz.c:121: undefined reference to `debug'
ld: regress/misc/kexfuzz/kexfuzz.o: in function `run_kex':
/home/htodd/openssh/regress/misc/kexfuzz/kexfuzz.c:181: undefined reference to `debug'
ld: /home/htodd/openssh/regress/misc/kexfuzz/kexfuzz.c:185: undefined reference to `debug'
*** Error code 1

Stop.
make: stopped in /home/htodd/git/openssh

--
Hisashi T Fujinaka - htodd@twofifty.com
BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
Thanks I think I might remove regress/misc/kexfuzz entirely, it has
been obsoleted by regress/misc/fuzz_harness/kex_fuzz.cc :)

On Thu, 25 Feb 2021, Hisashi T Fujinaka wrote:

> In NetBSD-current, I get the following:
>
> ok known hosts command
> all t-exec passed
> BUILDDIR=`pwd`; cd ./regress || exit $?; EGREP='/usr/bin/grep -E' make
> .OBJDIR="${BUILDDIR}/regress" .CURDIR="`pwd`" BUILDDIR="${BUILDDIR}"
> OBJ="${BUILDDIR}/regress/" PATH="${BUILDDIR}:${PATH}"
> TEST_ENV=MALLOC_OPTIONS="AJRX" TEST_MALLOC_OPTIONS="AJRX"
> TEST_SSH_SCP="${BUILDDIR}/scp" TEST_SSH_SSH="${BUILDDIR}/ssh"
> TEST_SSH_SSHD="${BUILDDIR}/sshd" TEST_SSH_SSHAGENT="${BUILDDIR}/ssh-agent"
> TEST_SSH_SSHADD="${BUILDDIR}/ssh-add"
> TEST_SSH_SSHKEYGEN="${BUILDDIR}/ssh-keygen"
> TEST_SSH_SSHPKCS11HELPER="${BUILDDIR}/ssh-pkcs11-helper"
> TEST_SSH_SSHKEYSCAN="${BUILDDIR}/ssh-keyscan"
> TEST_SSH_SFTP="${BUILDDIR}/sftp"
> TEST_SSH_PKCS11_HELPER="${BUILDDIR}/ssh-pkcs11-helper"
> TEST_SSH_SK_HELPER="${BUILDDIR}/ssh-sk-helper"
> TEST_SSH_SFTPSERVER="${BUILDDIR}/sftp-server" TEST_SSH_PLINK="plink"
> TEST_SSH_PUTTYGEN="puttygen" TEST_SSH_CONCH="conch" TEST_SSH_IPV6="yes"
> TEST_SSH_UTF8="yes" TEST_SSH_ECC="yes" TEST_SHELL="sh" EXEEXT=""
> interop-tests && echo all interop-tests pas!
> sed
> run test putty-transfer.sh ...
> putty interop tests not enabled
> run test putty-ciphers.sh ...
> putty interop tests not enabled
> run test putty-kex.sh ...
> putty interop tests not enabled
> run test conch-ciphers.sh ...
> conch interop tests not enabled
> all interop-tests passed
> cc -o regress/misc/kexfuzz/kexfuzz -L. -Lopenbsd-compat/ -Wl,-z,relro
> -Wl,-z,now -Wl,-z,noexecstack -fstack-protector-strong
> regress/misc/kexfuzz/kexfuzz.o ssh-sk-client.o -lssh -lopenbsd-compat -lssh
> -lopenbsd-compat -lcrypt -lcrypto -lutil -lz
> ld: regress/misc/kexfuzz/kexfuzz.o: in function `do_send_and_receive':
> /home/htodd/openssh/regress/misc/kexfuzz/kexfuzz.c:117: undefined reference
> to `debug'
> ld: /home/htodd/openssh/regress/misc/kexfuzz/kexfuzz.c:121: undefined
> reference to `debug'
> ld: regress/misc/kexfuzz/kexfuzz.o: in function `run_kex':
> /home/htodd/openssh/regress/misc/kexfuzz/kexfuzz.c:181: undefined reference
> to `debug'
> ld: /home/htodd/openssh/regress/misc/kexfuzz/kexfuzz.c:185: undefined
> reference to `debug'
> *** Error code 1
>
> Stop.
> make: stopped in /home/htodd/git/openssh
>
> --
> Hisashi T Fujinaka - htodd@twofifty.com
> BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee
>
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
Dear Damien

On Thu, Feb 25, 2021 at 11:17 PM Damien Miller <djm@mindrot.org> wrote:

> On Fri, 26 Feb 2021, Darren Tucker wrote:
>
> > On Fri, 26 Feb 2021 at 01:21, Dmitry Belyavskiy <dbelyavs@redhat.com>
> wrote:
> > > If the proposed Edwards solution (
> https://github.com/openssh/openssh-portable/pull/230) is not too big, I'd
> like to clean it up and get it added.
> >
> > I'll defer to Damien but to me that looks too big to go in this late
> > in the release cycle.
>
> yes, it's too late in the cycle for this.


Pity but understandable.


> We also don't have any
> hardware to test it against - experience has made me reticent to ship
> anything to do with PKCS#11 that we can test against only a single
> software implementation.
>

Even more pity, but even more understandable.

>
> A bigger problem however is libcrypto compatibility. The last time I
> checked, libressl lacks the EVP_PKEY functionality for ED25519 keys.
> They were considering it then, but I'll have to check back and see
> what the status is.
>

I've added linking-time detection for the EVP_PKEY functionality for
ED25519 keys.
We will not be able to work with keys from X509 certificates but it seems
the only limitation.

Many thanks anyway!

--
Dmitry Belyavskiy
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
Damien Miller wrote:
> Hi,
>
> OpenSSH 8.5p1 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible. This is a bugfix release.
>
>

Builds as 32 bit on SPARC Solaris 10, using Studio 12.2 and our local build
of OpenSSL 1.1.1j, and passes all tests.

--
Jeff Wieland, UNIX Systems Administrator
Purdue University IT Infrastructure Services UNIX Platforms

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On 2/22/21, 17:56, "openssh-unix-dev on behalf of Damien Miller" <openssh-unix-dev-bounces+imorgan=nas.nasa.gov@mindrot.org on behalf of djm@mindrot.org> wrote:

Hi,

OpenSSH 8.5p1 is almost ready for release, so we would appreciate testing
on as many platforms and systems as possible. This is a bugfix release.

...

* sshd(8): implement client address-based rate-limiting via new
sshd_config(5) PerSourceMaxStartups and PerSourceNetBlockSize
directives that fine-grained control than the global MaxStartups
limit.


The sshd_config(5) man page has these new options listed after PidFile, whereas they should be listed before.

--
Iain Morgan

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
fixed - thanks

On Sat, 27 Feb 2021, Morgan, Iain (ARC-TN)[InuTeq, LLC] wrote:

> On 2/22/21, 17:56, "openssh-unix-dev on behalf of Damien Miller" <openssh-unix-dev-bounces+imorgan=nas.nasa.gov@mindrot.org on behalf of djm@mindrot.org> wrote:
>
> Hi,
>
> OpenSSH 8.5p1 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible. This is a bugfix release.
>
> ...
>
> * sshd(8): implement client address-based rate-limiting via new
> sshd_config(5) PerSourceMaxStartups and PerSourceNetBlockSize
> directives that fine-grained control than the global MaxStartups
> limit.
>
>
> The sshd_config(5) man page has these new options listed after PidFile, whereas they should be listed before.
>
> --
> Iain Morgan
>
> _______________________________________________
> openssh-unix-dev mailing list
> openssh-unix-dev@mindrot.org
> https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
>
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On Sat, Feb 27, 2021 at 10:58:52PM +0000, "Morgan, Iain (ARC-TN)[InuTeq, LLC]" <iain.morgan@nasa.gov> wrote:

> On 2/22/21, 17:56, "openssh-unix-dev on behalf of Damien Miller" <openssh-unix-dev-bounces+imorgan=nas.nasa.gov@mindrot.org on behalf of djm@mindrot.org> wrote:
>
> Hi,
>
> OpenSSH 8.5p1 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible. This is a bugfix release.
>
> ...
>
> * sshd(8): implement client address-based rate-limiting via new
> sshd_config(5) PerSourceMaxStartups and PerSourceNetBlockSize
> directives that fine-grained control than the global MaxStartups
> limit.
>
>
> The sshd_config(5) man page has these new options listed after PidFile, whereas they should be listed before.
>
> --
> Iain Morgan

Also, the grammar seems wrong: "directives that
fine-grained control than" should probably be
"directives that provide more fine-grained control
than" (if this is a quote from the manpage and not
just a changelog).

cheers,
raf

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.5 [ In reply to ]
On Sun, 28 Feb 2021, raf wrote:

> Also, the grammar seems wrong: "directives that
> fine-grained control than" should probably be
> "directives that provide more fine-grained control
> than" (if this is a quote from the manpage and not
> just a changelog).

It's just the release notes, but I still appreciate the feedback so
the final version will be less wrong :)

-d
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

1 2  View All