Mailing List Archive

Re: Call for testing: OpenSSH 8.0 [AIX Fail]
On 3/27/19 4:00 AM, Damien Miller wrote:
> Hi,
>
> OpenSSH 8.0p1 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible.
>
> Snapshot releases for portable OpenSSH are available from
> http://www.mindrot.org/openssh_snap/
>
> The OpenBSD version is available in CVS HEAD:
> http://www.openbsd.org/anoncvs.html
>
> Portable OpenSSH is also available via git using the
> instructions at http://www.openssh.com/portable.html#cvs
> At https://anongit.mindrot.org/openssh.git/ or via a mirror at Github:
> https://github.com/openssh/openssh-portable
>
> Running the regression tests supplied with Portable OpenSSH does not
> require installation and is a simply:
>
> $ ./configure && make tests
>

Using openssh-SNAP-20190401.tar.gz
AIX 7200-03-02-1846
OpenSSL 1.0.2p  14 Aug 2018
gcc (GCC) 8.1.0
GNU Make 4.2.1

gmake tests fails:
./configure && gmake tests
...
gcc -O2 -mcpu=powerpc -D_LINUX_SOURCE_COMPAT -pipe -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset   -I. -I. -I/opt/freeware/include -I/opt/phs/include -DSSHDIR=\"/usr/local/etc\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c sshkey.c -o sshkey.o
sshkey.c: In function 'sshkey_format_cert_validity':
sshkey.c:2750:42: warning: '%s' directive output may be truncated writing up to 31 bytes into a region of size between 24 and 55 [-Wformat-truncation=]
   snprintf(ret, sizeof(ret), "from %s to %s", from, to);
                                          ^~         ~~
sshkey.c:2750:3: note: 'snprintf' output between 10 and 72 bytes into a destination of size 64
   snprintf(ret, sizeof(ret), "from %s to %s", from, to);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
gcc -O2 -mcpu=powerpc -D_LINUX_SOURCE_COMPAT -pipe -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset   -I. -I. -I/opt/freeware/include -I/opt/phs/include -DSSHDIR=\"/usr/local/etc\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c channels.c -o channels.o
channels.c: In function 'channel_post_mux_listener':
channels.c:2314:6: warning: implicit declaration of function 'getpeereid'; did you mean 'getpcred'? [-Wimplicit-function-declaratio ]
  if (getpeereid(newsock, &euid, &egid) < 0) {
      ^~~~~~~~~~
      getpcred 
...
gcc -O2 -mcpu=powerpc -D_LINUX_SOURCE_COMPAT -pipe -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset   -I. -I. -I/opt/freeware/include -I/opt/phs/include -DSSHDIR=\"/usr/local/etc\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c hostfile.c -o hostfile.o
hostfile.c: In function 'host_hash':
hostfile.c:151:44: warning: '%s' directive output may be truncated writing up to 511 bytes into a region of size between 509 and 1020 [-Wformat-truncation=]
  snprintf(encoded, sizeof(encoded), "%s%s%c%s", HASH_MAGIC, uu_salt,
                                            ^~
      HASH_DELIM, uu_result);
                  ~~~~~~~~~
hostfile.c:151:2: note: 'snprintf' output between 5 and 1027 bytes into a destination of size 1024
  snprintf(encoded, sizeof(encoded), "%s%s%c%s", HASH_MAGIC, uu_salt,
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      HASH_DELIM, uu_result);
      ~~~~~~~~~~~~~~~~~~~~~~

...
gcc -O2 -mcpu=powerpc -D_LINUX_SOURCE_COMPAT -pipe -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset   -I. -I. -I/opt/freeware/include -I/opt/phs/include -DSSHDIR=\"/usr/local/etc\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c sntrup4591761.c -o sntrup4591761.o
In file included from includes.h:100,
                 from crypto_api.h:11,
                 from sntrup4591761.c:12:
/usr/include/sys/mman.h:148:15: error: conflicting types for 'mmap64'
  extern void *mmap64(void *, size_t, int, int, int, off64_t);
               ^~~~~~
/usr/include/sys/mman.h:143:15: note: previous declaration of 'mmap64' was here
  extern void *mmap(void *, size_t, int, int, int, off_t);
               ^~~~
In file included from /usr/include/pwd.h:158,
                 from platform.h:19,
                 from includes.h:173,
                 from crypto_api.h:11,
                 from sntrup4591761.c:12:
/opt/freeware/lib/gcc/powerpc-ibm-aix7.2.0.0/8.1.0/include-fixed/stdio.h:582:12: error: conflicting types for 'fgetpos64'
 extern int fgetpos64(FILE *, fpos64_t *);
            ^~~~~~~~~
In file included from /usr/include/pwd.h:158,
                 from platform.h:19,
                 from includes.h:173,
                 from crypto_api.h:11,
                 from sntrup4591761.c:12:
/opt/freeware/lib/gcc/powerpc-ibm-aix7.2.0.0/8.1.0/include-fixed/stdio.h:377:12: note: previous declaration of 'fgetpos64' was here
 extern int fgetpos(FILE *__restrict__, fpos_t *__restrict__);
            ^~~~~~~
In file included from /usr/include/pwd.h:158,
                 from platform.h:19,
                 from includes.h:173,
                 from crypto_api.h:11,
                 from sntrup4591761.c:12:
/opt/freeware/lib/gcc/powerpc-ibm-aix7.2.0.0/8.1.0/include-fixed/stdio.h:585:12: error: conflicting types for 'fseeko64'
 extern int fseeko64(FILE *, off64_t, int);
            ^~~~~~~~
In file included from /usr/include/pwd.h:158,
                 from platform.h:19,
                 from includes.h:173,
                 from crypto_api.h:11,
                 from sntrup4591761.c:12:
/opt/freeware/lib/gcc/powerpc-ibm-aix7.2.0.0/8.1.0/include-fixed/stdio.h:525:12: note: previous declaration of 'fseeko64' was here
 extern int fseeko(FILE *, off_t, int);
            ^~~~~~
In file included from /usr/include/pwd.h:158,
                 from platform.h:19,
                 from includes.h:173,
                 from crypto_api.h:11,
                 from sntrup4591761.c:12:
/opt/freeware/lib/gcc/powerpc-ibm-aix7.2.0.0/8.1.0/include-fixed/stdio.h:586:12: error: conflicting types for 'fsetpos64'
 extern int fsetpos64(FILE *, const fpos64_t *);
            ^~~~~~~~~
In file included from /usr/include/pwd.h:158,
                 from platform.h:19,
                 from includes.h:173,
                 from crypto_api.h:11,
                 from sntrup4591761.c:12:
/opt/freeware/lib/gcc/powerpc-ibm-aix7.2.0.0/8.1.0/include-fixed/stdio.h:379:12: note: previous declaration of 'fsetpos64' was here
 extern int fsetpos(FILE *, const fpos_t *);
            ^~~~~~~
In file included from /usr/include/pwd.h:158,
                 from platform.h:19,
                 from includes.h:173,
                 from crypto_api.h:11,
                 from sntrup4591761.c:12:
/opt/freeware/lib/gcc/powerpc-ibm-aix7.2.0.0/8.1.0/include-fixed/stdio.h:587:16: error: conflicting types for 'ftello64'
 extern off64_t ftello64(FILE *);
                ^~~~~~~~
In file included from /usr/include/pwd.h:158,
                 from platform.h:19,
                 from includes.h:173,
                 from crypto_api.h:11,
                 from sntrup4591761.c:12:
/opt/freeware/lib/gcc/powerpc-ibm-aix7.2.0.0/8.1.0/include-fixed/stdio.h:526:14: note: previous declaration of 'ftello64' was here
 extern off_t ftello(FILE *);
              ^~~~~~
gmake: *** [Makefile:161: sntrup4591761.o] Error 1



--
# include <stddisclaimer.h>
/* Kevin Brott <Kevin.Brott@GMail.com> */

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.0 [AIX Fail] [ In reply to ]
On Sun, 31 Mar 2019 at 19:01, Kevin Brott <kevin.brott@gmail.com> wrote:
[...]
> Using openssh-SNAP-20190401.tar.gz
> AIX 7200-03-02-1846
> OpenSSL 1.0.2p 14 Aug 2018
> gcc (GCC) 8.1.0
> GNU Make 4.2.1
[...]
> sshkey.c: In function 'sshkey_format_cert_validity':
> sshkey.c:2750:42: warning: '%s' directive output may be truncated writing up to 31 bytes into a region of size between 24 and 55 [-Wformat-truncation=]
> snprintf(ret, sizeof(ret), "from %s to %s", from, to);
> ^~ ~~
> sshkey.c:2750:3: note: 'snprintf' output between 10 and 72 bytes into a destination of size 64
> snprintf(ret, sizeof(ret), "from %s to %s", from, to);

should be harmless: the input strings are limited to 20 bytes by being
formatted as ISO8601 timestamps. Will revisit after release.

> channels.c: In function 'channel_post_mux_listener':
> channels.c:2314:6: warning: implicit declaration of function 'getpeereid'; did you mean 'getpcred'? [-Wimplicit-function-declaratio ]

Does AIX7 have getpeereid? If not, the prototype should come from
openbsd-compat.h, if so maybe we need to add a header?

> hostfile.c: In function 'host_hash':
> hostfile.c:151:44: warning: '%s' directive output may be truncated writing up to 511 bytes into a region of size between 509 and 1020 [-Wformat-truncation=]
> snprintf(encoded, sizeof(encoded), "%s%s%c%s", HASH_MAGIC, uu_salt,

not sure yet.
.
> gcc -O2 -mcpu=powerpc -D_LINUX_SOURCE_COMPAT -pipe -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -I. -I. -I/opt/freeware/include -I/opt/phs/include -DSSHDIR=\"/usr/local/etc\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c sntrup4591761.c -o sntrup4591761.o
> In file included from includes.h:100,
> from crypto_api.h:11,
> from sntrup4591761.c:12:
> /usr/include/sys/mman.h:148:15: error: conflicting types for 'mmap64'

I think this is due to missing compat stuff. Try adding:

#include "includes.h"

to the start of sntrup4591761.c.

--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.0 [AIX Fail] [ In reply to ]
Looks like getpeerid exists, AIX 7 has a manpage for gettpeerid(3) anyway:
...
Syntax

#include <sys/types.h>
int getpeereid (int socket, uid_t *euid, gid_t *egid)
...

Re-ran configure / make against openssh-SNAP-20190402.tar.gz on AIX 7.1 and
7.2 ... build now gets past the original failure (still has same warning /
info messages) like so:

...
gcc -O2 -mcpu=powerpc -D_LINUX_SOURCE_COMPAT -pipe -Wall -Wpointer-arith
-Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess
-Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing
-D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -I. -I.. -I. -I./..
-I/opt/freeware/include -I/opt/phs/include -DHAVE_CONFIG_H -c glob.c
glob.c:94: warning: "TILDE" redefined
#define TILDE '~'

In file included from ../openbsd-compat/openbsd-compat.h:226,
from ../includes.h:174,
from glob.c:61:
/usr/include/sys/ioctl.h:271: note: this is the location of the previous
definition
#define TILDE 0x00080000 /* hazeltine tilde kludge */
...
gmake[1]: Entering directory '/lppdir/build/openssh/openbsd-compat'
gcc -O2 -mcpu=powerpc -D_LINUX_SOURCE_COMPAT -pipe -Wall -Wpointer-arith
-Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess
-Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing
-D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -I. -I.. -I. -I./..
-I/opt/freeware/include -I/opt/phs/include -DHAVE_CONFIG_H -c port-aix.c
port-aix.c:316:1: error: conflicting types for 'record_failed_login'
record_failed_login(const char *user, const char *hostname, const char
*ttyname)
^~~~~~~~~~~~~~~~~~~
In file included from ../audit.h:28:0,
from ../auth.h:166,
from port-aix.c:34:
../loginrec.h:131:6: note: previous declaration of 'record_failed_login'
was here
void record_failed_login(struct ssh *, const char *, const char *,
^~~~~~~~~~~~~~~~~~~
gmake[1]: *** [Makefile:99: port-aix.o] Error 1
gmake[1]: Leaving directory '/lppdir/build/openssh/openbsd-compat'
gmake: *** [Makefile:165: openbsd-compat/libopenbsd-compat.a] Error 2


On Mon, Apr 1, 2019 at 1:54 AM Darren Tucker <dtucker@dtucker.net> wrote:

> On Sun, 31 Mar 2019 at 19:01, Kevin Brott <kevin.brott@gmail.com> wrote:
> [...]
> > Using openssh-SNAP-20190401.tar.gz
> > AIX 7200-03-02-1846
> > OpenSSL 1.0.2p 14 Aug 2018
> > gcc (GCC) 8.1.0
> > GNU Make 4.2.1
> [...]
> > sshkey.c: In function 'sshkey_format_cert_validity':
> > sshkey.c:2750:42: warning: '%s' directive output may be truncated
> writing up to 31 bytes into a region of size between 24 and 55
> [-Wformat-truncation=]
> > snprintf(ret, sizeof(ret), "from %s to %s", from, to);
> > ^~ ~~
> > sshkey.c:2750:3: note: 'snprintf' output between 10 and 72 bytes into a
> destination of size 64
> > snprintf(ret, sizeof(ret), "from %s to %s", from, to);
>
> should be harmless: the input strings are limited to 20 bytes by being
> formatted as ISO8601 timestamps. Will revisit after release.
>
> > channels.c: In function 'channel_post_mux_listener':
> > channels.c:2314:6: warning: implicit declaration of function
> 'getpeereid'; did you mean 'getpcred'? [-Wimplicit-function-declaratio ]
>
> Does AIX7 have getpeereid? If not, the prototype should come from
> openbsd-compat.h, if so maybe we need to add a header?
>
> > hostfile.c: In function 'host_hash':
> > hostfile.c:151:44: warning: '%s' directive output may be truncated
> writing up to 511 bytes into a region of size between 509 and 1020
> [-Wformat-truncation=]
> > snprintf(encoded, sizeof(encoded), "%s%s%c%s", HASH_MAGIC, uu_salt,
>
> not sure yet.
> .
> > gcc -O2 -mcpu=powerpc -D_LINUX_SOURCE_COMPAT -pipe -Wall -Wpointer-arith
> -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess
> -Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing
> -D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -I. -I.
> -I/opt/freeware/include -I/opt/phs/include -DSSHDIR=\"/usr/local/etc\"
> -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\"
> -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\"
> -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\"
> -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\"
> -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\"
> -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\"
> -DHAVE_CONFIG_H -c sntrup4591761.c -o sntrup4591761.o
> > In file included from includes.h:100,
> > from crypto_api.h:11,
> > from sntrup4591761.c:12:
> > /usr/include/sys/mman.h:148:15: error: conflicting types for 'mmap64'
>
> I think this is due to missing compat stuff. Try adding:
>
> #include "includes.h"
>
> to the start of sntrup4591761.c.
>
> --
> Darren Tucker (dtucker at dtucker.net)
> GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
> Good judgement comes with experience. Unfortunately, the experience
> usually comes from bad judgement.
>


--
# include <stddisclaimer.h>
/* Kevin Brott <Kevin.Brott@gmail.com> */
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.0 [AIX Fail] [ In reply to ]
On Mon, 1 Apr 2019 at 23:23, Kevin Brott <kevin.brott@gmail.com> wrote:
[...]
> port-aix.c:316:1: error: conflicting types for 'record_failed_login'
> record_failed_login(const char *user, const char *hostname, const char *ttyname)

I think I just fixed that by changing the function to match the new
prototype. Unfortunately I can't currently test it myself. Please
report any further problems.

Thanks!

http://anongit.mindrot.org/openssh.git/commit/?id=138c0d52cdc90f9895333b82fc57d81cce7a3d90

--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.0 [AIX Fail] [ In reply to ]
Using openssh-SNAP-20190403.tar.gz ... testing on current patchlevels of
AIX 7.1 and 7.2.

Mixed results - native builds using AIX's licensed xlC compiler compile and
pass all tests.
Builds using gcc/make from the Linux Toolbox get further - but die at
loginrec.o now:

AIX 7.2
=====
OpSys : AIX 7200-03-02-1846
Compiler: xlC (xlC.rte:13.1.3.1)
Make : aix make (bos.adt.base:7.2.3.15)
OpenSSL : OpenSSL 1.0.2p 14 Aug 2018 (openssl.base:1.0.2.1601)
*Results : all tests passed*
====
OpSys : AIX 7200-03-02-1846
Compiler: gcc (GCC) 8.1.0
Make : GNU Make 4.2.1
OpenSSL : OpenSSL 1.0.2p 14 Aug 2018
*Results : FAIL*

./configure && gmake tests
...
gcc -O2 -mcpu=powerpc -D_LINUX_SOURCE_COMPAT -pipe -Wall -Wpointer-arith
-Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess
-Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing
-D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -I. -I.
-I/opt/freeware/include -I/opt/phs/include -DSSHDIR=\"/usr/local/etc\"
-D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\"
-D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\"
-D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\"
-D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\"
-D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\"
-D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\"
-DHAVE_CONFIG_H -c loginrec.c -o loginrec.o
loginrec.c: In function 'login_write':
loginrec.c:469:31: warning: passing argument 1 of 'sys_auth_record_login'
from incompatible pointer type [-Wincompatible-pointer-types]
!sys_auth_record_login(li->username,li->hostname,li->line,
~~^~~~~~~~~~
In file included from openbsd-compat/openbsd-compat.h:334,
from includes.h:174,
from loginrec.c:148:
openbsd-compat/port-aix.h:93:27: note: expected 'struct ssh *' but argument
is of type 'char *'
int sys_auth_record_login(struct ssh *, const char *, const char *,
^~~~~~~~~~~~
loginrec.c:470:6: warning: passing argument 4 of 'sys_auth_record_login'
from incompatible pointer type [-Wincompatible-pointer-types]
loginmsg))
^~~~~~~~
In file included from openbsd-compat/openbsd-compat.h:334,
from includes.h:174,
from loginrec.c:148:
openbsd-compat/port-aix.h:94:5: note: expected 'const char *' but argument
is of type 'struct sshbuf *'
const char *, struct sshbuf *);
^~~~~~~~~~~~
loginrec.c:469:7: error: too few arguments to function
'sys_auth_record_login'
!sys_auth_record_login(li->username,li->hostname,li->line,
^~~~~~~~~~~~~~~~~~~~~
In file included from openbsd-compat/openbsd-compat.h:334,
from includes.h:174,
from loginrec.c:148:
openbsd-compat/port-aix.h:93:5: note: declared here
int sys_auth_record_login(struct ssh *, const char *, const char *,
^~~~~~~~~~~~~~~~~~~~~
gmake: *** [Makefile:161: loginrec.o] Error 1
=====

AIX 7.1
=====
OpSys : AIX 7100-05-03-1846
Compiler: xlC (xlC.rte:13.1.3.1)
Make : make (bos.adt.base:7.1.5.31)
OpenSSL : OpenSSL 1.0.2p 14 Aug 2018 (openssl.base:1.0.2.1601)
*Results : all tests passed*
=====
OpSys : AIX 7100-05-03-1846
Compiler: gcc (GCC) 6.3.0
Make : GNU Make 4.2.1
OpenSSL : OpenSSL 1.0.2p 14 Aug 2018
*Results : FAIL*

./configure && gmake tests
...
gcc -O2 -mcpu=powerpc -D_LINUX_SOURCE_COMPAT -pipe -Wall -Wpointer-arith
-Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess
-Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing
-D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -I. -I.
-I/opt/freeware/include -I/opt/phs/include -DSSHDIR=\"/usr/local/etc\"
-D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\"
-D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\"
-D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\"
-D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\"
-D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\"
-D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\"
-DHAVE_CONFIG_H -c loginrec.c -o loginrec.o
loginrec.c: In function 'login_write':
loginrec.c:469:29: warning: passing argument 1 of 'sys_auth_record_login'
from incompatible pointer type [-Wincompatible-pointer-types]
!sys_auth_record_login(li->username,li->hostname,li->line,
^~
In file included from openbsd-compat/openbsd-compat.h:334:0,
from includes.h:174,
from loginrec.c:148:
openbsd-compat/port-aix.h:93:5: note: expected 'struct ssh *' but argument
is of type 'char *'
int sys_auth_record_login(struct ssh *, const char *, const char *,
^~~~~~~~~~~~~~~~~~~~~
loginrec.c:470:6: warning: passing argument 4 of 'sys_auth_record_login'
from incompatible pointer type [-Wincompatible-pointer-types]
loginmsg))
^~~~~~~~
In file included from openbsd-compat/openbsd-compat.h:334:0,
from includes.h:174,
from loginrec.c:148:
openbsd-compat/port-aix.h:93:5: note: expected 'const char *' but argument
is of type 'struct sshbuf *'
int sys_auth_record_login(struct ssh *, const char *, const char *,
^~~~~~~~~~~~~~~~~~~~~
loginrec.c:469:7: error: too few arguments to function
'sys_auth_record_login'
!sys_auth_record_login(li->username,li->hostname,li->line,
^~~~~~~~~~~~~~~~~~~~~
In file included from openbsd-compat/openbsd-compat.h:334:0,
from includes.h:174,
from loginrec.c:148:
openbsd-compat/port-aix.h:93:5: note: declared here
int sys_auth_record_login(struct ssh *, const char *, const char *,
^~~~~~~~~~~~~~~~~~~~~
gmake: *** [Makefile:161: loginrec.o] Error 1

=====


On Tue, Apr 2, 2019 at 12:25 AM Darren Tucker <dtucker@dtucker.net> wrote:

> On Mon, 1 Apr 2019 at 23:23, Kevin Brott <kevin.brott@gmail.com> wrote:
> [...]
> > port-aix.c:316:1: error: conflicting types for 'record_failed_login'
> > record_failed_login(const char *user, const char *hostname, const char
> *ttyname)
>
> I think I just fixed that by changing the function to match the new
> prototype. Unfortunately I can't currently test it myself. Please
> report any further problems.
>
> Thanks!
>
>
> http://anongit.mindrot.org/openssh.git/commit/?id=138c0d52cdc90f9895333b82fc57d81cce7a3d90
>
> --
> Darren Tucker (dtucker at dtucker.net)
> GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
> Good judgement comes with experience. Unfortunately, the experience
> usually comes from bad judgement.
>


--
# include <stddisclaimer.h>
/* Kevin Brott <Kevin.Brott@gmail.com> */
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.0 [AIX Fail] [ In reply to ]
On Tue, 2 Apr 2019 at 18:08, Kevin Brott <kevin.brott@gmail.com> wrote:
> Mixed results - native builds using AIX's licensed xlC compiler compile and pass all tests.
> Builds using gcc/make from the Linux Toolbox get further - but die at loginrec.o now:

I think I just fixed that one too:
http://anongit.mindrot.org/openssh.git/commit/?id=79a87d32783d6c9db40af8f35e091d9d30365ae7

I'm not even sure why xlc didn't choke on that too (my guess is that
it would have written incorrect login entries). If you are able,
could you please login in and out of a newly built sshd (running as
root) a couple of times and check that the reported "last logged in
from" data seems sane.

Thanks!

--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Call for testing: OpenSSH 8.0 [AIX Fail] [ In reply to ]
On 4/2/19 12:36 PM, Darren Tucker wrote:
> On Tue, 2 Apr 2019 at 18:08, Kevin Brott <kevin.brott@gmail.com> wrote:
>> Mixed results - native builds using AIX's licensed xlC compiler compile and pass all tests.
>> Builds using gcc/make from the Linux Toolbox get further - but die at loginrec.o now:
> I think I just fixed that one too:
> http://anongit.mindrot.org/openssh.git/commit/?id=79a87d32783d6c9db40af8f35e091d9d30365ae7
>
> I'm not even sure why xlc didn't choke on that too (my guess is that
> it would have written incorrect login entries). If you are able,
> could you please login in and out of a newly built sshd (running as
> root) a couple of times and check that the reported "last logged in
> from" data seems sane.
>
> Thanks!
>

Looks like the latest patches did the trick ... using openssh-SNAP-20190405.tar.gz ...


AIX 7.2
=====
OpSys   : AIX 7200-03-02-1846
Compiler: gcc (GCC) 8.1.0
Make    : GNU Make 4.2.1
OpenSSL : OpenSSL 1.0.2p  14 Aug 2018
Results : all tests passed
=====
OpSys   : AIX 7200-03-02-1846
Compiler: xlC (xlC.rte:13.1.3.1)
Make    : make (bos.adt.base:7.2.3.15)
OpenSSL : OpenSSL 1.0.2p  14 Aug 2018 (openssl.base:1.0.2.1601)
Results : all tests passed
=====

AIX 7.1
=====
OpSys   : AIX 7100-05-03-1846
Compiler: gcc (GCC) 6.3.0
Make    : GNU Make 4.2.1
OpenSSL : OpenSSL 1.0.2p  14 Aug 2018
Results : all tests passed
=====
OpSys   : AIX 7100-05-03-1846
Compiler: xlC (xlC.rte:13.1.3.1)
Make    : make (bos.adt.base:7.1.5.31)
OpenSSL : OpenSSL 1.0.2p  14 Aug 2018 (openssl.base:1.0.2.1601)
Results : all tests passed
=====

also - just for regression testing - using the same snapshot ...

=====
OpSys   : Debian GNU/Linux 9.8 (stretch)
Compiler: gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
Make    : GNU Make 4.1
OpenSSL : OpenSSL 1.1.0j  20 Nov 2018
Results : all tests passed
=====

Testing with with newly built ./sshd ( -Ddef $PWD/regres/sshd_config ) on AIX 7.1 and 7.2 - fired up a working ssh daemon that I could connect to repeatedly. The test logins show up in 'last' output and in the user attribute time_last_login when using lsuser against the account.  So it looks like it's working as expected.


--
# include <stddisclaimer.h>
/* Kevin Brott <Kevin.Brott@GMail.com> */

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev