Mailing List Archive

[openssh] 01/03: child_set_eng: verify both env pointer and count.
This is an automated email from the git hooks/post-receive script.

dtucker pushed a commit to branch master
in repository openssh.

commit 05b8e88ebe23db690abbfb1a91111abea09cde08
Author: Darren Tucker <dtucker@dtucker.net>
Date: Thu Mar 30 13:53:29 2023 +1100

child_set_eng: verify both env pointer and count.

If child_set env was called with a NULL env pointer and a non-zero count
it would end up in a null deref, although we don't currently do this.
Prompted by Coverity CID 291850, tweak & ok djm@
---
misc.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/misc.c b/misc.c
index 6135b155..63c3d4d2 100644
--- a/misc.c
+++ b/misc.c
@@ -2273,6 +2273,8 @@ child_set_env(char ***envp, u_int *envsizep, const char *name,
* If we're passed an uninitialized list, allocate a single null
* entry before continuing.
*/
+ if ((*envp == NULL) != (*envsizep == 0))
+ fatal_f("environment size mismatch");
if (*envp == NULL && *envsizep == 0) {
*envp = xmalloc(sizeof(char *));
*envp[0] = NULL;

--
To stop receiving notification emails like this one, please contact
djm@mindrot.org.
_______________________________________________
openssh-commits mailing list
openssh-commits@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-commits