Mailing List Archive

https://bugzilla.mindrot.org/show_bug.cgi?id=3416

--- Comment #2 from Darren Tucker <dtucker@dtucker.net> ---
Created attachment 3586
--> https://bugzilla.mindrot.org/attachment.cgi?id=3586&action=edit
Check that returned events were actually requestd

I collapsed the checks onto the same line and put the cheaper check
first.

Does this also resolve the problem?

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3416

--- Comment #3 from Yaroslav <yaroslav.kuzmin@vmssoftware.com> ---
yes it resolve the problem

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3416

Damien Miller <djm@mindrot.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |djm@mindrot.org
Attachment #3586| |ok+
Flags| |

--- Comment #4 from Damien Miller <djm@mindrot.org> ---
Comment on attachment 3586
--> https://bugzilla.mindrot.org/attachment.cgi?id=3586
Check that returned events were actually requestd

Looks good to me. Although unrelated, I think the POLLIN case should
check (revents & (POLLIN|POLLHUP)) as this can be returned too (not
sure whether without POLLIN too).

Also maybe both POLLIN and POLLOUT cases should check POLLERR in
revents. I saw this in bug #3405

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3416

--- Comment #5 from Darren Tucker <dtucker@dtucker.net> ---
(In reply to Damien Miller from comment #4)
> Looks good to me. Although unrelated, I think the POLLIN case should
> check (revents & (POLLIN|POLLHUP)) as this can be returned too (not
> sure whether without POLLIN too).

I don't follow: it's not checking revents that will be returned from
poll(), it's checking events that were passed to poll(). According to
the man page POLLHUP is meaningless and ignored in events and only
meaningful in revents (which we're not checking).

> Also maybe both POLLIN and POLLOUT cases should check POLLERR in
> revents. I saw this in bug #3405

Good point, I'll do that as a separate patch.

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3416

--- Comment #6 from Darren Tucker <dtucker@dtucker.net> ---
(In reply to Darren Tucker from comment #5)
[...]
> > Also maybe both POLLIN and POLLOUT cases should check POLLERR in
> > revents. I saw this in bug #3405
>
> Good point, I'll do that as a separate patch.

I take that back :-)

Same thing, we are not checking the return from a poll(), we are
checking the return from a select() and mapping it to what would be
returned by poll(). Conditions that would cause poll() to set POLLERR
will cause select to set the bit in readfds or writefds (likely both),
but we can't tell that from what select returns. We won't see there's
an error condition until the calling code attempts a read or write and
gets a 0 or -1 returned.

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3416

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED

--- Comment #7 from Darren Tucker <dtucker@dtucker.net> ---
Anyway the patch has been applied (both master and V_8_9) and will be
in the next release. Thanks for the report.

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs