Mailing List Archive

[Bug 3336] openssh-8.6_p1 fails to build tests with glibc 2.34
https://bugzilla.mindrot.org/show_bug.cgi?id=3336

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |dtucker@dtucker.net

--- Comment #1 from Darren Tucker <dtucker@dtucker.net> ---
Sigh. From the OpenBSD closefrom(2) man page:
"""
int
closefrom(int fd);
[...]
HISTORY
The closefrom() function first appeared in Solaris 9 and has been
available since OpenBSD 3.5.
"""
However in glibc 2.34:

$ grep closefrom posix/unistd.h
extern void closefrom (int __lowfd) __THROW;

(Despite its presence under posix/, POSIX does not specify closefrom():
https://pubs.opengroup.org/onlinepubs/9699919799/functions/close.html
"""
The standard developers rejected a proposal to add closefrom() to the
standard. Because the standard permits implementations to use inherited
file descriptors as a means of providing a conforming environment for
the child process, it is not possible to standardize an interface that
closes arbitrary file descriptors above a certain value while still
guaranteeing a conforming environment.
"""

Of the systems that I have at hand:
- on OpenBSD 6.9, NetBSD 8 and DragonFlyBSD 6, MINIX3 closefrom
returns int.
- on Solaris 10, FreeBSD 12 closefrom return void.

so it's already a tire fire.

I vaguely recall a reason it doesn't include openbsd-compat.h. We
might be able to get away with just config.h and HAVE_CLOSEFROM.

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 3336] openssh-8.6_p1 fails to build tests with glibc 2.34 [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=3336

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Blocks| |3302


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3302
[Bug 3302] Tracking bug for openssh-8.7
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 3336] openssh-8.6_p1 fails to build tests with glibc 2.34 [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=3336

--- Comment #2 from Darren Tucker <dtucker@dtucker.net> ---
Created attachment 3543
--> https://bugzilla.mindrot.org/attachment.cgi?id=3543&action=edit
use includes.h in compat tests.

Please try this patch.

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 3336] openssh-8.6_p1 fails to build tests with glibc 2.34 [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=3336

--- Comment #3 from Timo Gurr <timo.gurr@gmail.com> ---
(In reply to Darren Tucker from comment #2)
> Created attachment 3543 [details]
> use includes.h in compat tests.
>
> Please try this patch.

Thanks! The provided patch works for me on both glibc 2.34 which was
failing before and also on 2.33.

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 3336] openssh-8.6_p1 fails to build tests with glibc 2.34 [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=3336

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #4 from Darren Tucker <dtucker@dtucker.net> ---
The patch has been applied and will be in the next major release.
Thanks for the report.

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs