Mailing List Archive

https://bugzilla.mindrot.org/show_bug.cgi?id=3205

--- Comment #2 from Randall S. Becker <rsbecker@nexbridge.com> ---
We went to c99 because some of the constructs in the regression suite
do not compile with c89. I don't mind going back to c89 but there will
be a larger set of changes.

I'll share a patch listing here once I get this compiling correctly.

Note: the Big-Endian part has worked since 6.x - does not seem to take
any specific mods to get that working.

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3205

--- Comment #3 from Randall S. Becker <rsbecker@nexbridge.com> ---
One thing that has me confused:

cc -c99 -I. -I. -I/usr/local-ssl1.1/include -Wnowarn=262,1252
-I/usr/local-ssl1.1/include -DSSHDIR=\"/usr/local-ssl1.1/etc\"
-D_PATH_SSH_PROGRAM=\"/usr/local-ssl1.1/bin/ssh\"
-D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local-ssl1.1/libexec/ssh-askpass\"
-D_PATH_SFTP_SERVER=\"/usr/local-ssl1.1/libexec/sftp-server\"
-D_PATH_SSH_KEY_SIGN=\"/usr/local-ssl1.1/libexec/ssh-keysign\"
-D_PATH_SSH_PKCS11_HELPER=\"/usr/local-ssl1.1/libexec/ssh-pkcs11-helper\"
-D_PATH_SSH_SK_HELPER=\"/usr/local-ssl1.1/libexec/ssh-sk-helper\"
-D_PATH_SSH_PIDDIR=\"/var/run\"
-D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -fPIC -shared
-o regress/misc/sk-dummy/sk-dummy.so regress/misc/sk-dummy/sk-dummy.lo
regress/misc/sk-dummy/fatal.lo ed25519.lo hash.lo ge25519.lo fe25519.lo
sc25519.lo verify.lo \
-L. -Lopenbsd-compat -lopenbsd-compat -L. -Lopenbsd-compat/
-L/usr/local-ssl1.1/lib -L/usr/local-ssl1.1/lib -lcrypto -lz
c99: error: Invalid input file
extension"regress/misc/sk-dummy/sk-dummy.lo".
c99: error: Invalid input file
extension"regress/misc/sk-dummy/fatal.lo".
c99: error: Invalid input file extension"ed25519.lo".
c99: error: Invalid input file extension"hash.lo".
c99: error: Invalid input file extension"ge25519.lo".
c99: error: Invalid input file extension"fe25519.lo".
c99: error: Invalid input file extension"sc25519.lo".
c99: error: Invalid input file extension"verify.lo".

I'm not sure how to fix this in your build structure.

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3205

--- Comment #4 from Randall S. Becker <rsbecker@nexbridge.com> ---
Created attachment 3443
--> https://bugzilla.mindrot.org/attachment.cgi?id=3443&action=edit
Git diff for patches associated with the NonStop port

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3205

Damien Miller <djm@mindrot.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |djm@mindrot.org

--- Comment #5 from Damien Miller <djm@mindrot.org> ---
(In reply to Randall S. Becker from comment #3)
> One thing that has me confused:
>
> cc -c99 -I. -I. -I/usr/local-ssl1.1/include -Wnowarn=262,1252
> -I/usr/local-ssl1.1/include -DSSHDIR=\"/usr/local-ssl1.1/etc\"
> -D_PATH_SSH_PROGRAM=\"/usr/local-ssl1.1/bin/ssh\"
> -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local-ssl1.1/libexec/ssh-
> askpass\"
> -D_PATH_SFTP_SERVER=\"/usr/local-ssl1.1/libexec/sftp-server\"
> -D_PATH_SSH_KEY_SIGN=\"/usr/local-ssl1.1/libexec/ssh-keysign\"
> -D_PATH_SSH_PKCS11_HELPER=\"/usr/local-ssl1.1/libexec/ssh-pkcs11-
> helper\"
> -D_PATH_SSH_SK_HELPER=\"/usr/local-ssl1.1/libexec/ssh-sk-helper\"
> -D_PATH_SSH_PIDDIR=\"/var/run\"
> -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -fPIC
> -shared -o regress/misc/sk-dummy/sk-dummy.so
> regress/misc/sk-dummy/sk-dummy.lo regress/misc/sk-dummy/fatal.lo
> ed25519.lo hash.lo ge25519.lo fe25519.lo sc25519.lo verify.lo \
> -L. -Lopenbsd-compat -lopenbsd-compat -L. -Lopenbsd-compat/
> -L/usr/local-ssl1.1/lib -L/usr/local-ssl1.1/lib -lcrypto -lz
> c99: error: Invalid input file
> extension"regress/misc/sk-dummy/sk-dummy.lo".
> c99: error: Invalid input file
> extension"regress/misc/sk-dummy/fatal.lo".
> c99: error: Invalid input file extension"ed25519.lo".
> c99: error: Invalid input file extension"hash.lo".
> c99: error: Invalid input file extension"ge25519.lo".
> c99: error: Invalid input file extension"fe25519.lo".
> c99: error: Invalid input file extension"sc25519.lo".
> c99: error: Invalid input file extension"verify.lo".
>
> I'm not sure how to fix this in your build structure.

these .lo files are identical to their .o counterparts except they were
compiled with -fPIC for linkage into a shared object (.so) for use by
dlopen(3). If your system is not going to use client-side FIDO security
key support, then it's fine to simply skip this (--disable-security-key
at configure time, though possibly we need some makefile surgery too)

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3205

--- Comment #6 from Darren Tucker <dtucker@dtucker.net> ---
(In reply to Damien Miller from comment #5)
[...]
> these .lo files are identical to their .o counterparts except they
> were compiled with -fPIC for linkage into a shared object (.so) for
> use by dlopen(3).

There's a similar problem with AIX, which has an, err, interesting
linker. The traditional solution to this is libtool, but that AFAICT
that'd require overhauling the entire build system.

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs

https://bugzilla.mindrot.org/show_bug.cgi?id=3205

--- Comment #7 from Randall S. Becker <rsbecker@nexbridge.com> ---
AFAIK (and have tested) c89,c99 do not support .lo files on input. This
is a gcc extension for -fPIC files. For c89, -fPIC still generates .o
files and accepts PIC .o files on input when building .so DLLs.

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs