Mailing List Archive

[Bug 2265] ServerAlive{Interval, CountMax} ignored if using an active -R or -L tunnel
https://bugzilla.mindrot.org/show_bug.cgi?id=2265

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |dtucker@dtucker.net

--- Comment #3 from Darren Tucker <dtucker@dtucker.net> ---
Created attachment 3417
--> https://bugzilla.mindrot.org/attachment.cgi?id=3417&action=edit
ServerAliveInterval doesn't work if client keeps trying to send data

Patch in question for commenting.

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2265] ServerAlive{Interval, CountMax} ignored if using an active -R or -L tunnel [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=2265

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Blocks| |3162


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3162
[Bug 3162] Tracking bug for 8.4 release
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2265] ServerAlive{Interval, CountMax} ignored if using an active -R or -L tunnel [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=2265

--- Comment #4 from Darren Tucker <dtucker@dtucker.net> ---
Comment on attachment 3417
--> https://bugzilla.mindrot.org/attachment.cgi?id=3417
ServerAliveInterval doesn't work if client keeps trying to send data

Looks mostly ok, there's a couple of long lines and one comment:

>+ timeout_secs = server_alive_time - now;
>+ if (timeout_secs < 0)
>+ timeout_secs = 0;

This can be a MAXIMUM(..) which is shorter and consistent with the rest
of the code.

I'll attach an updated patch shortly.

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2265] ServerAlive{Interval, CountMax} ignored if using an active -R or -L tunnel [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=2265

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #3417|0 |1
is obsolete| |
CC| |djm@mindrot.org
Attachment #3419| |ok?(djm@mindrot.org)
Flags| |

--- Comment #5 from Darren Tucker <dtucker@dtucker.net> ---
Created attachment 3419
--> https://bugzilla.mindrot.org/attachment.cgi?id=3419&action=edit
Make ServerAlive behave correctly during client port forward activity

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2265] ServerAlive{Interval, CountMax} ignored if using an active -R or -L tunnel [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=2265

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #3419|ok?(djm@mindrot.org) |
Flags| |
Attachment #3419|0 |1
is obsolete| |
Attachment #3420| |ok?(djm@mindrot.org)
Flags| |

--- Comment #6 from Darren Tucker <dtucker@dtucker.net> ---
Created attachment 3420
--> https://bugzilla.mindrot.org/attachment.cgi?id=3420&action=edit
Move the ServerAlive scheduling into a helper function.

To me this is a bit easier to read.

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2265] ServerAlive{Interval, CountMax} ignored if using an active -R or -L tunnel [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=2265

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #3420|0 |1
is obsolete| |
Attachment #3420|ok?(djm@mindrot.org) |
Flags| |
Attachment #3421| |ok?(djm@mindrot.org)
Flags| |

--- Comment #7 from Darren Tucker <dtucker@dtucker.net> ---
Created attachment 3421
--> https://bugzilla.mindrot.org/attachment.cgi?id=3421&action=edit
Move the ServerAlive scheduling into a helper function.

fix typo

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 2265] ServerAlive{Interval, CountMax} ignored if using an active -R or -L tunnel [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=2265

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #8 from Darren Tucker <dtucker@dtucker.net> ---
(modified) patch applied and and will be in the 8.4 release. Thanks
for the report and patch.

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs