Mailing List Archive

[Bug 3071] unhandled EINTR while connecting causes ssh to exit prematurely
https://bugzilla.mindrot.org/show_bug.cgi?id=3071

Damien Miller <djm@mindrot.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #3329|0 |1
is obsolete| |
CC| |djm@mindrot.org,
| |dtucker@dtucker.net
Attachment #3401| |ok?(dtucker@dtucker.net)
Flags| |

--- Comment #1 from Damien Miller <djm@mindrot.org> ---
Created attachment 3401
--> https://bugzilla.mindrot.org/attachment.cgi?id=3401&action=edit
handle EINTR in connect_timeout() and waitfd()

I think the timeout_connect() case in the previous patch is slightly
wrong. The connect() call did not succeed and needs to be retried.

Darren, is this even necessary with your recent signal changes?

--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 3071] unhandled EINTR while connecting causes ssh to exit prematurely [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=3071

--- Comment #2 from Darren Tucker <dtucker@dtucker.net> ---
(In reply to Damien Miller from comment #1)
> Darren, is this even necessary with your recent signal changes?

I think it'll now work correctly anything that sets SA_RESTART but we
don't do that on every platform for reasons, so this diff is probably
needed for their benefit.

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs
[Bug 3071] unhandled EINTR while connecting causes ssh to exit prematurely [ In reply to ]
https://bugzilla.mindrot.org/show_bug.cgi?id=3071

Darren Tucker <dtucker@dtucker.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #3401|ok?(dtucker@dtucker.net) |ok+
Flags| |

--- Comment #3 from Darren Tucker <dtucker@dtucker.net> ---
Comment on attachment 3401
--> https://bugzilla.mindrot.org/attachment.cgi?id=3401
handle EINTR in connect_timeout() and waitfd()

>+ } else if (errno == EINTR)
>+ continue;

maybe also EAGAIN?

--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
_______________________________________________
openssh-bugs mailing list
openssh-bugs@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-bugs