Mailing List Archive

[Bug 697] ending slash is not used
http://bugzilla.mindrot.org/show_bug.cgi?id=697

Summary: ending slash is not used
Product: Portable OpenSSH
Version: 3.7.1p1
Platform: PPC
OS/Version: AIX
Status: NEW
Severity: normal
Priority: P2
Component: sftp-server
AssignedTo: openssh-bugs@mindrot.org
ReportedBy: ramses@smeyers.be


C:\temp>psftp <server>
login as: <user>
Using username "<user>".
<user>@<server>'s password:
Remote working directory is /var/spool/rmon-server/guy.leroy
psftp> get 2003*
/var/spool/rmon-server/guy.leroy2003*: no such file or directory
psftp> cd /var/spool/rmon-server/guy.leroy
Remote directory is now /var/spool/rmon-server/guy.leroy
psftp> get 2003*
/var/spool/rmon-server/guy.leroy2003*: no such file or directory
psftp> pwd
Remote directory is /var/spool/rmon-server/guy.leroy
psftp>

so he doesn't do /var/spool/rmon-server/guy.leroy/2003*



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 697] ending slash is not used [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=697

mouring@eviladmin.org changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |INVALID



------- Additional Comments From mouring@eviladmin.org 2003-09-23 15:45 -------
This sounds like a psftp.exe issue. It has no bearing on OpenSSH. Please
contact them.

Nor can I reproduce this on any platform I run sftp-server with the latest
release of psftp.exe



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 697] ending slash is not used [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=697

ramses@smeyers.be changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|INVALID |



------- Additional Comments From ramses@smeyers.be 2003-09-23 17:59 -------
we use the latest psftp.exe, from the site, and it worked perfectly in the past
with an openssh 3.6.1p2, now, with upgrading to 3.7.1p1, we introduced this
problem....



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 697] ending slash is not used [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=697





------- Additional Comments From jacobn+mindrot@chiark.greenend.org.uk 2003-09-24 19:19 -------
Note that wildcards wouldn't have worked the way you expect in PSFTP anyway
(because we haven't implemented them yet).

I'm looking at PSFTP to see if the bug could be there.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 697] ending slash is not used [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=697





------- Additional Comments From ramses@smeyers.be 2003-09-24 19:24 -------
more test samples (already with 3.7.1p2)

-rw-r--r-- 1 rmon rmon 329557 Sep 23 16:20 20030921-lux01-WTS7
-rw-r--r-- 1 rmon rmon 358828 Sep 23 16:32 20030921-lux01-WTS8
drwxrwx--- 2 root system 512 Jun 19 16:33 lost+found
psftp> ls 20030921-lux01-WTS8
Listing directory /var/spool/rmon-server/guy.leroy20030921-lux01-WTS8
Unable to open 20030921-lux01-WTS8: no such file or directory
psftp> get 20030921-lux01-WTS8
/var/spool/rmon-server/guy.leroy20030921-lux01-WTS8: no such file or directory
psftp> get /var/spool/rmon-server/guy.leroy/20030921-lux01-WTS8
/var/spool/rmon-server/guy.leroy20030921-lux01-WTS8: no such file or directory
psftp> get /var/spool/rmon-server/guy.leroy//20030921-lux01-WTS8
/var/spool/rmon-server/guy.leroy20030921-lux01-WTS8: no such file or directory
psftp> get /var/spool/rmon-server/guy.leroy\//20030921-lux01-WTS8
/var/spool/rmon-server/guy.leroy\/: no such file or directory
psftp>



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 697] ending slash is not used [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=697





------- Additional Comments From jacobn+mindrot@chiark.greenend.org.uk 2003-10-01 07:08 -------
We've had one other report of these symptoms, with clients PSFTP 0.53b and
2003-09-22 and server also OpenSSH 3.7.1p1 on AIX 4.3.3.11.

Is it possible that sftp-server's response to SSH_FXP_REALPATH changed between
whichever OpenSSH release worked (don't know what that is) and 3.7.1p1?
(Possibly only on AIX.)
I can't see how else to get these symptoms.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 697] ending slash is not used [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=697





------- Additional Comments From markus@openbsd.org 2003-10-01 07:28 -------
i don't see changes in cvs annotate.

1.28 (itojun 23-Jun-01): static void
1.1 (markus 31-Aug-00): process_realpath(void)
1.1 (markus 31-Aug-00): {
1.1 (markus 31-Aug-00): char resolvedname[MAXPATHLEN];
1.1 (markus 31-Aug-00): u_int32_t id;
1.1 (markus 31-Aug-00): char *path;
1.1 (markus 31-Aug-00):
1.1 (markus 31-Aug-00): id = get_int();
1.1 (markus 31-Aug-00): path = get_string(NULL);
1.7 (markus 09-Dec-00): if (path[0] == '\0') {
1.7 (markus 09-Dec-00): xfree(path);
1.7 (markus 09-Dec-00): path = xstrdup(".");
1.7 (markus 09-Dec-00): }
1.36 (deraadt 23-Jun-02): TRACE("realpath id %u path %s", id,
path);
1.1 (markus 31-Aug-00): if (realpath(path, resolvedname) ==
NULL) {
1.1 (markus 31-Aug-00): send_status(id,
errno_to_portable(errno));
1.1 (markus 31-Aug-00): } else {
1.1 (markus 31-Aug-00): Stat s;
1.1 (markus 31-Aug-00): attrib_clear(&s.attrib);
1.1 (markus 31-Aug-00): s.name = s.long_name =
resolvedname;
1.1 (markus 31-Aug-00): send_names(id, 1, &s);
1.1 (markus 31-Aug-00): }
1.1 (markus 31-Aug-00): xfree(path);
1.1 (markus 31-Aug-00): }
1.1 (markus 31-Aug-00):




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 697] ending slash is not used [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=697





------- Additional Comments From jacobn+mindrot@chiark.greenend.org.uk 2003-10-01 09:12 -------
There do however appear to have been noticeable changes in
openbsd-compat/realpath.c between 3.6*p* and 3.7*p* in portable OpenSSH, of a
kind that could plausibly cause this.

configure.ac appears to define BROKEN_REALPATH on *-*-aix*, which I'm assuming
pulls in that realpath implementation.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 697] ending slash is not used [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=697

jacobn+mindrot@chiark.greenend.org.uk changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |jacobn+mindrot@chiark.greene
| |nd.org.uk





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 697] ending slash is not used [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=697

putty@projects.tartarus.org changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |putty@projects.tartarus.org





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 697] ending slash is not used [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=697





------- Additional Comments From mouring@eviladmin.org 2003-10-01 09:42 -------
Created an attachment (id=475)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=475&action=view)
Sync muckup fix

Apply this and recompile. Looks like I didn't complete the sync with OpenBSD.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 697] ending slash is not used [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=697

jacobn+mindrot@chiark.greenend.org.uk changed:

What |Removed |Added
----------------------------------------------------------------------------
CC|jacobn+mindrot@chiark.greene|
|nd.org.uk |





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 697] ending slash is not used [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=697





------- Additional Comments From ramses@smeyers.be 2003-10-01 20:24 -------
using AIX 5.1.0ML04 with AC_DEFINE(BROKEN_REALPATH)
patch works




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 697] ending slash is not used [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=697

mouring@eviladmin.org changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED



------- Additional Comments From mouring@eviladmin.org 2003-10-01 23:15 -------
This patch was applied last night to the --current tree.

- Ben



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.