Mailing List Archive

[Bug 597] X11 Forwarding: sshd doesn't listen on unix domain sockets
http://bugzilla.mindrot.org/show_bug.cgi?id=597

Summary: X11 Forwarding: sshd doesn't listen on unix domain
sockets
Product: Portable OpenSSH
Version: -current
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P2
Component: sshd
AssignedTo: openssh-bugs@mindrot.org
ReportedBy: ajax@osuny.co.uk


on some operating systems there is a performance benefit to using PF_UNIX
sockets instead of just 127.0.0.1:6010. sshd should support this if possible.

a simple patch would just add this to channels.c:x11_create_display_inet(), but
i'm not sure that's the Right Thing. you would want to be able to get both
127.0.0.1:6010 and /tmp/.X11-unix/X10 (incrementing the screen number until you
find a unique one), and then set DISPLAY=:10.0 if you got a unix domain socket.
and you should probably also be able to configure sshd to not listen to unix
sockets (cygwin, ancient SysV machines, ...).

i'm working on a patch. anything else i should consider? i know there are
other "local" X transports on some SysV machines, but i'd have to check the X
source to see how that's done, and i'm not sure it's worth supporting.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 597] X11 Forwarding: sshd doesn't listen on unix domain sockets [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=597





------- Additional Comments From markus@openbsd.org 2003-06-18 01:56 -------
this is very unlikely because of this is very different among unices
and not portable.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 597] X11 Forwarding: sshd doesn't listen on unix domain sockets [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=597





------- Additional Comments From mouring@eviladmin.org 2003-06-18 01:58 -------
This is troublesome at best. We already find some version of X that optimize
their behavior when they see 'localhost' as their DISPLAY=. I suspect you'll
find a lot more that will do this type of optimization for UNIX domain sockets.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 597] X11 Forwarding: sshd doesn't listen on unix domain sockets [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=597





------- Additional Comments From djm@mindrot.org 2003-06-18 08:38 -------
What performance benefit are you talking about? Most optimisations that X
servers perform when using unix domain sockets (shared memory, etc) are only
appropriate when the server and the client are on the same machine.

If you are referring to differing performance of TCP and unix domain sockets,
remember that such differences are likely to be small compared to encryption and
network delays.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.