Mailing List Archive

[Bug 591] use PKCS#15 private key label as a comment in case of OpenSC
http://bugzilla.mindrot.org/show_bug.cgi?id=591

Summary: use PKCS#15 private key label as a comment in case of
OpenSC
Product: Portable OpenSSH
Version: -current
Platform: All
OS/Version: Linux
Status: NEW
Severity: enhancement
Priority: P2
Component: Smartcard
AssignedTo: openssh-bugs@mindrot.org
ReportedBy: larsch@trustcenter.de


Attached is patch with which the ssh-agent will use the optional PKCS#15
private key label (if existing) as the comment for the smartcard key
(instead of the standard comment "smartcard key"). In case sc_get_key_label
returns NULL the standard comment is used.

Comments etc. are welcome,
Nils



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 591] use PKCS#15 private key label as a comment in case of OpenSC [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=591





------- Additional Comments From larsch@trustcenter.de 2003-06-10 21:22 -------
Created an attachment (id=325)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=325&action=view)
suggested patch




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 591] use PKCS#15 private key label as a comment in case of OpenSC [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=591





------- Additional Comments From markus@openbsd.org 2003-06-13 05:13 -------
Created an attachment (id=326)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=326&action=view)
changes to openbsd.

i've commited this to openbsd.

ssh and ssh-agent assume that sc_get_key_label() always
return a xfree()-able string.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 591] use PKCS#15 private key label as a comment in case of OpenSC [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=591





------- Additional Comments From larsch@trustcenter.de 2003-06-17 20:21 -------
Hi Markus, applying your patch to the portable cvs version and patching
scard-opensc.c with my patch (plus removing the 'const' in the sc_get_key_label
argument in scard-opensc.c) works fine for me with OpenSC.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 591] use PKCS#15 private key label as a comment in case of OpenSC [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=591

larsch@trustcenter.de changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #325 is|0 |1
obsolete| |



------- Additional Comments From larsch@trustcenter.de 2003-06-17 21:14 -------
Created an attachment (id=329)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=329&action=view)
new patch for the portable release (based on Markus openbsd patch)




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 591] use PKCS#15 private key label as a comment in case of OpenSC [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=591

larsch@trustcenter.de changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #329 is|0 |1
obsolete| |



------- Additional Comments From larsch@trustcenter.de 2003-06-17 23:28 -------
Created an attachment (id=330)
--> (http://bugzilla.mindrot.org/attachment.cgi?id=330&action=view)
fix: sc_get_key_label should *not* return NULL




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 591] use PKCS#15 private key label as a comment in case of OpenSC [ In reply to ]
http://bugzilla.mindrot.org/show_bug.cgi?id=591

djm@mindrot.org changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED



------- Additional Comments From djm@mindrot.org 2003-06-28 18:02 -------
Applied - thanks.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.