Mailing List Archive

On Sun, 2023-06-04 at 13:44 +0100, John Pilkington wrote:
> There's a current pull request (#44) seeking to add a new audio
> visualizer.  I have a build that works, but not by all routes.
>
> Lists of visualizers are available at
>
> Frontend setup > Video > Playback OSD > Visualiser for audio only...\

IIRC this comes from mythtv/libs/libmythtv/visualisations/*

> and also at
>
> Listen to Music > play > Menu > More Options > Change visualiser


This comes from mythplugins/mythmusic/mythmusic/visualizations.cpp

> and similarly at
>
> Play radio stream


I'm not sure where this comes from, but I would guess libmythtv.

> These lists are not the same, and at present I don't know where they
> come from.  The first list doesn't include the new item.  Any help
> appreciated.

I've had merging the two on my list for a long time, but its never
gotten near the top of the list.

David

_______________________________________________
mythtv-users mailing list
mythtv-users@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-users
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On 04/06/2023 15:59, David Hampton via mythtv-users wrote:
> On Sun, 2023-06-04 at 13:44 +0100, John Pilkington wrote:
>> There's a current pull request (#44) seeking to add a new audio
>> visualizer.  I have a build that works, but not by all routes.
>>
>> Lists of visualizers are available at
>>
>> Frontend setup > Video > Playback OSD > Visualiser for audio only...\
>
> IIRC this comes from mythtv/libs/libmythtv/visualisations/*
>
>> and also at
>>
>> Listen to Music > play > Menu > More Options > Change visualiser
>
>
> This comes from mythplugins/mythmusic/mythmusic/visualizations.cpp
>
>> and similarly at
>>
>> Play radio stream
>
>
> I'm not sure where this comes from, but I would guess libmythtv.
>
>> These lists are not the same, and at present I don't know where they
>> come from.  The first list doesn't include the new item.  Any help
>> appreciated.
>
> I've had merging the two on my list for a long time, but its never
> gotten near the top of the list.
>
> David

Thanks for the reply. I've put a link in the PR. I don't think the
query ought to stop consideration of the PR, but I've been gnawing away
at the apparent inconsistency and something else turned up:

https://github.com/MythTV/mythtv/blob/master/mythplugins/mythmusic/theme/menus/musicmenu.xml

Line 52: <!-- Keep this in synch with
mythtv/themes/defaultmenu/media_settings.xml -->

...but that section has an additional <depends>mytharchive</depends>

https://github.com/MythTV/mythtv/blob/master/mythtv/themes/defaultmenu/media_settings.xml

I've changed it on my system, with no noticeable effect. :-)

The files as installed (built from Gary's script) are

/usr/share/mythtv/musicmenu.xml

/usr/share/mythtv/themes/defaultmenu/media_settings.xml

It might be good to have a similar warning with that file too.

Cheers, John





_______________________________________________
mythtv-users mailing list
mythtv-users@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-users
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org