Mailing List Archive: tmdb3 python bindings: how best to report bugs

tmdb3 python bindings: how best to report bugs

May 4, 2021, 11:04 PM

Post #1 of 4 (403 views)

Hi,
I think I've found a bug in the latest MythTV tmdb3 python bindings (fixes/31).

https://github.com/MythTV/mythtv/blob/b2ed400037de11c7e5546381e60cc9de7b1e15eb/mythtv/bindings/python/tmdb3/tmdb3/lookup.py#L138
MythTV/tmdb3/lookup.py, line 138:
if loc_posters[0].language != locale_language \
and locale_language != system_language:

I guess the fix would be to change MythTV/tmdb3/lookup.py, line 138 to:

if len(loc_posters) and loc_posters[0].language != locale_language \
and locale_language != system_language:

To repeat the issue I can run the following:

# /usr/bin/python3 /usr/share/mythtv/metadata/Movie/tmdb3.py -l en -a AU -D 323614
Traceback (most recent call last):
File "/usr/share/mythtv/metadata/Movie/tmdb3.py", line 150, in <module>
sys.exit(main("movie",'tmdb3.py'))
File "/usr/share/mythtv/metadata/Movie/tmdb3.py", line 127, in main
xml = buildSingle(args[0], opts)
File "/usr/lib/python3/dist-packages/MythTV/tmdb3/lookup.py", line 138, in buildSingle
if loc_posters[0].language != locale_language \
IndexError: list index out of range

This finds the related documentary but it has no associated movie.posters and this causes loc_posters to be assigned an empty list leading to the IndexError.

I wasn't sure how best to report this, the mythtv.org site links to code.mythtv.org/trac while github has its own issues page https://github.com/MythTV/mythtv/issues.

I was just wondering how best to make developers aware of the problem and my suggested fix?

Cheers,

Doug
--
"The big print giveth and the small print taketh away."

_______________________________________________
mythtv-users mailing list
mythtv-users@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-users
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

Re: tmdb3 python bindings: how best to report bugs [ In reply to ]

pb.mythtv at gmail

May 5, 2021, 6:07 AM

Post #2 of 4 (402 views)

Permalink

On 5/5/21 2:04 AM, Doug Scoular (dscoular) via mythtv-users wrote:
> Hi,
> I think I've found a bug in the latest MythTV tmdb3 python bindings (fixes/31).
>
> https://github.com/MythTV/mythtv/blob/b2ed400037de11c7e5546381e60cc9de7b1e15eb/mythtv/bindings/python/tmdb3/tmdb3/lookup.py#L138
> MythTV/tmdb3/lookup.py, line 138:
> if loc_posters[0].language != locale_language \
> and locale_language != system_language:
>
> I guess the fix would be to change MythTV/tmdb3/lookup.py, line 138 to:
>
> if len(loc_posters) and loc_posters[0].language != locale_language \
> and locale_language != system_language:
>
> To repeat the issue I can run the following:
>
> # /usr/bin/python3 /usr/share/mythtv/metadata/Movie/tmdb3.py -l en -a AU -D 323614
> Traceback (most recent call last):
> File "/usr/share/mythtv/metadata/Movie/tmdb3.py", line 150, in <module>
> sys.exit(main("movie",'tmdb3.py'))
> File "/usr/share/mythtv/metadata/Movie/tmdb3.py", line 127, in main
> xml = buildSingle(args[0], opts)
> File "/usr/lib/python3/dist-packages/MythTV/tmdb3/lookup.py", line 138, in buildSingle
> if loc_posters[0].language != locale_language \
> IndexError: list index out of range
>
> This finds the related documentary but it has no associated movie.posters and this causes loc_posters to be assigned an empty list leading to the IndexError.
>
> I wasn't sure how best to report this, the mythtv.org site links to code.mythtv.org/trac while github has its own issues page https://github.com/MythTV/mythtv/issues.
>
> I was just wondering how best to make developers aware of the problem and my suggested fix?
>
> Cheers,
>
> Doug
> --
> "The big print giveth and the small print taketh away."
>
>
The github issues page is the correct place now. We are no longer using
trac for new issues.
_______________________________________________
mythtv-users mailing list
mythtv-users@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-users
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

Re: tmdb3 python bindings: how best to report bugs [ In reply to ]

mythtv at mythqml

May 5, 2021, 6:31 AM

Post #3 of 4 (402 views)

Permalink

On 05/05/2021 14:07, Peter Bennett wrote:

>
> On 5/5/21 2:04 AM, Doug Scoular (dscoular) via mythtv-users wrote:
>> Hi, If you don't have a g
>> https://github.com/MythTV/mythtv/blob/b2ed400037de11c7e5546381e60cc9de7b1e15eb/mythtv/bindings/python/tmdb3/tmdb3/lookup.py#L138
>>
>> MythTV/tmdb3/lookup.py, line 138:
>>      if loc_posters[0].language != locale_language \
>>                      and locale_language != system_language:
>>
>>     I guess the fix would be to change MythTV/tmdb3/lookup.py, line
>> 138 to:
>>
>>      if len(loc_posters) and loc_posters[0].language !=
>> locale_language \
>>                      and locale_language != system_language:
>>
>>     To repeat the issue I can run the following:
>>
>> # /usr/bin/python3 /usr/share/mythtv/metadata/Movie/tmdb3.py -l en -a
>> AU -D 323614
>> Traceback (most recent call last):
>>    File "/usr/share/mythtv/metadata/Movie/tmdb3.py", line 150, in
>> <module>
>>      sys.exit(main("movie",'tmdb3.py'))
>>    File "/usr/share/mythtv/metadata/Movie/tmdb3.py", line 127, in main
>>      xml = buildSingle(args[0], opts)
>>    File "/usr/lib/python3/dist-packages/MythTV/tmdb3/lookup.py", line
>> 138, in buildSingle
>>      if loc_posters[0].language != locale_language \
>> IndexError: list index out of range
>>
>>     This finds the related documentary but it has no associated
>> movie.posters and this causes loc_posters to be assigned an empty
>> list leading to the IndexError.
>>
>>     I wasn't sure how best to report this, the mythtv.org site links
>> to code.mythtv.org/trac while github has its own issues page
>> https://github.com/MythTV/mythtv/issues.
>>
>>     I was just wondering how best to make developers aware of the
>> problem and my suggested fix?
>>
>> Cheers,
>> Doug
>> --
>> "The big print giveth and the small print taketh away."
>>
>>
> The github issues page is the correct place now. We are no longer
> using trac for new issues.
>

While that is always the preferred method we do understand not everyone
has or wants a github login, especially now it's owned by MicroSoft ! :)
) You can always drop a message to the mythtv-dev mailing list as most
devs do still keep track of that list since it's fairly on topic and low
traffic.

Paul H.

_______________________________________________
mythtv-users mailing list
mythtv-users@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-users
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

Re: tmdb3 python bindings: how best to report bugs [ In reply to ]

pb.mythtv at gmail

May 6, 2021, 8:25 AM

Post #4 of 4 (401 views)

Permalink

On 5/5/21 9:31 AM, Paul Harrison wrote:
> On 05/05/2021 14:07, Peter Bennett wrote:
>
>>
>> On 5/5/21 2:04 AM, Doug Scoular (dscoular) via mythtv-users wrote:
>>> Hi, If you don't have a g
>>> https://github.com/MythTV/mythtv/blob/b2ed400037de11c7e5546381e60cc9de7b1e15eb/mythtv/bindings/python/tmdb3/tmdb3/lookup.py#L138
>>>
>>> MythTV/tmdb3/lookup.py, line 138:
>>>      if loc_posters[0].language != locale_language \
>>>                      and locale_language != system_language:
>>>
>>>     I guess the fix would be to change MythTV/tmdb3/lookup.py, line
>>> 138 to:
>>>
>>>      if len(loc_posters) and loc_posters[0].language !=
>>> locale_language \
>>>                      and locale_language != system_language:
>>>
>>>     To repeat the issue I can run the following:
>>>
>>> # /usr/bin/python3 /usr/share/mythtv/metadata/Movie/tmdb3.py -l en
>>> -a AU -D 323614
>>> Traceback (most recent call last):
>>>    File "/usr/share/mythtv/metadata/Movie/tmdb3.py", line 150, in
>>> <module>
>>>      sys.exit(main("movie",'tmdb3.py'))
>>>    File "/usr/share/mythtv/metadata/Movie/tmdb3.py", line 127, in main
>>>      xml = buildSingle(args[0], opts)
>>>    File "/usr/lib/python3/dist-packages/MythTV/tmdb3/lookup.py",
>>> line 138, in buildSingle
>>>      if loc_posters[0].language != locale_language \
>>> IndexError: list index out of range
>>>
>>>     This finds the related documentary but it has no associated
>>> movie.posters and this causes loc_posters to be assigned an empty
>>> list leading to the IndexError.
>>>
>>>     I wasn't sure how best to report this, the mythtv.org site links
>>> to code.mythtv.org/trac while github has its own issues page
>>> https://github.com/MythTV/mythtv/issues.
>>>
>>>     I was just wondering how best to make developers aware of the
>>> problem and my suggested fix?
>>>
>>> Cheers,
>>> Doug
>>> --
>>> "The big print giveth and the small print taketh away."
>>>
>>>
>> The github issues page is the correct place now. We are no longer
>> using trac for new issues.
>>
>
> While that is always the preferred method we do understand not
> everyone has or wants a github login, especially now it's owned by
> MicroSoft ! :) ) You can always drop a message to the mythtv-dev
> mailing list as most devs do still keep track of that list since it's
> fairly on topic and low traffic.
>
>
> Paul H.
>
>
> _______________________________________________
>
No need to report this bug any further - I have made the fix and
committed it to master and fixes/31

Peter

_______________________________________________
mythtv-users mailing list
mythtv-users@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-users
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org