Mailing List Archive

mythtv branch master updated by dhampton. v30-Pre-412-g904422b
The branch, master has been updated on the
mythtv repository by gitolite user dhampton.
via 904422b799a487c31b6c11dbf5113923ac711e25 (commit)
via 93622e6afdbf56f5254b928e7ee859a2ae5ed575 (commit)
via d88976d2ae6b699d1b25ebf0566c796ff503a02f (commit)
via bd1f378c17255b1cd575a9d702aeb0ecf833e698 (commit)
via 8582a558173914c5c26b0f83546e10677eeeec2e (commit)
via fd101d57cb5efad2bad646a93c166909034d76c8 (commit)
via ca26a3764ca6a8922ab100ed6b9d43b6923ed558 (commit)
via 4d499665c48bd8eb34e2a5cbc49599f9d7552939 (commit)
via 5192581cc8bce44d84e75dee266af08d19253d11 (commit)
from 50b4e2cb04615120bb7d726c6d3084384e8ded11 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 904422b799a487c31b6c11dbf5113923ac711e25
Author: David Hampton <mythtv@love2code.net> at Tue, 23 Jan 2018 00:38:26 -0500
Committer: David Hampton <mythtv@love2code.net> at Tue, 23 Jan 2018 00:51:48 -0500
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=904422b799a487c31b6c11dbf5113923ac711e25

Fix cppcheck "constructor with 1 argument that isn't explicit" warnings.
Fix this set of constructor warnings for the classes in the file
dtvconfparserhelpers.h. Mark the constructors as explicit, and
tighten up the parameters by requiring that the argument be a class
specific enum instead of a generic integer. These enums are all
copies of enums from a system header files, so explicitly link them to
the system header enums. This patch also adds 'operator=' functions
to the classes for both the class enum and the system header enum,
since both are used interchangeably in the code. Add a couple of
explicit conversions to DTVTunerType where needed.



commit 93622e6afdbf56f5254b928e7ee859a2ae5ed575
Author: David Hampton <mythtv@love2code.net> at Thu, 18 Jan 2018 23:29:58 -0500
Committer: David Hampton <mythtv@love2code.net> at Tue, 23 Jan 2018 00:51:48 -0500
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=93622e6afdbf56f5254b928e7ee859a2ae5ed575

Fix cppcheck warning about a condition always being true.



commit d88976d2ae6b699d1b25ebf0566c796ff503a02f
Author: David Hampton <mythtv@love2code.net> at Thu, 18 Jan 2018 23:20:11 -0500
Committer: David Hampton <mythtv@love2code.net> at Tue, 23 Jan 2018 00:51:48 -0500
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=d88976d2ae6b699d1b25ebf0566c796ff503a02f

Fix cppcheck warning about unclear operator precedence.
The warning was that the precedence for '&' and '?' was unclear. The
intent of the code looks unambiguous, but adding parentheses to make
it explicit eliminates the cppcheck warning.



commit bd1f378c17255b1cd575a9d702aeb0ecf833e698
Author: David Hampton <mythtv@love2code.net> at Thu, 18 Jan 2018 23:17:48 -0500
Committer: David Hampton <mythtv@love2code.net> at Tue, 23 Jan 2018 00:51:47 -0500
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=bd1f378c17255b1cd575a9d702aeb0ecf833e698

Fix cppcheck warning about common realloc mistake.
Cppcheck flagged that the memory for the 'first' variable is no freed
and is lost if the realloc fails. Rewrite the code to handle a
possible failure and clean up.



commit 8582a558173914c5c26b0f83546e10677eeeec2e
Author: David Hampton <mythtv@love2code.net> at Thu, 18 Jan 2018 20:49:28 -0500
Committer: David Hampton <mythtv@love2code.net> at Tue, 23 Jan 2018 00:51:47 -0500
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=8582a558173914c5c26b0f83546e10677eeeec2e

Fix cppcheck complaint about unbounded sscanf() string reads.
Add the same string length limiter used in other sscanf() string reads
in that file.



commit fd101d57cb5efad2bad646a93c166909034d76c8
Author: David Hampton <mythtv@love2code.net> at Thu, 18 Jan 2018 20:39:53 -0500
Committer: David Hampton <mythtv@love2code.net> at Tue, 23 Jan 2018 00:51:47 -0500
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=fd101d57cb5efad2bad646a93c166909034d76c8

Fix simple cppcheck signedness complaints.
These complaints are fixed by changing the format string 'd/u' to
matched the signedness of the variable being used.



commit ca26a3764ca6a8922ab100ed6b9d43b6923ed558
Author: David Hampton <mythtv@love2code.net> at Thu, 18 Jan 2018 20:34:25 -0500
Committer: David Hampton <mythtv@love2code.net> at Tue, 23 Jan 2018 00:51:47 -0500
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=ca26a3764ca6a8922ab100ed6b9d43b6923ed558

Fix cppcheck signedness complaint in HistogramAnalyzer.cpp.
Cppcheck complained that a variable being read with a '%2x' format
needed to be unsigned instead of signed. This patch changes the array
used for reading to be unsigned instead of signed, and also removes
the test for less than zero (since that can't happen with an unsigned
variable.) This code is being used to read an array of uchar values
(0-255) printed earlier, so there should be no problem with this
change.



commit 4d499665c48bd8eb34e2a5cbc49599f9d7552939
Author: David Hampton <mythtv@love2code.net> at Wed, 17 Jan 2018 20:28:22 -0500
Committer: David Hampton <mythtv@love2code.net> at Tue, 23 Jan 2018 00:51:47 -0500
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=4d499665c48bd8eb34e2a5cbc49599f9d7552939

Flag the RecordingInfo from ProgramInfo constructor as explicit.
This pointed out a number of places where the code was calling a
function and passing a ProgramInfo structure when the function
expected a RecordingInfo structure expected. Instead of changing the
callers, it seemed simpler to overload the functions being called and
convert in the called functions. This constructor was pointed out by
cppcheck.



commit 5192581cc8bce44d84e75dee266af08d19253d11
Author: David Hampton <mythtv@love2code.net> at Wed, 17 Jan 2018 19:52:30 -0500
Committer: David Hampton <mythtv@love2code.net> at Tue, 23 Jan 2018 00:51:47 -0500
URL: http://code.mythtv.org/cgit/mythtv/commit/?id=5192581cc8bce44d84e75dee266af08d19253d11

Flag some single parameter constructors as explicit.
These functions were pointed out by cppcheck.



-----------------------------------------------------------------------

Summary of changes:
mythtv/filters/ivtc/pullup.c | 5 +-
mythtv/libs/libmyth/audio/audiooutputalsa.h | 2 +-
.../test/test_videometadata/test_videometadata.h | 2 +-
.../libs/libmythtv/channelscan/channelimporter.cpp | 4 +-
.../libs/libmythtv/channelscan/channelscan_sm.cpp | 7 +-
mythtv/libs/libmythtv/channelscan/channelscan_sm.h | 1 +
mythtv/libs/libmythtv/dtvconfparser.cpp | 2 +-
mythtv/libs/libmythtv/dtvconfparser.h | 2 +-
mythtv/libs/libmythtv/dtvconfparserhelpers.h | 101 ++++++++++++++------
mythtv/libs/libmythtv/frequencytables.cpp | 2 +-
mythtv/libs/libmythtv/frequencytables.h | 24 +++---
mythtv/libs/libmythtv/mythcommflagplayer.h | 2 +-
mythtv/libs/libmythtv/mythplayer.h | 2 +-
mythtv/libs/libmythtv/osdchromakey.h | 2 +-
.../libs/libmythtv/recorders/NuppelVideoRecorder.h | 4 +-
.../libs/libmythtv/recorders/hdhrstreamhandler.cpp | 10 +-
mythtv/libs/libmythtv/recordinginfo.h | 4 +-
mythtv/libs/libmythtv/scanwizard.cpp | 2 +-
mythtv/libs/libmythtv/scheduledrecording.h | 4 +
mythtv/libs/libmythtv/tv_play.cpp | 2 +-
mythtv/libs/libmythtv/tvbrowsehelper.h | 2 +-
mythtv/libs/libmythtv/vaapicontext.cpp | 2 +-
mythtv/libs/libmythtv/videoout_opengl.h | 2 +-
mythtv/libs/libmythtv/xine_demux_sputext.cpp | 29 ++++---
mythtv/programs/mythbackend/scheduler.h | 2 +
mythtv/programs/mythcommflag/HistogramAnalyzer.cpp | 4 +-
mythtv/programs/mythfrontend/globalsettings.h | 6 +-
mythtv/programs/mythfrontend/playbackbox.cpp | 4 +-
.../serviceHosts/frontendServiceHost.h | 2 +-
mythtv/programs/mythfrontend/setupwizard_audio.cpp | 2 +-
.../programs/mythfrontend/setupwizard_general.cpp | 2 +-
mythtv/programs/mythfrontend/setupwizard_video.cpp | 2 +-
mythtv/programs/mythtranscode/mpeg2fix.cpp | 2 +-
33 files changed, 152 insertions(+), 93 deletions(-)

--

_______________________________________________
mythtv-firehose mailing list
mythtv-firehose@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-firehose