Mailing List Archive

On Sat, 2023-01-21 at 21:52 +0000, Gary Buhrmaster wrote:
> With recent master, make & install will add a Version.pm
> to the perl high level install directory  This is (almost certainly)
> an error as that space is shared, and should have
> application specific pm files, and directories (MythTV.pm
> and a MythTV directory are currently created, and
> now Version.pm?).
>
> I have not tried to bisect, but my guess is that 04faba0e
> is a likely culprit.

It is. 

Converting the entire 888 line MythTV.pm file into a pre-processed file
just to be able to change a single value seemed overkill, so I opted
for a new file. I didn't realize that it would end up installed at the
top level. I will see if MakeMaker will allow me to extract that value
from a file in a subdirectory.

If any perl wizards are reading this, I'd love to hear any ideas you
have.

David



_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Sat, 2023-01-21 at 17:38 -0500, David Hampton wrote:
> On Sat, 2023-01-21 at 21:52 +0000, Gary Buhrmaster wrote:
> > With recent master, make & install will add a Version.pm
> > to the perl high level install directory  This is (almost
> > certainly)
> > an error as that space is shared, and should have
> > application specific pm files, and directories (MythTV.pm
> > and a MythTV directory are currently created, and
> > now Version.pm?).
> >
> > I have not tried to bisect, but my guess is that 04faba0e
> > is a likely culprit.
>
> It is. 
>
> Converting the entire 888 line MythTV.pm file into a pre-processed
> file
> just to be able to change a single value seemed overkill, so I opted
> for a new file.  I didn't realize that it would end up installed at
> the
> top level.  I will see if MakeMaker will allow me to extract that
> value
> from a file in a subdirectory.
>
> If any perl wizards are reading this, I'd love to hear any ideas you
> have.

I moved Version.pm to MythTV/Version.pm which should fix the issue.
That new file will need to be packaged.

David


_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Sat, Jan 21, 2023 at 10:38 PM David Hampton via mythtv-dev
<mythtv-dev@mythtv.org> wrote:

> If any perl wizards are reading this, I'd love to hear any ideas you
> have.


Well, I am not a perl makemaker expert, but if
I understand what you are trying to accomplish
(and I did not actually test this as a build/install),
you can try the following diff which seems to be
a much easier approach.



diff --git a/mythtv/bindings/perl/Makefile b/mythtv/bindings/perl/Makefile
index c7ded786a0..0497a4d9d0 100644
--- a/mythtv/bindings/perl/Makefile
+++ b/mythtv/bindings/perl/Makefile
@@ -10,6 +10,12 @@ ifneq ($(PREFIX:/=), /usr)
endif
endif

+ifndef MYTHTV_VERSION_MAJMIN
+ MYTHTV_VERSION_MAJMIN=0.1
+endif
+
+export MYTHTV_VERSION_MAJMIN
+
all: perl_build

clean:
diff --git a/mythtv/bindings/perl/Makefile.PL b/mythtv/bindings/perl/Makefile.PL
index cd69830b67..05b8c5f80e 100644
--- a/mythtv/bindings/perl/Makefile.PL
+++ b/mythtv/bindings/perl/Makefile.PL
@@ -12,7 +12,7 @@ use ExtUtils::MakeMaker;

WriteMakefile(
'NAME' => 'MythTV',
- 'VERSION_FROM' => 'Version.pm',
+ 'VERSION' => "$ENV{'MYTHTV_VERSION_MAJMIN'}",
'AUTHOR' => 'Chris Petersen <mythtv@forevermore.net>',
'PREREQ_PM' => {'Exporter' => 0,
'Config' => 0,
diff --git a/mythtv/bindings/perl/Version.pm.in
b/mythtv/bindings/perl/Version.pm.in
deleted file mode 100644
index 72656e85f8..0000000000
--- a/mythtv/bindings/perl/Version.pm.in
+++ /dev/null
@@ -1,2 +0,0 @@
-# Version
- $VERSION = '@MYTHTV_VERSION_MAJMIN@';
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Sun, Jan 22, 2023 at 9:09 PM Gary Buhrmaster
<gary.buhrmaster@gmail.com> wrote:
>
> On Sat, Jan 21, 2023 at 10:38 PM David Hampton via mythtv-dev
> <mythtv-dev@mythtv.org> wrote:
>
> > If any perl wizards are reading this, I'd love to hear any ideas you
> > have.
>
>
> Well, I am not a perl makemaker expert, but if
> I understand what you are trying to accomplish
> (and I did not actually test this as a build/install),
> you can try the following diff which seems to be
> a much easier approach.

Well, it looks like while I wrote the email you
took a different approach. I still think using
the environmental variables available is an
easier approach, but whatever works best
for you.

Thanks.
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Sun, Jan 22, 2023 at 7:20 PM David Hampton via mythtv-dev
<mythtv-dev@mythtv.org> wrote:

> I moved Version.pm to MythTV/Version.pm which should fix the issue.
> That new file will need to be packaged.

btw, my fix eliminates the need for an (essentially)
useless additional file.
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Mon, 2023-01-23 at 15:25 +0000, Gary Buhrmaster wrote:
> On Sun, Jan 22, 2023 at 7:20 PM David Hampton via mythtv-dev
> <mythtv-dev@mythtv.org> wrote:
>
> > I moved Version.pm to MythTV/Version.pm which should fix the issue.
> > That new file will need to be packaged.
>
> btw, my fix eliminates the need for an (essentially)
> useless additional file.

True, but this method makes it easier to port the change to cmake.
Cmake has a configure_file function specifically designed to do this
kind of substitution.

David

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Mon, Jan 23, 2023 at 3:35 PM David Hampton via mythtv-dev
<mythtv-dev@mythtv.org> wrote:

> True, but this method makes it easier to port the change to cmake.

The goal of cmake is good.

> Cmake has a configure_file function specifically designed to do this
> kind of substitution.

So why not use it to configure the Makefile.PL "Version"
string directly? As my patch demonstrated, one does not
have to pull the version from a file, it can be directly
specified.
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On 23/01/2023 16:15, Gary Buhrmaster wrote:
> On Mon, Jan 23, 2023 at 3:35 PM David Hampton via mythtv-dev
> <mythtv-dev@mythtv.org> wrote:
>
>> True, but this method makes it easier to port the change to cmake.
>
> The goal of cmake is good.
>
>> Cmake has a configure_file function specifically designed to do this
>> kind of substitution.
>
> So why not use it to configure the Makefile.PL "Version"
> string directly? As my patch demonstrated, one does not
> have to pull the version from a file, it can be directly
> specified.

FWIW (??), and fyi, the error I reported on the users list was

Checking for unpackaged file(s): /usr/lib/rpm/check-files
/builddir/build/BUILDROOT/mythtv-33.Pre.1075.gb6428abd82-100.fc36.x86_64
error: Installed (but unpackaged) file(s) found:
/usr/share/perl5/vendor_perl/Version.pm

followed by a short list of files listed twice.

-------
Today, after replacing all instances of MythTV.pm in mythtv.spec by

/MythTV/Version.pm

I get

Checking for unpackaged file(s): /usr/lib/rpm/check-files
/builddir/build/BUILDROOT/mythtv-33.Pre.1109.g6f04854c27-100.fc36.x86_64
error: Installed (but unpackaged) file(s) found:
/usr/share/perl5/vendor_perl/IO/Socket/INET/MythTV.pm
/usr/share/perl5/vendor_perl/MythTV.pm

John


_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Mon, 2023-01-23 at 16:15 +0000, Gary Buhrmaster wrote:
> On Mon, Jan 23, 2023 at 3:35 PM David Hampton via mythtv-dev
> <mythtv-dev@mythtv.org> wrote:
>
> > True, but this method makes it easier to port the change to cmake.
>
> The goal of cmake is good.
>
> > Cmake has a configure_file function specifically designed to do
> > this
> > kind of substitution.
>
> So why not use it to configure the Makefile.PL "Version"
> string directly?  As my patch demonstrated, one does not
> have to pull the version from a file, it can be directly
> specified.

I like the idea, but the value is also available as MythTV::VERSION,
however you would write that in perl. I ended up with this as my test
case:

#! /usr/bin/perl
use MythTV;
print STDOUT "$VERSION\n";

David

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Mon, 2023-01-23 at 16:51 +0000, John Pilkington wrote:
> On 23/01/2023 16:15, Gary Buhrmaster wrote:
> > On Mon, Jan 23, 2023 at 3:35 PM David Hampton via mythtv-dev
> > <mythtv-dev@mythtv.org> wrote:
> >
> > > True, but this method makes it easier to port the change to
> > > cmake.
> >
> > The goal of cmake is good.
> >
> > > Cmake has a configure_file function specifically designed to do
> > > this
> > > kind of substitution.
> >
> > So why not use it to configure the Makefile.PL "Version"
> > string directly?  As my patch demonstrated, one does not
> > have to pull the version from a file, it can be directly
> > specified.
>
> FWIW (??), and fyi, the error I reported on the users list was
>
> Checking for unpackaged file(s): /usr/lib/rpm/check-files
> /builddir/build/BUILDROOT/mythtv-33.Pre.1075.gb6428abd82-
> 100.fc36.x86_64
> error: Installed (but unpackaged) file(s) found:
>     /usr/share/perl5/vendor_perl/Version.pm
>
> followed by a short list of files listed twice.
>
> -------
> Today, after replacing all instances of MythTV.pm in mythtv.spec by
>
>   /MythTV/Version.pm
>
> I get
>
> Checking for unpackaged file(s): /usr/lib/rpm/check-files
> /builddir/build/BUILDROOT/mythtv-33.Pre.1109.g6f04854c27-
> 100.fc36.x86_64
> error: Installed (but unpackaged) file(s) found:
>     /usr/share/perl5/vendor_perl/IO/Socket/INET/MythTV.pm
>     /usr/share/perl5/vendor_perl/MythTV.pm

That's odd. I just compared my fixes-32 and master install
directories, and these are the only things I see changed:

Files fixes-32/share/perl5/5.36/MythTV/Program.pm and
master/share/perl5/5.36/MythTV/Program.pm differ
Only in master/share/perl5/5.36/MythTV: Version.pm
Files fixes-32/share/perl5/5.36/MythTV.pm and
master/share/perl5/5.36/MythTV.pm differ
Files fixes-32/lib64/perl5/5.36/auto/MythTV/.packlist and
master/lib64/perl5/5.36/auto/MythTV/.packlist differ

This is on my Fedora 37 development system. How are you building
packages? Are you using Gary's scripts?

David


_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On 23/01/2023 18:05, David Hampton via mythtv-dev wrote:
> On Mon, 2023-01-23 at 16:51 +0000, John Pilkington wrote:
>> On 23/01/2023 16:15, Gary Buhrmaster wrote:
>>> On Mon, Jan 23, 2023 at 3:35 PM David Hampton via mythtv-dev
>>> <mythtv-dev@mythtv.org> wrote:
>>>
>>>> True, but this method makes it easier to port the change to
>>>> cmake.
>>>
>>> The goal of cmake is good.
>>>
>>>> Cmake has a configure_file function specifically designed to do
>>>> this
>>>> kind of substitution.
>>>
>>> So why not use it to configure the Makefile.PL "Version"
>>> string directly?  As my patch demonstrated, one does not
>>> have to pull the version from a file, it can be directly
>>> specified.
>>
>> FWIW (??), and fyi, the error I reported on the users list was
>>
>> Checking for unpackaged file(s): /usr/lib/rpm/check-files
>> /builddir/build/BUILDROOT/mythtv-33.Pre.1075.gb6428abd82-
>> 100.fc36.x86_64
>> error: Installed (but unpackaged) file(s) found:
>>     /usr/share/perl5/vendor_perl/Version.pm
>>
>> followed by a short list of files listed twice.
>>
>> -------
>> Today, after replacing all instances of MythTV.pm in mythtv.spec by
>>
>>   /MythTV/Version.pm
>>
>> I get
>>
>> Checking for unpackaged file(s): /usr/lib/rpm/check-files
>> /builddir/build/BUILDROOT/mythtv-33.Pre.1109.g6f04854c27-
>> 100.fc36.x86_64
>> error: Installed (but unpackaged) file(s) found:
>>     /usr/share/perl5/vendor_perl/IO/Socket/INET/MythTV.pm
>>     /usr/share/perl5/vendor_perl/MythTV.pm
>
> That's odd. I just compared my fixes-32 and master install
> directories, and these are the only things I see changed:
>
> Files fixes-32/share/perl5/5.36/MythTV/Program.pm and
> master/share/perl5/5.36/MythTV/Program.pm differ
> Only in master/share/perl5/5.36/MythTV: Version.pm
> Files fixes-32/share/perl5/5.36/MythTV.pm and
> master/share/perl5/5.36/MythTV.pm differ
> Files fixes-32/lib64/perl5/5.36/auto/MythTV/.packlist and
> master/lib64/perl5/5.36/auto/MythTV/.packlist differ
>
> This is on my Fedora 37 development system. How are you building
> packages? Are you using Gary's scripts?

Yes. IIRC the only changes now are those I mentioned in the specfile
and using a locally updated clone instead of cloning directly from the
remote for every build.
>
> David
>
>
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev@mythtv.org
> http://lists.mythtv.org/mailman/listinfo/mythtv-dev
> http://wiki.mythtv.org/Mailing_List_etiquette
> MythTV Forums: https://forum.mythtv.org

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Mon, 2023-01-23 at 18:23 +0000, John Pilkington wrote:
> On 23/01/2023 18:05, David Hampton via mythtv-dev wrote:
> > On Mon, 2023-01-23 at 16:51 +0000, John Pilkington wrote:
> > > On 23/01/2023 16:15, Gary Buhrmaster wrote:
> > > > On Mon, Jan 23, 2023 at 3:35 PM David Hampton via mythtv-dev
> > > > <mythtv-dev@mythtv.org> wrote:
> > > >
> > > > > True, but this method makes it easier to port the change to
> > > > > cmake.
> > > >
> > > > The goal of cmake is good.
> > > >
> > > > > Cmake has a configure_file function specifically designed to
> > > > > do
> > > > > this
> > > > > kind of substitution.
> > > >
> > > > So why not use it to configure the Makefile.PL "Version"
> > > > string directly?  As my patch demonstrated, one does not
> > > > have to pull the version from a file, it can be directly
> > > > specified.
> > >
> > > FWIW (??), and fyi, the error I reported on the users list was
> > >
> > > Checking for unpackaged file(s): /usr/lib/rpm/check-files
> > > /builddir/build/BUILDROOT/mythtv-33.Pre.1075.gb6428abd82-
> > > 100.fc36.x86_64
> > > error: Installed (but unpackaged) file(s) found:
> > >      /usr/share/perl5/vendor_perl/Version.pm
> > >
> > > followed by a short list of files listed twice.
> > >
> > > -------
> > > Today, after replacing all instances of MythTV.pm in mythtv.spec
> > > by
> > >
> > >    /MythTV/Version.pm
> > >
> > > I get
> > >
> > > Checking for unpackaged file(s): /usr/lib/rpm/check-files
> > > /builddir/build/BUILDROOT/mythtv-33.Pre.1109.g6f04854c27-
> > > 100.fc36.x86_64
> > > error: Installed (but unpackaged) file(s) found:
> > >      /usr/share/perl5/vendor_perl/IO/Socket/INET/MythTV.pm
> > >      /usr/share/perl5/vendor_perl/MythTV.pm
> >
> > That's odd.  I just compared my fixes-32 and master install
> > directories, and these are the only things I see changed:
> >
> >    Files fixes-32/share/perl5/5.36/MythTV/Program.pm and
> >      master/share/perl5/5.36/MythTV/Program.pm differ
> >    Only in master/share/perl5/5.36/MythTV: Version.pm
> >    Files fixes-32/share/perl5/5.36/MythTV.pm and
> >      master/share/perl5/5.36/MythTV.pm differ
> >    Files fixes-32/lib64/perl5/5.36/auto/MythTV/.packlist and
> >      master/lib64/perl5/5.36/auto/MythTV/.packlist differ
> >
> > This is on my Fedora 37 development system.  How are you building
> > packages?  Are you using Gary's scripts?
>
> Yes.  IIRC the only changes now are those I mentioned in the specfile
> and using a locally updated clone instead of cloning directly from
> the remote for every build.
>

OK. I just updated my copy of Gary's build scripts and am starting a
build. I'll see what I get here.

David

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Mon, Jan 23, 2023 at 4:52 PM John Pilkington <johnpilk222@gmail.com> wrote:

> Today, after replacing all instances of MythTV.pm in mythtv.spec by
>
> /MythTV/Version.pm

The nicest way I can put this is: "Don't do that".
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Mon, 2023-01-23 at 13:48 -0500, David Hampton wrote:
> On Mon, 2023-01-23 at 18:23 +0000, John Pilkington wrote:
> > On 23/01/2023 18:05, David Hampton via mythtv-dev wrote:
> > > On Mon, 2023-01-23 at 16:51 +0000, John Pilkington wrote:
> > > > On 23/01/2023 16:15, Gary Buhrmaster wrote:
> > > > > On Mon, Jan 23, 2023 at 3:35 PM David Hampton via mythtv-dev
> > > > > <mythtv-dev@mythtv.org> wrote:
> > > > >
> > > > > > True, but this method makes it easier to port the change to
> > > > > > cmake.
> > > > >
> > > > > The goal of cmake is good.
> > > > >
> > > > > > Cmake has a configure_file function specifically designed
> > > > > > to
> > > > > > do
> > > > > > this
> > > > > > kind of substitution.
> > > > >
> > > > > So why not use it to configure the Makefile.PL "Version"
> > > > > string directly?  As my patch demonstrated, one does not
> > > > > have to pull the version from a file, it can be directly
> > > > > specified.
> > > >
> > > > FWIW (??), and fyi, the error I reported on the users list was
> > > >
> > > > Checking for unpackaged file(s): /usr/lib/rpm/check-files
> > > > /builddir/build/BUILDROOT/mythtv-33.Pre.1075.gb6428abd82-
> > > > 100.fc36.x86_64
> > > > error: Installed (but unpackaged) file(s) found:
> > > >      /usr/share/perl5/vendor_perl/Version.pm
> > > >
> > > > followed by a short list of files listed twice.
> > > >
> > > > -------
> > > > Today, after replacing all instances of MythTV.pm in
> > > > mythtv.spec
> > > > by
> > > >
> > > >    /MythTV/Version.pm
> > > >
> > > > I get
> > > >
> > > > Checking for unpackaged file(s): /usr/lib/rpm/check-files
> > > > /builddir/build/BUILDROOT/mythtv-33.Pre.1109.g6f04854c27-
> > > > 100.fc36.x86_64
> > > > error: Installed (but unpackaged) file(s) found:
> > > >      /usr/share/perl5/vendor_perl/IO/Socket/INET/MythTV.pm
> > > >      /usr/share/perl5/vendor_perl/MythTV.pm
> > >
> > > That's odd.  I just compared my fixes-32 and master install
> > > directories, and these are the only things I see changed:
> > >
> > >    Files fixes-32/share/perl5/5.36/MythTV/Program.pm and
> > >      master/share/perl5/5.36/MythTV/Program.pm differ
> > >    Only in master/share/perl5/5.36/MythTV: Version.pm
> > >    Files fixes-32/share/perl5/5.36/MythTV.pm and
> > >      master/share/perl5/5.36/MythTV.pm differ
> > >    Files fixes-32/lib64/perl5/5.36/auto/MythTV/.packlist and
> > >      master/lib64/perl5/5.36/auto/MythTV/.packlist differ
> > >
> > > This is on my Fedora 37 development system.  How are you building
> > > packages?  Are you using Gary's scripts?
> >
> > Yes.  IIRC the only changes now are those I mentioned in the
> > specfile
> > and using a locally updated clone instead of cloning directly from
> > the remote for every build.
> >
>
> OK. I just updated my copy of Gary's build scripts and am starting a
> build.  I'll see what I get here.

The packages build for me, but then I get this error trying to install
them:

Problem 1: cannot install the best update candidate for package
perl-MythTV-33.Pre.935.ga2571e926c-100.fc37.noarch
- nothing provides perl(MythTV::Version) needed by
perl-MythTV-33.Pre.1114.g4505faf428-100.fc37.noarch

And four more errors with the same complaint about
perl(MythTV::Version).

The file /usr/share/perl5/vendor_perl/MythTV/Version.pm is in the rpm
according to the output of "rpm -ql", bit it doesn't show up in the
output of "rpm -q --provides".

David


_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Mon, Jan 23, 2023 at 9:25 PM David Hampton via mythtv-dev
<mythtv-dev@mythtv.org> wrote:

> The packages build for me, but then I get this error trying to install
> them:
>
> Problem 1: cannot install the best update candidate for package
> perl-MythTV-33.Pre.935.ga2571e926c-100.fc37.noarch
> - nothing provides perl(MythTV::Version) needed by
> perl-MythTV-33.Pre.1114.g4505faf428-100.fc37.noarch
>
> And four more errors with the same complaint about
> perl(MythTV::Version).
>
> The file /usr/share/perl5/vendor_perl/MythTV/Version.pm is in the rpm
> according to the output of "rpm -ql", bit it doesn't show up in the
> output of "rpm -q --provides".

My recollection is that rpm's perl file autogenerator
only generates the equivalent of a Provides: when
it sees lines of something of the form:

Package MythTV::Version ;

Conversely, the autogenerators only generates
a Require: when it sees lines of the form use or
require.

Explicit rpm packaging Provides: (and Requires:)
overrides can also be used in the spec file if
needed (and there are also ways to filter out
the autogenerated names) but the autogenerators
re preferred if possible in order to avoid "forgetting"
about the need for manual updates with future
changes.

When I have some time later[0] I'll test a fix
(if you don't get there first).


[0] Soon, or not until the weekend, are
the likely bounding times.
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Mon, 2023-01-23 at 23:08 +0000, Gary Buhrmaster wrote:
> On Mon, Jan 23, 2023 at 9:25 PM David Hampton via mythtv-dev
> <mythtv-dev@mythtv.org> wrote:
>
> > The packages build for me, but then I get this error trying to
> > install
> > them:
> >
> >     Problem 1: cannot install the best update candidate for package
> >       perl-MythTV-33.Pre.935.ga2571e926c-100.fc37.noarch
> >     - nothing provides perl(MythTV::Version) needed by
> >       perl-MythTV-33.Pre.1114.g4505faf428-100.fc37.noarch
> >
> > And four more errors with the same complaint about
> > perl(MythTV::Version).
> >
> > The file /usr/share/perl5/vendor_perl/MythTV/Version.pm is in the
> > rpm
> > according to the output of "rpm -ql", bit it doesn't show up in the
> > output of "rpm -q --provides".
>
> My recollection is that rpm's perl file autogenerator
> only generates the equivalent of a Provides: when
> it sees lines of something of the form:
>
>     Package  MythTV::Version ;
>
> Conversely, the autogenerators only generates
> a Require: when it sees lines of the form use or
> require.
>
> Explicit rpm packaging Provides: (and Requires:)
> overrides can also be used in the spec file if
> needed (and there are also ways to filter out
> the autogenerated names) but the autogenerators
> re preferred if possible in order to avoid "forgetting"
> about the need for manual updates with future
> changes.
>
> When I have some time later[0] I'll test a fix
> (if you don't get there first).

This should be fixed now. I was able to build rpms using your scripts
and install them on one of my production frontends.

David

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On 24/01/2023 14:27, David Hampton via mythtv-dev wrote:

>
> This should be fixed now. I was able to build rpms using your scripts
> and install them on one of my production frontends.
>
> David
>
Yes, me too. And the new WaveForm visualiser as well.

Thanks,

John


_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

On Tue, Jan 24, 2023 at 2:27 PM David Hampton via mythtv-dev
<mythtv-dev@mythtv.org> wrote:

> This should be fixed now. I was able to build rpms using your scripts
> and install them on one of my production frontends.

Thanks.

Note that my scripts are not the same as the
build(s) for Fedora available in RPMFusion[0]
(from where I suspect most of the Fedora
users who don't do their own builds of MythTV
get their packages), although in this case the
same issues would have likely eventually been
encountered (those build processes also use
the perl generators, which is considered the
recommended practice).




[0] My scripts and spec files have a slightly
different approach to MythTV packaging
than the RPMFusion ones.
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org