Advanced
Mailing List Archive

Mailing List Archive

  1. Home >
  2. MythTV>
  3. Dev
Call for testing devel/ffmpeg-resync (FFmpeg 5.1)
scott.the.elm at gmail
Sep 6, 2022, 11:46 AM
Post #1 of 13 (1009 views)
Permalink
Hello all,

I have merged FFmpeg 5.1 into our version and copied it into MythTV. 
Peter Bennett has pushed these commits from
https://github.com/MythTV/mythtv/pull/627 to devel/ffmpeg-resync and we
would appreciate further testing before it is merged to master.

The deprecated avcodec_encode_video2 has been removed.  I modeled the
replacement code on the audio version and would appreciate some testing
of transcoding to make sure my replacement works.  There is also a
similar change to NuppleVideoRecoder, but I don't know if anyone
actually still uses that.

FFmpeg has created a new channel layout API and deprecated the old one. 
This effects downmixing and I would appreciate confirmation that it
still works as expected on non-SSE2 platforms.

Those were the main things I wanted tested, but general testing would
also be appreciated.


Klaas,

Could you test the attached patch on top of devel/ffmpeg-resync to test
if https://trac.ffmpeg.org/ticket/9532 is still a bug? Apply the patch
in the mythtv/external/FFmpeg folder and test VDPAU decoding with your
sample.

Thanks,

Scott Theisen

Attached Files:

Re: Call for testing devel/ffmpeg-resync (FFmpeg 5.1) [ In reply to ]
klaas.de.waal at gmail
Sep 6, 2022, 1:31 PM
Post #2 of 13 (1009 views)
Permalink
On Tue, 6 Sept 2022 at 20:47, Scott Theisen <scott.the.elm@gmail.com> wrote:

> Hello all,
>
> I have merged FFmpeg 5.1 into our version and copied it into MythTV.
> Peter Bennett has pushed these commits from
> https://github.com/MythTV/mythtv/pull/627 to devel/ffmpeg-resync and we
> would appreciate further testing before it is merged to master.
>
> The deprecated avcodec_encode_video2 has been removed. I modeled the
> replacement code on the audio version and would appreciate some testing
> of transcoding to make sure my replacement works. There is also a
> similar change to NuppleVideoRecoder, but I don't know if anyone
> actually still uses that.
>
> FFmpeg has created a new channel layout API and deprecated the old one.
> This effects downmixing and I would appreciate confirmation that it
> still works as expected on non-SSE2 platforms.
>
> Those were the main things I wanted tested, but general testing would
> also be appreciated.
>
>
> Klaas,
>
> Could you test the attached patch on top of devel/ffmpeg-resync to test
> if https://trac.ffmpeg.org/ticket/9532 is still a bug? Apply the patch
> in the mythtv/external/FFmpeg folder and test VDPAU decoding with your
> sample.
>
> Thanks,
>
> Scott Theisen_______________________________________________
> mythtv-dev mailing list
> mythtv-dev@mythtv.org
> http://lists.mythtv.org/mailman/listinfo/mythtv-dev
> http://wiki.mythtv.org/Mailing_List_etiquette
> MythTV Forums: https://forum.mythtv.org


Scott,

There is also a request from the FFmpeg folks to check if the bug is still
present in the latest FFmpeg master.
However, I am currently and in the near future rather disconnected from my
MythTV systems so no testing for now.

Klaas.
Re: Call for testing devel/ffmpeg-resync (FFmpeg 5.1) [ In reply to ]
pb.mythtv at gmail
Sep 6, 2022, 2:46 PM
Post #3 of 13 (1008 views)
Permalink
On 9/6/22 14:46, Scott Theisen wrote:
> Hello all,
>
> I have merged FFmpeg 5.1 into our version and copied it into MythTV. 
> Peter Bennett has pushed these commits from
> https://github.com/MythTV/mythtv/pull/627 to devel/ffmpeg-resync and
> we would appreciate further testing before it is merged to master.
>
> The deprecated avcodec_encode_video2 has been removed.  I modeled the
> replacement code on the audio version and would appreciate some
> testing of transcoding to make sure my replacement works. There is
> also a similar change to NuppleVideoRecoder, but I don't know if
> anyone actually still uses that.
>
> FFmpeg has created a new channel layout API and deprecated the old
> one.  This effects downmixing and I would appreciate confirmation that
> it still works as expected on non-SSE2 platforms.
>
> Those were the main things I wanted tested, but general testing would
> also be appreciated.
>
>
> Klaas,
>
> Could you test the attached patch on top of devel/ffmpeg-resync to
> test if https://trac.ffmpeg.org/ticket/9532 is still a bug? Apply the
> patch in the mythtv/external/FFmpeg folder and test VDPAU decoding
> with your sample.
>
> Thanks,
>
> Scott Theisen
>
>
I still have that video on my test system. IIRC it used to pixellate in
various places in the video before Klaas's patch. Using VDPAU. with the
ffmpeg-resync version it plays perfectly. With the ffmpeg-resync version
and the revert patch it pixellates badly for 2-3 seconds at the start of
the video but not at any other place. So the problem may have partially
been fixed in ffmpeg.

Do you have a version of the revert patch for master so that I can apply
it there as a comparison for how it used to be?

Peter



_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org
Re: Call for testing devel/ffmpeg-resync (FFmpeg 5.1) [ In reply to ]
johnpilk222 at gmail
Sep 7, 2022, 3:05 AM
Post #4 of 13 (1006 views)
Permalink
On 06/09/2022 22:46, Peter Bennett wrote:
>
> On 9/6/22 14:46, Scott Theisen wrote:
>> Hello all,
>>
>> I have merged FFmpeg 5.1 into our version and copied it into MythTV.
>> Peter Bennett has pushed these commits from
>> https://github.com/MythTV/mythtv/pull/627 to devel/ffmpeg-resync and
>> we would appreciate further testing before it is merged to master.
>>
>> The deprecated avcodec_encode_video2 has been removed.  I modeled the
>> replacement code on the audio version and would appreciate some
>> testing of transcoding to make sure my replacement works. There is
>> also a similar change to NuppleVideoRecoder, but I don't know if
>> anyone actually still uses that.
>>
>> FFmpeg has created a new channel layout API and deprecated the old
>> one.  This effects downmixing and I would appreciate confirmation that
>> it still works as expected on non-SSE2 platforms.
>>
>> Those were the main things I wanted tested, but general testing would
>> also be appreciated.
>>
>>
>> Klaas,
>>
>> Could you test the attached patch on top of devel/ffmpeg-resync to
>> test if https://trac.ffmpeg.org/ticket/9532 is still a bug? Apply the
>> patch in the mythtv/external/FFmpeg folder and test VDPAU decoding
>> with your sample.
>>
>> Thanks,
>>
>> Scott Theisen
>>
>>
> I still have that video on my test system. IIRC it used to pixellate in
> various places in the video before Klaas's patch. Using VDPAU. with the
> ffmpeg-resync version it plays perfectly. With the ffmpeg-resync version
> and the revert patch it pixellates badly for 2-3 seconds at the start of
> the video but not at any other place. So the problem may have partially
> been fixed in ffmpeg.
>
> Do you have a version of the revert patch for master so that I can apply
> it there as a comparison for how it used to be?
>
> Peterdevel/ffmpeg-resync

Yes, Klaas' clip plays for me with no problems in ffmpeg-resync VDPAU
676d7f5, although mythffprobe gives a couple of pages of complaints
before the analysis.

And I don't want to distract from the main business of integrating 5.1,
but wonder if PR #610 has been overlooked?

Cheers,

John P
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org
Re: Call for testing devel/ffmpeg-resync (FFmpeg 5.1) [ In reply to ]
pb.mythtv at gmail
Sep 7, 2022, 11:22 AM
Post #5 of 13 (1006 views)
Permalink
On 9/7/22 06:05, John Pilkington wrote:
> On 06/09/2022 22:46, Peter Bennett wrote:
>>
>> On 9/6/22 14:46, Scott Theisen wrote:
>>> Hello all,
>>>
>>> I have merged FFmpeg 5.1 into our version and copied it into MythTV.
>>> Peter Bennett has pushed these commits from
>>> https://github.com/MythTV/mythtv/pull/627 to devel/ffmpeg-resync and
>>> we would appreciate further testing before it is merged to master.
>>>
>>> The deprecated avcodec_encode_video2 has been removed.  I modeled
>>> the replacement code on the audio version and would appreciate some
>>> testing of transcoding to make sure my replacement works. There is
>>> also a similar change to NuppleVideoRecoder, but I don't know if
>>> anyone actually still uses that.
>>>
>>> FFmpeg has created a new channel layout API and deprecated the old
>>> one.  This effects downmixing and I would appreciate confirmation
>>> that it still works as expected on non-SSE2 platforms.
>>>
>>> Those were the main things I wanted tested, but general testing
>>> would also be appreciated.
>>>
>>>
>>> Klaas,
>>>
>>> Could you test the attached patch on top of devel/ffmpeg-resync to
>>> test if https://trac.ffmpeg.org/ticket/9532 is still a bug? Apply
>>> the patch in the mythtv/external/FFmpeg folder and test VDPAU
>>> decoding with your sample.
>>>
>>> Thanks,
>>>
>>> Scott Theisen
>>>
>>>
>> I still have that video on my test system. IIRC it used to pixellate
>> in various places in the video before Klaas's patch. Using VDPAU.
>> with the ffmpeg-resync version it plays perfectly. With the
>> ffmpeg-resync version and the revert patch it pixellates badly for
>> 2-3 seconds at the start of the video but not at any other place. So
>> the problem may have partially been fixed in ffmpeg.
>>
>> Do you have a version of the revert patch for master so that I can
>> apply it there as a comparison for how it used to be?
>>
>> Peterdevel/ffmpeg-resync
>
> Yes, Klaas' clip plays for me with no problems in ffmpeg-resync VDPAU
> 676d7f5, although mythffprobe gives a couple of pages of complaints
> before the analysis.
>
> And I don't want to distract from the main business of integrating
> 5.1, but wonder if PR #610 has been overlooked?
>
> Cheers,
>
> John P
> _______________________________________________
>
John

Have you tested PR #610 ? If it is working correctly I can merge it into
master, fixes/32 and rebase devel/ffmpeg-resync so that it is included
there as well.

Peter

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org
Re: Call for testing devel/ffmpeg-resync (FFmpeg 5.1) [ In reply to ]
johnpilk222 at gmail
Sep 7, 2022, 2:43 PM
Post #6 of 13 (1005 views)
Permalink
On 07/09/2022 19:22, Peter Bennett wrote:
>
> On 9/7/22 06:05, John Pilkington wrote:
>> On 06/09/2022 22:46, Peter Bennett wrote:
>>>
>>> On 9/6/22 14:46, Scott Theisen wrote:
>>>> Hello all,
>>>>
>>>> I have merged FFmpeg 5.1 into our version and copied it into MythTV.
>>>> Peter Bennett has pushed these commits from
>>>> https://github.com/MythTV/mythtv/pull/627 to devel/ffmpeg-resync and
>>>> we would appreciate further testing before it is merged to master.
>>>>
>>>> The deprecated avcodec_encode_video2 has been removed.  I modeled
>>>> the replacement code on the audio version and would appreciate some
>>>> testing of transcoding to make sure my replacement works. There is
>>>> also a similar change to NuppleVideoRecoder, but I don't know if
>>>> anyone actually still uses that.
>>>>
>>>> FFmpeg has created a new channel layout API and deprecated the old
>>>> one.  This effects downmixing and I would appreciate confirmation
>>>> that it still works as expected on non-SSE2 platforms.
>>>>
>>>> Those were the main things I wanted tested, but general testing
>>>> would also be appreciated.
>>>>
>>>>
>>>> Klaas,
>>>>
>>>> Could you test the attached patch on top of devel/ffmpeg-resync to
>>>> test if https://trac.ffmpeg.org/ticket/9532 is still a bug? Apply
>>>> the patch in the mythtv/external/FFmpeg folder and test VDPAU
>>>> decoding with your sample.
>>>>
>>>> Thanks,
>>>>
>>>> Scott Theisen
>>>>
>>>>
>>> I still have that video on my test system. IIRC it used to pixellate
>>> in various places in the video before Klaas's patch. Using VDPAU.
>>> with the ffmpeg-resync version it plays perfectly. With the
>>> ffmpeg-resync version and the revert patch it pixellates badly for
>>> 2-3 seconds at the start of the video but not at any other place. So
>>> the problem may have partially been fixed in ffmpeg.
>>>
>>> Do you have a version of the revert patch for master so that I can
>>> apply it there as a comparison for how it used to be?
>>>
>>> Peterdevel/ffmpeg-resync
>>
>> Yes, Klaas' clip plays for me with no problems in ffmpeg-resync VDPAU
>> 676d7f5, although mythffprobe gives a couple of pages of complaints
>> before the analysis.
>>
>> And I don't want to distract from the main business of integrating
>> 5.1, but wonder if PR #610 has been overlooked?
>>
>> Cheers,
>>
>> John P
>> _______________________________________________
>>
> John
>
> Have you tested PR #610 ? If it is working correctly I can merge it into
> master, fixes/32 and rebase devel/ffmpeg-resync so that it is included
> there as well.
>
> Peter

Hi Peter: The tests that I did were described in comments on issue #548
on 19 July. They didn't use the commit from the PR, but a bunch of six
patches received as attachments, which Scott later combined to create
the PR after seeing my logfile. I haven't yet found the magic to create
an acceptable single git patch from the PR that I can use for a new
build of either master or devel/ffmpeg-resync. Sorry.

John
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org
Re: Call for testing devel/ffmpeg-resync (FFmpeg 5.1) [ In reply to ]
scott.the.elm at gmail
Sep 7, 2022, 4:06 PM
Post #7 of 13 (1005 views)
Permalink
On 9/6/22 17:46, Peter Bennett wrote:
>
> On 9/6/22 14:46, Scott Theisen wrote:
>> Hello all,
>>
>> I have merged FFmpeg 5.1 into our version and copied it into MythTV. 
>> Peter Bennett has pushed these commits from
>> https://github.com/MythTV/mythtv/pull/627 to devel/ffmpeg-resync and
>> we would appreciate further testing before it is merged to master.
>>
>> The deprecated avcodec_encode_video2 has been removed.  I modeled the
>> replacement code on the audio version and would appreciate some
>> testing of transcoding to make sure my replacement works. There is
>> also a similar change to NuppleVideoRecoder, but I don't know if
>> anyone actually still uses that.
>>
>> FFmpeg has created a new channel layout API and deprecated the old
>> one.  This effects downmixing and I would appreciate confirmation
>> that it still works as expected on non-SSE2 platforms.
>>
>> Those were the main things I wanted tested, but general testing would
>> also be appreciated.
>>
>>
>> Klaas,
>>
>> Could you test the attached patch on top of devel/ffmpeg-resync to
>> test if https://trac.ffmpeg.org/ticket/9532 is still a bug? Apply the
>> patch in the mythtv/external/FFmpeg folder and test VDPAU decoding
>> with your sample.
>>
>> Thanks,
>>
>> Scott Theisen
>>
>>
> I still have that video on my test system. IIRC it used to pixellate
> in various places in the video before Klaas's patch. Using VDPAU. with
> the ffmpeg-resync version it plays perfectly. With the ffmpeg-resync
> version and the revert patch it pixellates badly for 2-3 seconds at
> the start of the video but not at any other place. So the problem may
> have partially been fixed in ffmpeg.
>
> Do you have a version of the revert patch for master so that I can
> apply it there as a comparison for how it used to be?
>
> Peter

See attached for patch to master.  If I recall the discussion correctly,
there should be blocking/pixellation on skipping in addition to the start.

Scott

Attached Files:

Re: Call for testing devel/ffmpeg-resync (FFmpeg 5.1) [ In reply to ]
scott.the.elm at gmail
Sep 7, 2022, 4:37 PM
Post #8 of 13 (997 views)
Permalink
On 9/7/22 17:43, John Pilkington wrote:
> On 07/09/2022 19:22, Peter Bennett wrote:
>>
>> On 9/7/22 06:05, John Pilkington wrote:
>>> On 06/09/2022 22:46, Peter Bennett wrote:
>>>>
>>>> On 9/6/22 14:46, Scott Theisen wrote:
>>>>> Hello all,
>>>>>
>>>>> I have merged FFmpeg 5.1 into our version and copied it into
>>>>> MythTV. Peter Bennett has pushed these commits from
>>>>> https://github.com/MythTV/mythtv/pull/627 to devel/ffmpeg-resync
>>>>> and we would appreciate further testing before it is merged to
>>>>> master.
>>>>>
>>>>> The deprecated avcodec_encode_video2 has been removed.  I modeled
>>>>> the replacement code on the audio version and would appreciate
>>>>> some testing of transcoding to make sure my replacement works.
>>>>> There is also a similar change to NuppleVideoRecoder, but I don't
>>>>> know if anyone actually still uses that.
>>>>>
>>>>> FFmpeg has created a new channel layout API and deprecated the old
>>>>> one.  This effects downmixing and I would appreciate confirmation
>>>>> that it still works as expected on non-SSE2 platforms.
>>>>>
>>>>> Those were the main things I wanted tested, but general testing
>>>>> would also be appreciated.
>>>>>
>>>>>
>>>>> Klaas,
>>>>>
>>>>> Could you test the attached patch on top of devel/ffmpeg-resync to
>>>>> test if https://trac.ffmpeg.org/ticket/9532 is still a bug? Apply
>>>>> the patch in the mythtv/external/FFmpeg folder and test VDPAU
>>>>> decoding with your sample.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Scott Theisen
>>>>>
>>>>>
>>>> I still have that video on my test system. IIRC it used to
>>>> pixellate in various places in the video before Klaas's patch.
>>>> Using VDPAU. with the ffmpeg-resync version it plays perfectly.
>>>> With the ffmpeg-resync version and the revert patch it pixellates
>>>> badly for 2-3 seconds at the start of the video but not at any
>>>> other place. So the problem may have partially been fixed in ffmpeg.
>>>>
>>>> Do you have a version of the revert patch for master so that I can
>>>> apply it there as a comparison for how it used to be?
>>>>
>>>> Peterdevel/ffmpeg-resync
>>>
>>> Yes, Klaas' clip plays for me with no problems in ffmpeg-resync
>>> VDPAU 676d7f5, although mythffprobe gives a couple of pages of
>>> complaints before the analysis.
>>>
>>> And I don't want to distract from the main business of integrating
>>> 5.1, but wonder if PR #610 has been overlooked?
>>>
>>> Cheers,
>>>
>>> John P
>>> _______________________________________________
>>>
>> John
>>
>> Have you tested PR #610 ? If it is working correctly I can merge it
>> into master, fixes/32 and rebase devel/ffmpeg-resync so that it is
>> included there as well.
>>
>> Peter
>
> Hi Peter:  The tests that I did were described in comments on issue
> #548 on 19 July.  They didn't use the commit from the PR, but a bunch
> of six patches received as attachments, which Scott later combined to
> create the PR after seeing my logfile.  I haven't yet found the magic
> to create an acceptable single git patch from the PR that I can use
> for a new build of either master or devel/ffmpeg-resync.  Sorry.
>
> John

Pull Request 610 https://github.com/MythTV/mythtv/pull/610 is only one
commit.  I trimmed the extra logging that was for debugging only.  That
one commit is functionally equivalent to the six patches from
https://github.com/MythTV/mythtv/issues/548 .  It should apply cleanly
to both master and devel/ffmpeg-resync.

Scott

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org
Re: Call for testing devel/ffmpeg-resync (FFmpeg 5.1) [ In reply to ]
pb.mythtv at gmail
Sep 8, 2022, 6:47 AM
Post #9 of 13 (994 views)
Permalink
On 9/7/22 19:06, Scott Theisen wrote:
> On 9/6/22 17:46, Peter Bennett wrote:
>>
>> On 9/6/22 14:46, Scott Theisen wrote:
>>> Hello all,
>>>
>>> I have merged FFmpeg 5.1 into our version and copied it into
>>> MythTV.  Peter Bennett has pushed these commits from
>>> https://github.com/MythTV/mythtv/pull/627 to devel/ffmpeg-resync and
>>> we would appreciate further testing before it is merged to master.
>>>
>>> The deprecated avcodec_encode_video2 has been removed.  I modeled
>>> the replacement code on the audio version and would appreciate some
>>> testing of transcoding to make sure my replacement works. There is
>>> also a similar change to NuppleVideoRecoder, but I don't know if
>>> anyone actually still uses that.
>>>
>>> FFmpeg has created a new channel layout API and deprecated the old
>>> one.  This effects downmixing and I would appreciate confirmation
>>> that it still works as expected on non-SSE2 platforms.
>>>
>>> Those were the main things I wanted tested, but general testing
>>> would also be appreciated.
>>>
>>>
>>> Klaas,
>>>
>>> Could you test the attached patch on top of devel/ffmpeg-resync to
>>> test if https://trac.ffmpeg.org/ticket/9532 is still a bug? Apply
>>> the patch in the mythtv/external/FFmpeg folder and test VDPAU
>>> decoding with your sample.
>>>
>>> Thanks,
>>>
>>> Scott Theisen
>>>
>>>
>> I still have that video on my test system. IIRC it used to pixellate
>> in various places in the video before Klaas's patch. Using VDPAU.
>> with the ffmpeg-resync version it plays perfectly. With the
>> ffmpeg-resync version and the revert patch it pixellates badly for
>> 2-3 seconds at the start of the video but not at any other place. So
>> the problem may have partially been fixed in ffmpeg.
>>
>> Do you have a version of the revert patch for master so that I can
>> apply it there as a comparison for how it used to be?
>>
>> Peter
>
> See attached for patch to master.  If I recall the discussion
> correctly, there should be blocking/pixellation on skipping in
> addition to the start.
>
> Scott
>
> _______________________________________________

I have to set my skip amount vary small (10 seconds) to test skipping
because the entire clip is only 1 minute.

Both master with the revert patch and ffmpeg-resync with the revert
patch show pixelation at the start and sometimes after skipping. There
is no difference. Both master and ffmpeg-resync are perfect without this
patch. It seems the underlying bug is partially fixed in both master and
ffmpeg-resync with your revert patch. The pixelation on skipping is only
one time out of ten. Have you backed out Klaas's fiox completely with
the revert, or possibly only backed out part of it?

VLC player (3.0.17.4-2~22.04.sav2)  shows the pixellation on that clip
every time after skipping, so it is worse than mythfrontend is now. I
think this is how mythfrontend was initially behaving before Klaas's fix.

Peter

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org
Re: Call for testing devel/ffmpeg-resync (FFmpeg 5.1) re PR#610 [ In reply to ]
johnpilk222 at gmail
Sep 8, 2022, 7:51 AM
Post #10 of 13 (994 views)
Permalink
On 08/09/2022 00:37, Scott Theisen wrote:
> On 9/7/22 17:43, John Pilkington wrote:
>> On 07/09/2022 19:22, Peter Bennett wrote:
>>>
>>> On 9/7/22 06:05, John Pilkington wrote:
>>>> On 06/09/2022 22:46, Peter Bennett wrote:
>>>>>
>>>>> On 9/6/22 14:46, Scott Theisen wrote:
>>>>>> Hello all,
>>>>>>
>>>>>> I have merged FFmpeg 5.1 into our version and copied it into
>>>>>> MythTV. Peter Bennett has pushed these commits from
>>>>>> https://github.com/MythTV/mythtv/pull/627 to devel/ffmpeg-resync
>>>>>> and we would appreciate further testing before it is merged to
>>>>>> master.
>>>>>>
>>>>>> The deprecated avcodec_encode_video2 has been removed.  I modeled
>>>>>> the replacement code on the audio version and would appreciate
>>>>>> some testing of transcoding to make sure my replacement works.
>>>>>> There is also a similar change to NuppleVideoRecoder, but I don't
>>>>>> know if anyone actually still uses that.
>>>>>>
>>>>>> FFmpeg has created a new channel layout API and deprecated the old
>>>>>> one.  This effects downmixing and I would appreciate confirmation
>>>>>> that it still works as expected on non-SSE2 platforms.
>>>>>>
>>>>>> Those were the main things I wanted tested, but general testing
>>>>>> would also be appreciated.
>>>>>>
>>>>>>
>>>>>> Klaas,
>>>>>>
>>>>>> Could you test the attached patch on top of devel/ffmpeg-resync to
>>>>>> test if https://trac.ffmpeg.org/ticket/9532 is still a bug? Apply
>>>>>> the patch in the mythtv/external/FFmpeg folder and test VDPAU
>>>>>> decoding with your sample.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Scott Theisen
>>>>>>
>>>>>>
>>>>> I still have that video on my test system. IIRC it used to
>>>>> pixellate in various places in the video before Klaas's patch.
>>>>> Using VDPAU. with the ffmpeg-resync version it plays perfectly.
>>>>> With the ffmpeg-resync version and the revert patch it pixellates
>>>>> badly for 2-3 seconds at the start of the video but not at any
>>>>> other place. So the problem may have partially been fixed in ffmpeg.
>>>>>
>>>>> Do you have a version of the revert patch for master so that I can
>>>>> apply it there as a comparison for how it used to be?
>>>>>
>>>>> Peterdevel/ffmpeg-resync
>>>>
>>>> Yes, Klaas' clip plays for me with no problems in ffmpeg-resync
>>>> VDPAU 676d7f5, although mythffprobe gives a couple of pages of
>>>> complaints before the analysis.
>>>>
>>>> And I don't want to distract from the main business of integrating
>>>> 5.1, but wonder if PR #610 has been overlooked?
>>>>
>>>> Cheers,
>>>>
>>>> John P
>>>> _______________________________________________
>>>>
>>> John
>>>
>>> Have you tested PR #610 ? If it is working correctly I can merge it
>>> into master, fixes/32 and rebase devel/ffmpeg-resync so that it is
>>> included there as well.
>>>
>>> Peter
>>
>> Hi Peter:  The tests that I did were described in comments on issue
>> #548 on 19 July.  They didn't use the commit from the PR, but a bunch
>> of six patches received as attachments, which Scott later combined to
>> create the PR after seeing my logfile.  I haven't yet found the magic
>> to create an acceptable single git patch from the PR that I can use
>> for a new build of either master or devel/ffmpeg-resync.  Sorry.
>>
>> John
>
> Pull Request 610 https://github.com/MythTV/mythtv/pull/610 is only one
> commit.  I trimmed the extra logging that was for debugging only.  That
> one commit is functionally equivalent to the six patches from
> https://github.com/MythTV/mythtv/issues/548 .  It should apply cleanly
> to both master and devel/ffmpeg-resync.
>
> Scott

Google revealed that the patch would be at

https://github.com/MythTV/mythtv/pull/610.patch

I applied that patch to devel/ffmpeg-resync and have rerun the tests
from 19 July.

New recordings from DVB-T BBC1 and DVB-T2 BBC1_HD still show their
correct durations.

A new recording from one of the channels in the 'local' DVB-T mux now
shows its correct duration. A similar recording made with the unpatched
system still shows duration and frame-count both double their true values.

I think that for MPEG2 encoded recordings issue #548 is fixed.

John P


_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org
Re: Call for testing devel/ffmpeg-resync (FFmpeg 5.1) [ In reply to ]
scott.the.elm at gmail
Sep 9, 2022, 12:54 PM
Post #11 of 13 (982 views)
Permalink
On 9/8/22 09:47, Peter Bennett wrote:
>
> On 9/7/22 19:06, Scott Theisen wrote:
>> On 9/6/22 17:46, Peter Bennett wrote:
>>>
>>> On 9/6/22 14:46, Scott Theisen wrote:
>>>> Hello all,
>>>>
>>>> I have merged FFmpeg 5.1 into our version and copied it into
>>>> MythTV.  Peter Bennett has pushed these commits from
>>>> https://github.com/MythTV/mythtv/pull/627 to devel/ffmpeg-resync
>>>> and we would appreciate further testing before it is merged to master.
>>>>
>>>> The deprecated avcodec_encode_video2 has been removed.  I modeled
>>>> the replacement code on the audio version and would appreciate some
>>>> testing of transcoding to make sure my replacement works. There is
>>>> also a similar change to NuppleVideoRecoder, but I don't know if
>>>> anyone actually still uses that.
>>>>
>>>> FFmpeg has created a new channel layout API and deprecated the old
>>>> one.  This effects downmixing and I would appreciate confirmation
>>>> that it still works as expected on non-SSE2 platforms.
>>>>
>>>> Those were the main things I wanted tested, but general testing
>>>> would also be appreciated.
>>>>
>>>>
>>>> Klaas,
>>>>
>>>> Could you test the attached patch on top of devel/ffmpeg-resync to
>>>> test if https://trac.ffmpeg.org/ticket/9532 is still a bug? Apply
>>>> the patch in the mythtv/external/FFmpeg folder and test VDPAU
>>>> decoding with your sample.
>>>>
>>>> Thanks,
>>>>
>>>> Scott Theisen
>>>>
>>>>
>>> I still have that video on my test system. IIRC it used to pixellate
>>> in various places in the video before Klaas's patch. Using VDPAU.
>>> with the ffmpeg-resync version it plays perfectly. With the
>>> ffmpeg-resync version and the revert patch it pixellates badly for
>>> 2-3 seconds at the start of the video but not at any other place. So
>>> the problem may have partially been fixed in ffmpeg.
>>>
>>> Do you have a version of the revert patch for master so that I can
>>> apply it there as a comparison for how it used to be?
>>>
>>> Peter
>>
>> See attached for patch to master.  If I recall the discussion
>> correctly, there should be blocking/pixellation on skipping in
>> addition to the start.
>>
>> Scott
>>
>> _______________________________________________
>
> I have to set my skip amount vary small (10 seconds) to test skipping
> because the entire clip is only 1 minute.
>
> Both master with the revert patch and ffmpeg-resync with the revert
> patch show pixelation at the start and sometimes after skipping. There
> is no difference. Both master and ffmpeg-resync are perfect without
> this patch. It seems the underlying bug is partially fixed in both
> master and ffmpeg-resync with your revert patch. The pixelation on
> skipping is only one time out of ten. Have you backed out Klaas's fiox
> completely with the revert, or possibly only backed out part of it?
>
> VLC player (3.0.17.4-2~22.04.sav2)  shows the pixellation on that clip
> every time after skipping, so it is worse than mythfrontend is now. I
> think this is how mythfrontend was initially behaving before Klaas's fix.
>
> Peter

For master, I did `git revert c257bacbfe7b5edf0f111d8b9b03c5cfd0602b4a`
(https://github.com/MythTV/mythtv/commit/c257bacbfe7b5edf0f111d8b9b03c5cfd0602b4a
) which I believe is the entire fix since Klaas mentioned reverting an
FFmpeg commit in the FFmpeg bug report.  For ffmpeg-resync, I made the
file match FFmpeg 5.1.

Although, testing with VLC (3.0.16 Vetinari (revision
3.0.13-8-g41878ff4f2) on Ubuntu 22.04) it does the block like artifacts
every time with or without hardware acceleration disabled, but only when
skipping and not at the start.  In VLC it was much easier to see when
skipping and paused.

Although, I am fairly certain nouveau does not support hardware video
acceleration for the GTX 970, so it should always be software decoding.

I could not replicate the issue with ffplay version
4.4.2-0ubuntu0.22.04.1, however.  I used `ffplay -sn -vf yadif
trac_9532_blocks_with_vdpau.ts`.  This may be relevant to the bug?

Scott

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org
Re: Call for testing devel/ffmpeg-resync (FFmpeg 5.1) [ In reply to ]
piotr.oniszczuk at gmail
Sep 10, 2022, 3:38 AM
Post #12 of 13 (972 views)
Permalink
> Wiadomo?? napisana przez Scott Theisen <scott.the.elm@gmail.com> w dniu 06.09.2022, o godz. 20:46:
>
> Hello all,
>
> I have merged FFmpeg 5.1 into our version and copied it into MythTV. Peter Bennett has pushed these commits from https://github.com/MythTV/mythtv/pull/627 to devel/ffmpeg-resync and we would appreciate further testing before it is merged to master.
>
> The deprecated avcodec_encode_video2 has been removed. I modeled the replacement code on the audio version and would appreciate some testing of transcoding to make sure my replacement works. There is also a similar change to NuppleVideoRecoder, but I don't know if anyone actually still uses that.
>
> FFmpeg has created a new channel layout API and deprecated the old one. This effects downmixing and I would appreciate confirmation that it still works as expected on non-SSE2 platforms.
>
> Those were the main things I wanted tested, but general testing would also be appreciated.
>
>
> Klaas,
>
> Could you test the attached patch on top of devel/ffmpeg-resync to test if https://trac.ffmpeg.org/ticket/9532 is still a bug? Apply the patch in the mythtv/external/FFmpeg folder and test VDPAU decoding with your sample.
>
> Thanks,
>
> Scott Theisen<ffmpeg_revert.patch>_______________________________________________
> mythtv-dev mailing list
> mythtv-dev@mythtv.org
> http://lists.mythtv.org/mailman/listinfo/mythtv-dev
> http://wiki.mythtv.org/Mailing_List_etiquette
> MythTV Forums: https://forum.mythtv.org

Scott, Peter,

great work!

fyi:

i tested following with results:

ION1 (vdpau by nouveau): ok
ION2 (vdpau by nouveau): ok
AMD E2100 Kabini (vaapi by mesa): ok
N3450 (vaapi by i965 and iHD): ok
allwinner (v4l2_request): ok
rockchip (v4l2_request): ok
rpi3 (v4l2_m2m): ok
amlogic (v4l2_m2m): ok
rpi4 (v4l2_m2m): ok
rpi4 (v4l2_request): ok

br

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org
Re: Call for testing devel/ffmpeg-resync (FFmpeg 5.1) [ In reply to ]
piotr.oniszczuk at gmail
Sep 10, 2022, 6:24 AM
Post #13 of 13 (970 views)
Permalink
> Wiadomo?? napisana przez Piotr Oniszczuk <piotr.oniszczuk@gmail.com> w dniu 10.09.2022, o godz. 12:38:
>
>
> Scott, Peter,
>
> great work!
>
> fyi:
>
> i tested following with results:
>
> ION1 (vdpau by nouveau): ok
> ION2 (vdpau by nouveau): ok
> AMD E2100 Kabini (vaapi by mesa): ok
> N3450 (vaapi by i965 and iHD): ok
> allwinner (v4l2_request): ok
> rockchip (v4l2_request): ok
> rpi3 (v4l2_m2m): ok
> amlogic (v4l2_m2m): ok
> rpi4 (v4l2_m2m): ok
> rpi4 (v4l2_request): ok
>
> br
>

ah - forgot to add:

macOS (vtb): ok

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

©2024 GT.net. A Gossamer Threads company.
5th Floor, 455 Granville St., Vancouver, BC V6C 1T1, Canada | Legal