Mailing List Archive

Current master plugins packaging failure
After yesterday's bunch of commits, using the gtb script I get:

Checking for unpackaged file(s): /usr/lib/rpm/check-files
/builddir/build/BUILDROOT/mythtv-plugins-33.Pre.320.g9108734c53-100.fc34.x86_64
error: Installed (but unpackaged) file(s) found:
/usr/share/mythtv/mythgame/giantbomb.py
/usr/share/mythtv/mythgame/giantbomb/XSLT/giantbombGame.xsl
/usr/share/mythtv/mythgame/giantbomb/XSLT/giantbombQuery.xsl
/usr/share/mythtv/mythgame/giantbomb/__init__.py
/usr/share/mythtv/mythgame/giantbomb/giantbomb_api.py
/usr/share/mythtv/mythgame/giantbomb/giantbomb_exceptions.py
Installed (but unpackaged) file(s) found:
/usr/share/mythtv/mythgame/giantbomb.py
/usr/share/mythtv/mythgame/giantbomb/XSLT/giantbombGame.xsl
/usr/share/mythtv/mythgame/giantbomb/XSLT/giantbombQuery.xsl
/usr/share/mythtv/mythgame/giantbomb/__init__.py
/usr/share/mythtv/mythgame/giantbomb/giantbomb_api.py
/usr/share/mythtv/mythgame/giantbomb/giantbomb_exceptions.py


RPM build errors:

John P


_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org
Re: Current master plugins packaging failure [ In reply to ]
On Wed, 2022-05-04 at 12:04 +0100, John Pilkington wrote:
> After yesterday's bunch of commits, using the gtb script I get:
>
> Checking for unpackaged file(s): /usr/lib/rpm/check-files
> /builddir/build/BUILDROOT/mythtv-plugins-33.Pre.320.g9108734c53-
> 100.fc34.x86_64
> error: Installed (but unpackaged) file(s) found:
>     /usr/share/mythtv/mythgame/giantbomb.py
>     /usr/share/mythtv/mythgame/giantbomb/XSLT/giantbombGame.xsl
>     /usr/share/mythtv/mythgame/giantbomb/XSLT/giantbombQuery.xsl
>     /usr/share/mythtv/mythgame/giantbomb/__init__.py
>     /usr/share/mythtv/mythgame/giantbomb/giantbomb_api.py
>     /usr/share/mythtv/mythgame/giantbomb/giantbomb_exceptions.py
>      Installed (but unpackaged) file(s) found:
>     /usr/share/mythtv/mythgame/giantbomb.py
>     /usr/share/mythtv/mythgame/giantbomb/XSLT/giantbombGame.xsl
>     /usr/share/mythtv/mythgame/giantbomb/XSLT/giantbombQuery.xsl
>     /usr/share/mythtv/mythgame/giantbomb/__init__.py
>     /usr/share/mythtv/mythgame/giantbomb/giantbomb_api.py
>     /usr/share/mythtv/mythgame/giantbomb/giantbomb_exceptions.py

My last set of commits moved those files from ../mythtv/metadata/Game
to ../mythtv/mythgame. I think there are arguments for both directory
names, and I don't have a strong preference either way. I would have no
problem moving it back if that's what everyone prefers.

David

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org
Re: Current master plugins packaging failure [ In reply to ]
On 04/05/2022 14:39, David Hampton via mythtv-dev wrote:
> On Wed, 2022-05-04 at 12:04 +0100, John Pilkington wrote:
>> After yesterday's bunch of commits, using the gtb script I get:
>>
>> Checking for unpackaged file(s): /usr/lib/rpm/check-files
>> /builddir/build/BUILDROOT/mythtv-plugins-33.Pre.320.g9108734c53-
>> 100.fc34.x86_64
>> error: Installed (but unpackaged) file(s) found:
>>     /usr/share/mythtv/mythgame/giantbomb.py
>>     /usr/share/mythtv/mythgame/giantbomb/XSLT/giantbombGame.xsl
>>     /usr/share/mythtv/mythgame/giantbomb/XSLT/giantbombQuery.xsl
>>     /usr/share/mythtv/mythgame/giantbomb/__init__.py
>>     /usr/share/mythtv/mythgame/giantbomb/giantbomb_api.py
>>     /usr/share/mythtv/mythgame/giantbomb/giantbomb_exceptions.py
>>      Installed (but unpackaged) file(s) found:
>>     /usr/share/mythtv/mythgame/giantbomb.py
>>     /usr/share/mythtv/mythgame/giantbomb/XSLT/giantbombGame.xsl
>>     /usr/share/mythtv/mythgame/giantbomb/XSLT/giantbombQuery.xsl
>>     /usr/share/mythtv/mythgame/giantbomb/__init__.py
>>     /usr/share/mythtv/mythgame/giantbomb/giantbomb_api.py
>>     /usr/share/mythtv/mythgame/giantbomb/giantbomb_exceptions.py
>
> My last set of commits moved those files from ../mythtv/metadata/Game
> to ../mythtv/mythgame. I think there are arguments for both directory
> names, and I don't have a strong preference either way. I would have no
> problem moving it back if that's what everyone prefers.
>
> David

I can't express a preference. Here's a relevant commit in the specfile:

> https://github.com/garybuhrmaster/packaging/commit/71d6d8c60878ce2d94466fd573da294c12f76083

John

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org
Re: Current master plugins packaging failure [ In reply to ]
On 04/05/2022 14:39, David Hampton via mythtv-dev wrote:
>
> > My last set of commits moved those files from ../mythtv/metadata/Game
> > to ../mythtv/mythgame. I think there are arguments for both directory
> > names, and I don't have a strong preference either way. I would have no
> > problem moving it back if that's what everyone prefers.
> >
> > David
>
>
In this case, you will need to update the schema version, provide a zombie
lifter for the current database,
and correct these files:
metadatagrabber.cpp#L43
<https://github.com/MythTV/mythtv/blob/9108734c5356d20d679f9201bbc2305b34f242ac/mythtv/libs/libmythmetadata/metadatagrabber.cpp#L43>
grabbersettings.cpp#L120
<https://github.com/MythTV/mythtv/blob/9108734c5356d20d679f9201bbc2305b34f242ac/mythtv/programs/mythfrontend/grabbersettings.cpp#L120>

I see no reason to change the default location of the metadata grabbers.
And giantbomb.py is a sort of a metadata grabber.

Roland
Re: Current master plugins packaging failure [ In reply to ]
On Wed, 2022-05-04 at 19:45 +0200, Roland Ernst wrote:
>
>
> > On 04/05/2022 14:39, David Hampton via mythtv-dev wrote:
> >
> > > My last set of commits moved those files from
> > > ../mythtv/metadata/Game
> > > to ../mythtv/mythgame.  I think there are arguments for both
> > > directory
> > > names, and I don't have a strong preference either way. I would
> > > have no
> > > problem moving it back if that's what everyone prefers.
> > >
> > > David
> >
> >
>
>
> In this case, you will need to update the schema version, provide a
> zombie lifter for the current database,
> and correct these files:
> metadatagrabber.cpp#L43
> grabbersettings.cpp#L120

Thank you. I was looking for references like that and didn't find them.

> I see no reason to change the default location of the metadata
> grabbers.
> And giantbomb.py is a sort of a metadata grabber.

I'll move them back.

David

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org