Mailing List Archive: Proposed change to android build setenv.sh

Proposed change to android build setenv.sh

Jan 27, 2020, 1:50 PM

Post #1 of 6 (1123 views)

The current build require setenv.sh to be copied to ~/android/.
Every time setenv.sh changes I have to copy it again and make my
personalizations.
I propose add the following lines to the end of setenv.sh

if [[ -f $ANDROID_ROOT/custom.source ]] ; then
. $ANDROID_ROOT/custom.source
fi

Then people can put their customizations in ~/android/custom.source.

Also I propose to change the scripts to source setenv.sh from
MythTV/packaging/android/android-utilities/setenv.sh instead of from
~/android.

My custom.source is:

export KEYSTORE=$HOME/.android/android-release-key.jks
export KEYALIAS=mythfrontend
export KEYSTOREPASSWORD=XXXXXXXX
# comment these for 32 bit build
cat <<EOF >make.inc
target_arch=arm64
ARM64=1
EOF

Changing between 32 bit and 64 bit involves only changing custom.source.

Any problems with this? Maybe a different name for custom.source?

Peter

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

Re: Proposed change to android build setenv.sh [ In reply to ]

mark at digivation

Jan 27, 2020, 2:53 PM

Post #2 of 6 (1122 views)

Permalink

On 28/01/2020 8:50 am, Peter Bennett wrote:
> The current build require setenv.sh to be copied to ~/android/.
> Every time setenv.sh changes I have to copy it again and make my
> personalizations.
> I propose add the following lines to the end of setenv.sh
>
> if [[ -f $ANDROID_ROOT/custom.source ]] ; then
> . $ANDROID_ROOT/custom.source
> fi
>
> Then people can put their customizations in ~/android/custom.source.
>
> Also I propose to change the scripts to source setenv.sh from
> MythTV/packaging/android/android-utilities/setenv.sh instead of from
> ~/android.
>
> My custom.source is:
>
> export KEYSTORE=$HOME/.android/android-release-key.jks
> export KEYALIAS=mythfrontend
> export KEYSTOREPASSWORD=XXXXXXXX
> # comment these for 32 bit build
> cat <<EOF >make.inc
> target_arch=arm64
> ARM64=1
> EOF
>
> Changing between 32 bit and 64 bit involves only changing custom.source.
>
> Any problems with this? Maybe a different name for custom.source?
>
Sounds fine to me. There is also a ~/.android directory for configs to
studio. May be an even better place.

Mark

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

Re: Proposed change to android build setenv.sh [ In reply to ]

david at istwok

Jan 27, 2020, 3:25 PM

Post #3 of 6 (1122 views)

Permalink

On Mon, Jan 27, 2020 at 04:50:31PM -0500, Peter Bennett wrote:
> The current build require setenv.sh to be copied to ~/android/.
> Every time setenv.sh changes I have to copy it again and make my
> personalizations.
> I propose add the following lines to the end of setenv.sh
>
> if [[ -f $ANDROID_ROOT/custom.source ]] ; then
> ??? . $ANDROID_ROOT/custom.source
> fi
>
> Then people can put their customizations in ~/android/custom.source.
>
> Also I propose to change the scripts to source setenv.sh from
> MythTV/packaging/android/android-utilities/setenv.sh instead of from
> ~/android.
>
> My custom.source is:
>
> export KEYSTORE=$HOME/.android/android-release-key.jks
> export KEYALIAS=mythfrontend
> export KEYSTOREPASSWORD=XXXXXXXX
> # comment these for 32 bit build
> cat <<EOF >make.inc
> target_arch=arm64
> ARM64=1
> EOF
>
> Changing between 32 bit and 64 bit involves only changing custom.source.
>
> Any problems with this?? Maybe a different name for custom.source?

I'm in favor of both changes, espcially the second one. We should not
need to put any of our files in ~/[Aa]ndroid.

David
--
David Engel
david@istwok.net
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

Re: Proposed change to android build setenv.sh [ In reply to ]

pb.mythtv at gmail

Jan 27, 2020, 4:41 PM

Post #4 of 6 (1121 views)

Permalink

On 1/27/20 6:25 PM, David Engel wrote:
> On Mon, Jan 27, 2020 at 04:50:31PM -0500, Peter Bennett wrote:
>> The current build require setenv.sh to be copied to ~/android/.
>> Every time setenv.sh changes I have to copy it again and make my
>> personalizations.
>> I propose add the following lines to the end of setenv.sh
>>
>> if [[ -f $ANDROID_ROOT/custom.source ]] ; then
>> . $ANDROID_ROOT/custom.source
>> fi
>>
>> Then people can put their customizations in ~/android/custom.source.
>>
>> Also I propose to change the scripts to source setenv.sh from
>> MythTV/packaging/android/android-utilities/setenv.sh instead of from
>> ~/android.
>>
>> My custom.source is:
>>
>> export KEYSTORE=$HOME/.android/android-release-key.jks
>> export KEYALIAS=mythfrontend
>> export KEYSTOREPASSWORD=XXXXXXXX
>> # comment these for 32 bit build
>> cat <<EOF >make.inc
>> target_arch=arm64
>> ARM64=1
>> EOF
>>
>> Changing between 32 bit and 64 bit involves only changing custom.source.
>>
>> Any problems with this? Maybe a different name for custom.source?
> I'm in favor of both changes, espcially the second one. We should not
> need to put any of our files in ~/[Aa]ndroid.
>
> David
I am confused. Part of the solution above is putting custom.source in
~/android. Where would you like that if we put nothing in ~/android/ ?
Do you prefer ~/.android?

Peter
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

Re: Proposed change to android build setenv.sh [ In reply to ]

mark at digivation

Jan 27, 2020, 5:21 PM

Post #5 of 6 (1121 views)

Permalink

On 28/01/2020 11:41 am, Peter Bennett wrote:
>
>
> On 1/27/20 6:25 PM, David Engel wrote:
>> On Mon, Jan 27, 2020 at 04:50:31PM -0500, Peter Bennett wrote:
>>> The current build require setenv.sh to be copied to ~/android/.
>>> Every time setenv.sh changes I have to copy it again and make my
>>> personalizations.
>>> I propose add the following lines to the end of setenv.sh
>>>
>>> if [[ -f $ANDROID_ROOT/custom.source ]] ; then
>>> . $ANDROID_ROOT/custom.source
>>> fi
>>>
>>> Then people can put their customizations in ~/android/custom.source.
>>>
>>> Also I propose to change the scripts to source setenv.sh from
>>> MythTV/packaging/android/android-utilities/setenv.sh instead of from
>>> ~/android.
>>>
>>> My custom.source is:
>>>
>>> export KEYSTORE=$HOME/.android/android-release-key.jks
>>> export KEYALIAS=mythfrontend
>>> export KEYSTOREPASSWORD=XXXXXXXX
>>> # comment these for 32 bit build
>>> cat <<EOF >make.inc
>>> target_arch=arm64
>>> ARM64=1
>>> EOF
>>>
>>> Changing between 32 bit and 64 bit involves only changing
>>> custom.source.
>>>
>>> Any problems with this? Maybe a different name for custom.source?
>> I'm in favor of both changes, espcially the second one. We should not
>> need to put any of our files in ~/[Aa]ndroid.
>>
>> David
> I am confused. Part of the solution above is putting custom.source in
> ~/android. Where would you like that if we put nothing in ~/android/ ?
> Do you prefer ~/.android?
>
I'm not sure. Whereever is ok with me. Its a good change.

Perhaps even the next level is to pull android studio, install the
required components with sdkmanager and keep it all isolated from the
main android install. Turnkey build then. Next steps.

The key is still needed to create an apk though so need a mechanism for
this. You choose where. Im fine with any solution.

Mark

_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org

Re: Proposed change to android build setenv.sh [ In reply to ]

david at istwok

Jan 27, 2020, 6:50 PM

Post #6 of 6 (1119 views)

Permalink

On Mon, Jan 27, 2020 at 07:41:16PM -0500, Peter Bennett wrote:
>
>
> On 1/27/20 6:25 PM, David Engel wrote:
> > On Mon, Jan 27, 2020 at 04:50:31PM -0500, Peter Bennett wrote:
> > > The current build require setenv.sh to be copied to ~/android/.
> > > Every time setenv.sh changes I have to copy it again and make my
> > > personalizations.
> > > I propose add the following lines to the end of setenv.sh
> > >
> > > if [[ -f $ANDROID_ROOT/custom.source ]] ; then
> > > ??? . $ANDROID_ROOT/custom.source
> > > fi
> > >
> > > Then people can put their customizations in ~/android/custom.source.
> > >
> > > Also I propose to change the scripts to source setenv.sh from
> > > MythTV/packaging/android/android-utilities/setenv.sh instead of from
> > > ~/android.
> > >
> > > My custom.source is:
> > >
> > > export KEYSTORE=$HOME/.android/android-release-key.jks
> > > export KEYALIAS=mythfrontend
> > > export KEYSTOREPASSWORD=XXXXXXXX
> > > # comment these for 32 bit build
> > > cat <<EOF >make.inc
> > > target_arch=arm64
> > > ARM64=1
> > > EOF
> > >
> > > Changing between 32 bit and 64 bit involves only changing custom.source.
> > >
> > > Any problems with this?? Maybe a different name for custom.source?
> > I'm in favor of both changes, espcially the second one. We should not
> > need to put any of our files in ~/[Aa]ndroid.
> >
> > David
> I am confused. Part of the solution above is putting custom.source in
> ~/android. Where would you like that if we put nothing in ~/android/ ? Do
> you prefer ~/.android?

I would like all of our checked-in and custom (like make.inc) files to
go in .../packaging/android. I thought that's what you meant by
"source setenv.sh from". The only potentially, tricky thing is to
make sure our extra, custom files don't get removed by "git clean".

David
--
David Engel
david@istwok.net
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-dev
http://wiki.mythtv.org/Mailing_List_etiquette
MythTV Forums: https://forum.mythtv.org