Mailing List Archive

[MythTV/mythtv] 09c82a: Remove std::move from Service API macro
Branch: refs/heads/master
Home: https://github.com/MythTV/mythtv
Commit: 09c82a11a19cc6250b807443ce054daa7141bd33
https://github.com/MythTV/mythtv/commit/09c82a11a19cc6250b807443ce054daa7141bd33
Author: Peter Bennett <pbennett@mythtv.org>
Date: 2023-03-28 (Tue, 28 Mar 2023)

Changed paths:
M mythtv/libs/libmythbase/http/mythhttpservice.h
M mythtv/programs/mythbackend/servicesv2/v2myth.cpp

Log Message:
-----------
Remove std::move from Service API macro

std::move is dangerous to use without careful analysis. It causes the
original value to be cleared. This resulted in a problem with
Myth/GetBackendInfo and may cause unexpected problems with other API
methods. Removing it from the macro removes it from all API value
setting and causes an assignment to be done instead.

This commit also reverts commit c92362e , which was a workaround fix
for Myth/GetBackendInfo.

Fixes #739


_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits