Mailing List Archive

[MythTV/mythtv] f6143c: libmythtv: use AV_SUBTITLE_FLAG_FORCED
Branch: refs/heads/master
Home: https://github.com/MythTV/mythtv
Commit: f6143c19ff1cce41d9bd98194a37253819f30ba2
https://github.com/MythTV/mythtv/commit/f6143c19ff1cce41d9bd98194a37253819f30ba2
Author: Scott Theisen <scott.the.elm@gmail.com>
Date: 2022-12-03 (Sat, 03 Dec 2022)

Changed paths:
M mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp
M mythtv/libs/libmythtv/captions/subtitlereader.cpp
M mythtv/libs/libmythtv/captions/subtitlescreen.cpp
M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

Log Message:
-----------
libmythtv: use AV_SUBTITLE_FLAG_FORCED

instead of MythTV customization AVSubtitle::forced.

This is the method FFmpeg already has for detecting this.
Additionally, PGS subtitles may produce AVSubitles containing
both forced and non-forced `AVSubtitleRect`s. I don't think
the code handles this, but the behavior should be identical
to previously.


Commit: 7ebfa0f03c6ae25496150f807251ccf97f29b038
https://github.com/MythTV/mythtv/commit/7ebfa0f03c6ae25496150f807251ccf97f29b038
Author: Scott Theisen <scott.the.elm@gmail.com>
Date: 2022-12-03 (Sat, 03 Dec 2022)

Changed paths:
M mythtv/external/FFmpeg/libavcodec/avcodec.h
M mythtv/external/FFmpeg/libavcodec/dvdsubdec.c
M mythtv/external/FFmpeg/libavcodec/pgssubdec.c

Log Message:
-----------
libavcodec: remove MythTV customization AVSubtitle::forced

Its uses have been replaced with AV_SUBTITLE_FLAG_FORCED of
AVSubtitleRect::flags.

Attempting to upstream these changes revealed this with the
following addtional comments:
"sizeof(AVSubtitle) is part of the public ABI, no additions to it are
possible."

"[Using AVSubtitleRect::flags]
is also more correct, since in PGS for example you can have both
active rects that are forced, and those that are not, at the same
time."


Compare: https://github.com/MythTV/mythtv/compare/f43e2f0a36ba...7ebfa0f03c6a
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits