Branch: refs/heads/master
Home: https://github.com/MythTV/mythtv
Commit: 89bf2a9d0cae7b200b1a29464d7ecb93a18572be
https://github.com/MythTV/mythtv/commit/89bf2a9d0cae7b200b1a29464d7ecb93a18572be
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/libs/libmythtv/videosource.cpp
Log Message:
-----------
clazy: Use 4-arg connect in videosource.
Clazy recommends using the 4-arg variant of Object::connect over the
3-arg version. The main reason for this is that the signal will not be
called if the target object has been deleted.
In this instance, it appears clear that the target object is the
current object, since the lambda is referencing variables in the
CardInput class.
https://github.com/KDE/clazy/blob/master/docs/checks/README-connect-3arg-lambda.md
Commit: 8277bf19a7d10b8f3ce7062c78c86bbe9e908627
https://github.com/MythTV/mythtv/commit/8277bf19a7d10b8f3ce7062c78c86bbe9e908627
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/programs/mythfrontend/globalsettings.cpp
Log Message:
-----------
clazy: Use 4-arg connect in globalsettings.
Clazy recommends using the 4-arg variant of Object::connect over the
3-arg version. The main reason for this is that the signal will not be
called if the target object has been deleted.
In this instance, the lambda doesn't really require an object since is
only calling static functions, and functions on a global object. Use
the sender object as the receiver, which should guarantee that the
receiver object is always valid.
https://github.com/KDE/clazy/blob/master/docs/checks/README-connect-3arg-lambda.md
Commit: 043640477ebd22d416d11dd8b1d38a2c7769f30b
https://github.com/MythTV/mythtv/commit/043640477ebd22d416d11dd8b1d38a2c7769f30b
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/libs/libmyth/mythcontext.cpp
Log Message:
-----------
tidy: Fix "argument looks like it might be swapped" warning in mythcorecontext.
Change the MythContextPrivate::Init argument names to match those of
MythContextPrivate::Init.
https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
Commit: 34f0950a9842c8cc67aaa82a5c08e1b13a5d466b
https://github.com/MythTV/mythtv/commit/34f0950a9842c8cc67aaa82a5c08e1b13a5d466b
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/libs/libmythtv/mythplayer.cpp
M mythtv/libs/libmythtv/mythvideooutgpu.cpp
M mythtv/libs/libmythtv/mythvideooutgpu.h
M mythtv/libs/libmythtv/mythvideooutnull.cpp
M mythtv/libs/libmythtv/mythvideooutnull.h
M mythtv/libs/libmythtv/videoout_d3d.cpp
M mythtv/libs/libmythtv/videoout_d3d.h
Log Message:
-----------
tidy: Fix "argument looks like it might be swapped" in VideoOutXXX classes.
Align all the various MythVideoOutXXX::VideoInput function/overloads
to use the same parameter name "VideoAspect" for the third argument.
https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
Commit: 535344301d7d9e90849717b601c5810366b9176d
https://github.com/MythTV/mythtv/commit/535344301d7d9e90849717b601c5810366b9176d
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/programs/mythfilldatabase/xmltvparser.cpp
Log Message:
-----------
tidy: Fix two "argument looks like it might be swapped" warnings in xmltvparser.
Change a variable name from the generic "text2" to "name", to match the
parameter name in AddPerson.
https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
Commit: 021b6d590420165217fa77a75078c52e63bc9b00
https://github.com/MythTV/mythtv/commit/021b6d590420165217fa77a75078c52e63bc9b00
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/programs/mythfilldatabase/xmltvparser.cpp
Log Message:
-----------
tidy: Fix another "argument looks like it might be swapped" warning in xmltvparser.
Change a variable name from "role" to "character" to match the
parameter name in AddPerson. AddPerson uses the term "role" to
distinguish what a person does in a production (actor, director, etc.)
not which character they play if they have the role of "actor".
https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
Commit: ac736abbce41a5c69d7dd32d73c0bd2196417eeb
https://github.com/MythTV/mythtv/commit/ac736abbce41a5c69d7dd32d73c0bd2196417eeb
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/programs/mythcommflag/PrePostRollFlagger.h
Log Message:
-----------
tidy: Fix "argument looks like it might be swapped" in PrePostRollFlagger.
Fix a variable name in the declaration of findBreakInrange to match
the name used in the definition of the function.
https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
Commit: 4c7701cd493d7a3b67219c6a235d5df5b0fa917e
https://github.com/MythTV/mythtv/commit/4c7701cd493d7a3b67219c6a235d5df5b0fa917e
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/programs/mythbackend/services/dvr.cpp
Log Message:
-----------
tidy: Fix "argument looks like it might be swapped" in dvr.cpp.
Use a longer variable name (rsType -> recstatusType) so that the
checker has more characters to match between caller and callee names.
https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
Commit: 7625b741c6808a97b89a3ba7e05fa091cefc22bf
https://github.com/MythTV/mythtv/commit/7625b741c6808a97b89a3ba7e05fa091cefc22bf
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythbackend/scheduler.h
Log Message:
-----------
tidy: Fix "argument looks like it might be swapped" in scheduler.
Rename a variable in AddChildInput so that the paramaters are "parent"
and "child".
https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
Commit: eebaccec26ac9d8edde6f621cd5eabc92bf2d7fa
https://github.com/MythTV/mythtv/commit/eebaccec26ac9d8edde6f621cd5eabc92bf2d7fa
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M .clang-tidy
Log Message:
-----------
Redundant member initializations have been fixed.
Commit: 716568b6bc9204eeffe244d9994d6fc33d44ba4a
https://github.com/MythTV/mythtv/commit/716568b6bc9204eeffe244d9994d6fc33d44ba4a
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythplugins/mythmusic/mythmusic/playlist.cpp
Log Message:
-----------
Minor cleanups in (not compiled) CD writing code for previous work.
The CD writing code is compiled out with the ifdef CD_WRTITING_FIXED.
Temporarily enable this code and fix minor compiler errors due to
changes over the last year. This code needs major work to be
re-enabled, as the the old dialog code that it uses was removed in
2018.
Compare: https://github.com/MythTV/mythtv/compare/03855a81f83d...716568b6bc92
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Home: https://github.com/MythTV/mythtv
Commit: 89bf2a9d0cae7b200b1a29464d7ecb93a18572be
https://github.com/MythTV/mythtv/commit/89bf2a9d0cae7b200b1a29464d7ecb93a18572be
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/libs/libmythtv/videosource.cpp
Log Message:
-----------
clazy: Use 4-arg connect in videosource.
Clazy recommends using the 4-arg variant of Object::connect over the
3-arg version. The main reason for this is that the signal will not be
called if the target object has been deleted.
In this instance, it appears clear that the target object is the
current object, since the lambda is referencing variables in the
CardInput class.
https://github.com/KDE/clazy/blob/master/docs/checks/README-connect-3arg-lambda.md
Commit: 8277bf19a7d10b8f3ce7062c78c86bbe9e908627
https://github.com/MythTV/mythtv/commit/8277bf19a7d10b8f3ce7062c78c86bbe9e908627
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/programs/mythfrontend/globalsettings.cpp
Log Message:
-----------
clazy: Use 4-arg connect in globalsettings.
Clazy recommends using the 4-arg variant of Object::connect over the
3-arg version. The main reason for this is that the signal will not be
called if the target object has been deleted.
In this instance, the lambda doesn't really require an object since is
only calling static functions, and functions on a global object. Use
the sender object as the receiver, which should guarantee that the
receiver object is always valid.
https://github.com/KDE/clazy/blob/master/docs/checks/README-connect-3arg-lambda.md
Commit: 043640477ebd22d416d11dd8b1d38a2c7769f30b
https://github.com/MythTV/mythtv/commit/043640477ebd22d416d11dd8b1d38a2c7769f30b
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/libs/libmyth/mythcontext.cpp
Log Message:
-----------
tidy: Fix "argument looks like it might be swapped" warning in mythcorecontext.
Change the MythContextPrivate::Init argument names to match those of
MythContextPrivate::Init.
https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
Commit: 34f0950a9842c8cc67aaa82a5c08e1b13a5d466b
https://github.com/MythTV/mythtv/commit/34f0950a9842c8cc67aaa82a5c08e1b13a5d466b
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/libs/libmythtv/mythplayer.cpp
M mythtv/libs/libmythtv/mythvideooutgpu.cpp
M mythtv/libs/libmythtv/mythvideooutgpu.h
M mythtv/libs/libmythtv/mythvideooutnull.cpp
M mythtv/libs/libmythtv/mythvideooutnull.h
M mythtv/libs/libmythtv/videoout_d3d.cpp
M mythtv/libs/libmythtv/videoout_d3d.h
Log Message:
-----------
tidy: Fix "argument looks like it might be swapped" in VideoOutXXX classes.
Align all the various MythVideoOutXXX::VideoInput function/overloads
to use the same parameter name "VideoAspect" for the third argument.
https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
Commit: 535344301d7d9e90849717b601c5810366b9176d
https://github.com/MythTV/mythtv/commit/535344301d7d9e90849717b601c5810366b9176d
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/programs/mythfilldatabase/xmltvparser.cpp
Log Message:
-----------
tidy: Fix two "argument looks like it might be swapped" warnings in xmltvparser.
Change a variable name from the generic "text2" to "name", to match the
parameter name in AddPerson.
https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
Commit: 021b6d590420165217fa77a75078c52e63bc9b00
https://github.com/MythTV/mythtv/commit/021b6d590420165217fa77a75078c52e63bc9b00
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/programs/mythfilldatabase/xmltvparser.cpp
Log Message:
-----------
tidy: Fix another "argument looks like it might be swapped" warning in xmltvparser.
Change a variable name from "role" to "character" to match the
parameter name in AddPerson. AddPerson uses the term "role" to
distinguish what a person does in a production (actor, director, etc.)
not which character they play if they have the role of "actor".
https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
Commit: ac736abbce41a5c69d7dd32d73c0bd2196417eeb
https://github.com/MythTV/mythtv/commit/ac736abbce41a5c69d7dd32d73c0bd2196417eeb
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/programs/mythcommflag/PrePostRollFlagger.h
Log Message:
-----------
tidy: Fix "argument looks like it might be swapped" in PrePostRollFlagger.
Fix a variable name in the declaration of findBreakInrange to match
the name used in the definition of the function.
https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
Commit: 4c7701cd493d7a3b67219c6a235d5df5b0fa917e
https://github.com/MythTV/mythtv/commit/4c7701cd493d7a3b67219c6a235d5df5b0fa917e
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/programs/mythbackend/services/dvr.cpp
Log Message:
-----------
tidy: Fix "argument looks like it might be swapped" in dvr.cpp.
Use a longer variable name (rsType -> recstatusType) so that the
checker has more characters to match between caller and callee names.
https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
Commit: 7625b741c6808a97b89a3ba7e05fa091cefc22bf
https://github.com/MythTV/mythtv/commit/7625b741c6808a97b89a3ba7e05fa091cefc22bf
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythbackend/scheduler.h
Log Message:
-----------
tidy: Fix "argument looks like it might be swapped" in scheduler.
Rename a variable in AddChildInput so that the paramaters are "parent"
and "child".
https://clang.llvm.org/extra/clang-tidy/checks/readability-suspicious-call-argument.html
Commit: eebaccec26ac9d8edde6f621cd5eabc92bf2d7fa
https://github.com/MythTV/mythtv/commit/eebaccec26ac9d8edde6f621cd5eabc92bf2d7fa
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M .clang-tidy
Log Message:
-----------
Redundant member initializations have been fixed.
Commit: 716568b6bc9204eeffe244d9994d6fc33d44ba4a
https://github.com/MythTV/mythtv/commit/716568b6bc9204eeffe244d9994d6fc33d44ba4a
Author: David Hampton <mythtv@love2code.net>
Date: 2021-11-06 (Sat, 06 Nov 2021)
Changed paths:
M mythplugins/mythmusic/mythmusic/playlist.cpp
Log Message:
-----------
Minor cleanups in (not compiled) CD writing code for previous work.
The CD writing code is compiled out with the ifdef CD_WRTITING_FIXED.
Temporarily enable this code and fix minor compiler errors due to
changes over the last year. This code needs major work to be
re-enabled, as the the old dialog code that it uses was removed in
2018.
Compare: https://github.com/MythTV/mythtv/compare/03855a81f83d...716568b6bc92
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits