Mailing List Archive

[MythTV/mythtv] a2cf26: Check instance before starting EnableUDPListener
Branch: refs/heads/master
Home: https://github.com/MythTV/mythtv
Commit: a2cf263313e3db744cae4507f175982fbe26e8da
https://github.com/MythTV/mythtv/commit/a2cf263313e3db744cae4507f175982fbe26e8da
Author: Klaas de Waal <kdewaal@mythtv.org>
Date: 2021-06-22 (Tue, 22 Jun 2021)

Changed paths:
M mythtv/libs/libmythui/mythudplistener.cpp

Log Message:
-----------
Check instance before starting EnableUDPListener

When the database setting StartupScreenDelay is changed from 0 to another value
outside of mythfrontend, e.g. with manual sql commands or by switching to a restored
database, mythtv-setup and mythfrontend do crash after briefly showing the setup screen.
This is now fixed by checking both the thread and the instance pointer before
calling EnableUDPListener. If the check fails an error message is given.
As to why this happens, this is the bit of code around mythcontext.cpp:1652:
saveSettingsCache();
if (d->m_settingsCacheDirty)
{
DestroyMythMainWindow();
d->m_settingsCacheDirty = false;
}
gCoreContext->ActivateSettingsCache(true);
This bit of code is called when the setup screen is pulled down and before
the real main winow is created.
The DestroyMythMainWindow does delete the MythUDPListener instance.
The MythUDPListener is static which means it is never created again, causing
the creation of the real main window to fail when the UPDListener is started.


_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
[MythTV/mythtv] a2cf26: Check instance before starting EnableUDPListener [ In reply to ]
Branch: refs/heads/devel/http
Home: https://github.com/MythTV/mythtv
Commit: a2cf263313e3db744cae4507f175982fbe26e8da
https://github.com/MythTV/mythtv/commit/a2cf263313e3db744cae4507f175982fbe26e8da
Author: Klaas de Waal <kdewaal@mythtv.org>
Date: 2021-06-22 (Tue, 22 Jun 2021)

Changed paths:
M mythtv/libs/libmythui/mythudplistener.cpp

Log Message:
-----------
Check instance before starting EnableUDPListener

When the database setting StartupScreenDelay is changed from 0 to another value
outside of mythfrontend, e.g. with manual sql commands or by switching to a restored
database, mythtv-setup and mythfrontend do crash after briefly showing the setup screen.
This is now fixed by checking both the thread and the instance pointer before
calling EnableUDPListener. If the check fails an error message is given.
As to why this happens, this is the bit of code around mythcontext.cpp:1652:
saveSettingsCache();
if (d->m_settingsCacheDirty)
{
DestroyMythMainWindow();
d->m_settingsCacheDirty = false;
}
gCoreContext->ActivateSettingsCache(true);
This bit of code is called when the setup screen is pulled down and before
the real main winow is created.
The DestroyMythMainWindow does delete the MythUDPListener instance.
The MythUDPListener is static which means it is never created again, causing
the creation of the real main window to fail when the UPDListener is started.


Commit: e9452aabac2349b4e60434d1135bea90912170f4
https://github.com/MythTV/mythtv/commit/e9452aabac2349b4e60434d1135bea90912170f4
Author: Klaas de Waal <kdewaal@mythtv.org>
Date: 2021-06-22 (Tue, 22 Jun 2021)

Changed paths:
M mythtv/libs/libmythtv/frequencytables.cpp

Log Message:
-----------
US ATSC broadcast channel scan range 2-36

Following the spectrum repack in the US, which completed July 13, 2020 (exceptions
ceased broadcasting on the higher channels before October 7), ATSC channels 37 and
above are no longer used for TV broadcasts.
The ATSC broadcast channel scan range is therefore reduced from 2-51 to 2-36.

Refs #365


Commit: 5bd6c6a3d9bebd6c6e796205b167c37217373e26
https://github.com/MythTV/mythtv/commit/5bd6c6a3d9bebd6c6e796205b167c37217373e26
Author: Stuart Auchterlonie <stuarta@mythtv.org>
Date: 2021-06-23 (Wed, 23 Jun 2021)

Changed paths:
M mythtv/libs/libmythtv/frequencytables.cpp
M mythtv/libs/libmythui/mythudplistener.cpp

Log Message:
-----------
Merge branch 'master' into devel/http


Compare: https://github.com/MythTV/mythtv/compare/4fe4ff58f523...5bd6c6a3d9be
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits