Branch: refs/heads/master
Home: https://github.com/MythTV/mythtv
Commit: 6497d38bd46c4e56aa1ad064e9e6db24dfc3821d
https://github.com/MythTV/mythtv/commit/6497d38bd46c4e56aa1ad064e9e6db24dfc3821d
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-07 (Sat, 07 Nov 2020)
Changed paths:
M mythtv/libs/libmythtv/mpeg/mpegdescriptors.h
Log Message:
-----------
tidy: Use 'false' bool literal instead of zero.
Commit: fe0c3f6ae5f569b1abca990a2432bb7e77d7e0d1
https://github.com/MythTV/mythtv/commit/fe0c3f6ae5f569b1abca990a2432bb7e77d7e0d1
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-07 (Sat, 07 Nov 2020)
Changed paths:
A .clazy
Log Message:
-----------
Add initial clazy config file.
Commit: 14b7b8fe3ec988e77fb7114315a65106cd47f474
https://github.com/MythTV/mythtv/commit/14b7b8fe3ec988e77fb7114315a65106cd47f474
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-07 (Sat, 07 Nov 2020)
Changed paths:
M mythtv/libs/libmythtv/tv_play.cpp
Log Message:
-----------
clazy: Always pass an object to QTimer::singleShot.
This ensures that the lambda isn't executed after the context object
has been deleted.
Commit: fde41ce5f595fc47e4c40270b89ebec9eddfebd9
https://github.com/MythTV/mythtv/commit/fde41ce5f595fc47e4c40270b89ebec9eddfebd9
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-07 (Sat, 07 Nov 2020)
Changed paths:
M mythtv/libs/libmythtv/Bluray/mythbdbuffer.cpp
Log Message:
-----------
clazy: Fix "returning data from temporary" warning.
From clazy docs: Warns when returning the data from a `QByteArray`
that will soon be destroyed.
Fix this by continuing to use the QString version of the file name,
and only convert to a C string for the one function call that needs
it.
Commit: 86feefdcec5924f7ea87fca5b425d8dd5a92cd1c
https://github.com/MythTV/mythtv/commit/86feefdcec5924f7ea87fca5b425d8dd5a92cd1c
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-07 (Sat, 07 Nov 2020)
Changed paths:
M mythtv/libs/libmythbase/lcddevice.cpp
Log Message:
-----------
clazy: Fix "incorrect emit" warning.
From the clazy docs: For readability purposes you should always use
emit (or Q_EMIT) when calling a signal. Clazy will warn if you forget
to use emit (or Q_EMIT) or if you use them on a non-signal.
Clazy apparently wants the emit keyword to be on the same line as the
signal name that is being emitted, but in this case that causes the
clang-tidy "misleading indentation" warning to trigger because it sees
the file after it has been pre-processed and the emit keyword has been
removed. The compromise to make both happy is to use NOLINT to quiesce
the tidy warning.
Commit: 25e6687824662dba473e9a53400c2273f14ad8fc
https://github.com/MythTV/mythtv/commit/25e6687824662dba473e9a53400c2273f14ad8fc
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-07 (Sat, 07 Nov 2020)
Changed paths:
M mythplugins/mythmusic/mythmusic/editmetadata.h
Log Message:
-----------
clazy: Fix "overridding signal with signal" warning in editmetadata.cpp.
The EditAlbumartDialog defines an identical signal to its parent class
EditMetadataCommon. This extra signal is redundant and can be removed.
Compare: https://github.com/MythTV/mythtv/compare/428b90fc1e9b...25e668782466
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Home: https://github.com/MythTV/mythtv
Commit: 6497d38bd46c4e56aa1ad064e9e6db24dfc3821d
https://github.com/MythTV/mythtv/commit/6497d38bd46c4e56aa1ad064e9e6db24dfc3821d
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-07 (Sat, 07 Nov 2020)
Changed paths:
M mythtv/libs/libmythtv/mpeg/mpegdescriptors.h
Log Message:
-----------
tidy: Use 'false' bool literal instead of zero.
Commit: fe0c3f6ae5f569b1abca990a2432bb7e77d7e0d1
https://github.com/MythTV/mythtv/commit/fe0c3f6ae5f569b1abca990a2432bb7e77d7e0d1
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-07 (Sat, 07 Nov 2020)
Changed paths:
A .clazy
Log Message:
-----------
Add initial clazy config file.
Commit: 14b7b8fe3ec988e77fb7114315a65106cd47f474
https://github.com/MythTV/mythtv/commit/14b7b8fe3ec988e77fb7114315a65106cd47f474
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-07 (Sat, 07 Nov 2020)
Changed paths:
M mythtv/libs/libmythtv/tv_play.cpp
Log Message:
-----------
clazy: Always pass an object to QTimer::singleShot.
This ensures that the lambda isn't executed after the context object
has been deleted.
Commit: fde41ce5f595fc47e4c40270b89ebec9eddfebd9
https://github.com/MythTV/mythtv/commit/fde41ce5f595fc47e4c40270b89ebec9eddfebd9
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-07 (Sat, 07 Nov 2020)
Changed paths:
M mythtv/libs/libmythtv/Bluray/mythbdbuffer.cpp
Log Message:
-----------
clazy: Fix "returning data from temporary" warning.
From clazy docs: Warns when returning the data from a `QByteArray`
that will soon be destroyed.
Fix this by continuing to use the QString version of the file name,
and only convert to a C string for the one function call that needs
it.
Commit: 86feefdcec5924f7ea87fca5b425d8dd5a92cd1c
https://github.com/MythTV/mythtv/commit/86feefdcec5924f7ea87fca5b425d8dd5a92cd1c
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-07 (Sat, 07 Nov 2020)
Changed paths:
M mythtv/libs/libmythbase/lcddevice.cpp
Log Message:
-----------
clazy: Fix "incorrect emit" warning.
From the clazy docs: For readability purposes you should always use
emit (or Q_EMIT) when calling a signal. Clazy will warn if you forget
to use emit (or Q_EMIT) or if you use them on a non-signal.
Clazy apparently wants the emit keyword to be on the same line as the
signal name that is being emitted, but in this case that causes the
clang-tidy "misleading indentation" warning to trigger because it sees
the file after it has been pre-processed and the emit keyword has been
removed. The compromise to make both happy is to use NOLINT to quiesce
the tidy warning.
Commit: 25e6687824662dba473e9a53400c2273f14ad8fc
https://github.com/MythTV/mythtv/commit/25e6687824662dba473e9a53400c2273f14ad8fc
Author: David Hampton <mythtv@love2code.net>
Date: 2020-11-07 (Sat, 07 Nov 2020)
Changed paths:
M mythplugins/mythmusic/mythmusic/editmetadata.h
Log Message:
-----------
clazy: Fix "overridding signal with signal" warning in editmetadata.cpp.
The EditAlbumartDialog defines an identical signal to its parent class
EditMetadataCommon. This extra signal is redundant and can be removed.
Compare: https://github.com/MythTV/mythtv/compare/428b90fc1e9b...25e668782466
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits