Mailing List Archive: Ticket #13626: Allow the image viewer to handle symlinks

Ticket #13626: Allow the image viewer to handle symlinks

May 25, 2020, 4:25 PM

Post #1 of 3 (239 views)

#13626: Allow the image viewer to handle symlinks
----------------------------------+--------------------------
Reporter: jwhite66 | Owner: (none)
Type: Patch - Bug Fix | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - General | Version: Unspecified
Severity: medium | Keywords:
Ticket locked: 0 |
----------------------------------+--------------------------
A valuable use case for me, personally, is to have my images organized
stored based on how they were acquired, but then write scripts to organize
them more systematically, with symlinks back to the source files.

The current code prevents that by ignoring symbolic links. That choice
has existed since commit f3ba1b37c4c6db470bf21dcb54f77cd949777f63 in 2013
which originated this function afaict. It's not clear to me if ignoring
symlinks solves a problem or was just chosen arbitrarily. The videos
viewer works fine with symlinks, so this makes the gallery more in step
with video files.

The change is trivial, and appears to work in my testing. A pull request
has been created for this as well.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13626>
MythTV <http://www.mythtv.org>
MythTV Media Center

Re: Ticket #13626: Allow the image viewer to handle symlinks [ In reply to ]

noreply at mythtv

Jun 19, 2020, 10:46 AM

Post #2 of 3 (220 views)

Permalink

Re: Ticket #13626: Allow the image viewer to handle symlinks [ In reply to ]

noreply at mythtv

Sep 7, 2021, 12:37 PM

Post #3 of 3 (171 views)

Permalink

#13626: Allow the image viewer to handle symlinks
------------------------------+------------------------------
Reporter: jwhite66 | Owner: (none)
Type: Patch - Bug Fix | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - General | Version: Unspecified
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
------------------------------+------------------------------

Comment (by Klaas de Waal):

The filter option setting appears to have moved to
libs/libmythmetadata/imagemanager.cpp:320-323 in today's master:

{{{
// Apply filters to only detect image files
m_dirFilter.setNameFilters(glob);
m_dirFilter.setFilter(QDir::AllDirs | QDir::Files | QDir::Readable |
QDir::NoDotAndDotDot | QDir::NoSymLinks);
}}}

Removing the QDir::NoSymLinks option is indeed trivial and is worth a try.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13626#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center