Mailing List Archive

Ticket #13612: UPNP: Fix resource duration
#13612: UPNP: Fix resource duration
--------------------------------------+--------------------------
Reporter: Nigel Jewell | Owner: dblain
Type: Bug Report - General | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - UPnP | Version: v31-fixes
Severity: medium | Keywords:
Ticket locked: 0 |
--------------------------------------+--------------------------
In commit 77b560f3cc100717729ed1836367e57ff16c7eb6 a bug was introduced in
{{{QString resDurationFormat(uint32_t msec)}}}.

The format string of {{{"%01u:%02u:%02u.%01u"}}} should be
{{{"%1:%2:%3.%4"}}}.

It's been subsequently resolved in
c47ae6d443ddd2e305ee862e616e5ad0b0b46509 by removing the need for that
format string.

Could this change be also merged into fixes/31? At present
resDurationFormat is providing incorrect data to the UPnP client.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13612>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13612: UPNP: Fix resource duration [ In reply to ]
#13612: UPNP: Fix resource duration
----------------------------------+-------------------------------
Reporter: Nigel Jewell | Owner: David Hampton
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 31.1
Component: MythTV - UPnP | Version: v31-fixes
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+-------------------------------
Changes (by David Hampton):

* owner: dblain => David Hampton
* status: new => assigned
* milestone: needs_triage => 31.1


--
Ticket URL: <https://code.mythtv.org/trac/ticket/13612#comment:1>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13612: UPNP: Fix resource duration [ In reply to ]
#13612: UPNP: Fix resource duration
----------------------------------+-------------------------------
Reporter: Nigel Jewell | Owner: David Hampton
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 31.1
Component: MythTV - UPnP | Version: v31-fixes
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+-------------------------------

Comment (by Nigel Jewell):

I see this has been fixed in
https://github.com/MythTV/mythtv/commit/5f1993304e35042192aed059dd7cf8717b76c6a7.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13612#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13612: UPNP: Fix resource duration [ In reply to ]
#13612: UPNP: Fix resource duration
----------------------------------+-------------------------------
Reporter: Nigel Jewell | Owner: David Hampton
Type: Bug Report - General | Status: closed
Priority: minor | Milestone: 31.1
Component: MythTV - UPnP | Version: v31-fixes
Severity: medium | Resolution: fixed
Keywords: | Ticket locked: 0
----------------------------------+-------------------------------
Changes (by David Hampton <mythtv@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"5f1993304e35042192aed059dd7cf8717b76c6a7/mythtv"
5f1993304/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="5f1993304e35042192aed059dd7cf8717b76c6a7"
Fix incorrect data provided to UPnP client.

This bug was introduced in 77b560f3cc when converting from the
obsolete QString::sprintf function to typical QString formatting using
QString::arg. In one case the arguments were all converted, but the
format string wasn't . Fix that format string.

Fixes #13612.
}}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13612#comment:3>
MythTV <http://www.mythtv.org>
MythTV Media Center