Mailing List Archive

1 2  View All
Re: Ticket #13548: Video aspect ratio wrong with mythfrontend in window [ In reply to ]
#13548: Video aspect ratio wrong with mythfrontend in window
----------------------------------+------------------------------
Reporter: Klaas de Waal | Owner: mark-kendall
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+------------------------------

Comment (by mark-kendall):

Klaas - can you test with latest master.

This should be working properly now - by which I mean you should override
the display aspect ratio in Setup->Appearance->Theme/Screen
Settings->Screen aspect ratio

You can of course still override the EDID.

see a4aad255a7d

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13548#comment:16>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13548: Video aspect ratio wrong with mythfrontend in window [ In reply to ]
#13548: Video aspect ratio wrong with mythfrontend in window
----------------------------------+------------------------------
Reporter: Klaas de Waal | Owner: mark-kendall
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+------------------------------

Comment (by Klaas de Waal):

Problem solved!! The display is correct, the video does now once again
exactly fills the window. Note that this is with the "Screen aspect ratio"
to "Auto" and without a user-defined EDID.

FIY, the output of "mythfrontend -v playback" is attached.

Thanks!

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13548#comment:17>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13548: Video aspect ratio wrong with mythfrontend in window [ In reply to ]
#13548: Video aspect ratio wrong with mythfrontend in window
----------------------------------+------------------------------
Reporter: Klaas de Waal | Owner: mark-kendall
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+------------------------------
Changes (by Klaas de Waal):

* Attachment "mf-20200114-2208.log" added.

Output of mythfrontend -v playback with today's master, the video aspect
ratio now correct.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13548>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13548: Video aspect ratio wrong with mythfrontend in window [ In reply to ]
#13548: Video aspect ratio wrong with mythfrontend in window
----------------------------------+------------------------------
Reporter: Klaas de Waal | Owner: mark-kendall
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+------------------------------

Comment (by Mark Kendall <mark.kendall@…>):

In [changeset:"aeb97c5d2ebf3e097c65c783a6311338bf9c5f83/mythtv"
aeb97c5d2e/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="aeb97c5d2ebf3e097c65c783a6311338bf9c5f83"
MythVideoOutput: Fix a regression with windowed aspect ratio

Refs #13548
Refs #13560
}}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13548#comment:18>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13548: Video aspect ratio wrong with mythfrontend in window [ In reply to ]
#13548: Video aspect ratio wrong with mythfrontend in window
----------------------------------+------------------------------
Reporter: Klaas de Waal | Owner: mark-kendall
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+------------------------------

Comment (by Klaas de Waal):

With today's master, I do need to set the "Screen aspect ratio" to 16:10
in order to get a video that exactly fills the window.
This is OK for me.

It would however IMHO be an improvement if the default setting would be
correct for a display with square pixels. I have never seen a display with
non-square pixels since the days of the standard-definition 16:9 plasma
TV's.

According to the Wikipedia page
https://en.wikipedia.org/wiki/Pixel_aspect_ratio

''In modern digital imaging systems and high-definition televisions,
especially those that comply with SMPTE standards and practices, only
square pixels are used for broadcast and display.''

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13548#comment:19>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13548: Video aspect ratio wrong with mythfrontend in window [ In reply to ]
#13548: Video aspect ratio wrong with mythfrontend in window
----------------------------------+------------------------------
Reporter: Klaas de Waal | Owner: mark-kendall
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+------------------------------

Comment (by jpilk):

FWIW I have just tried this again with 11b8d0ae and 0d3bb8787d, commits
from yesterday and today. Both gave correct geometry and placement in the
window and on the TV with either 'auto' or '16:10', for both SD and HD
testcards, as in #13560. Other aspect-ratio settings that I tried didn't
correctly fill the window.

Both screens have square pixels, and the monitor (Dell 2009W VGA-0,
Primary display) is 1680 x 1050, ie 16:10

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13548#comment:20>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13548: Video aspect ratio wrong with mythfrontend in window [ In reply to ]
#13548: Video aspect ratio wrong with mythfrontend in window
----------------------------------+------------------------------
Reporter: Klaas de Waal | Owner: mark-kendall
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+------------------------------

Comment (by mark-kendall):

Replying to [comment:19 Klaas de Waal]:
> With today's master, I do need to set the "Screen aspect ratio" to 16:10
in order to get a video that exactly fills the window.
> This is OK for me.

Sorry Klaas - doing a little catchup on tickets/emails:)

I didn't expect it expect it to work without overriding the aspect ratio
when you previously said it was fixed. The fix should have forced you to
override - but your comments and feedback from John pointed me to an
oversight that was subsequently corrected in
https://code.mythtv.org/trac/changeset/aeb97c5d2ebf3e097c65c783a6311338bf9c5f83/mythtv

If that makes sense.

> It would however IMHO be an improvement if the default setting would be
correct for a display with square pixels. I have never seen a display with
non-square pixels since the days of the standard-definition 16:9 plasma
TV's.

I'll give this a little thought. It's a fairly trivial fix if we went down
that route - and it does make sense.

I am however wary of the type of display that reports separate display
modes for 'desktop' vs 'video' usage. So for example my spare monitor is
1680x1050 native (16:10 aspect) but also has, for example, 1920x1080
display modes where the output is letterboxed (and overscanned).

I'll do a little testing to check.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13548#comment:21>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13548: Video aspect ratio wrong with mythfrontend in window [ In reply to ]
#13548: Video aspect ratio wrong with mythfrontend in window
----------------------------------+------------------------------
Reporter: Klaas de Waal | Owner: mark-kendall
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+------------------------------

Comment (by mark-kendall):

Replying to [comment:20 jpilk]:
> FWIW I have just tried this again with 11b8d0ae and 0d3bb8787d, commits
from yesterday and today. Both gave correct geometry and placement in the
window and on the TV with either 'auto' or '16:10', for both SD and HD
testcards, as in #13560. Other aspect-ratio settings that I tried didn't
correctly fill the window.

John - to be clear - when you say 'didn't correctly fill the window' -
presumably you weren't expecting them to?

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13548#comment:22>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13548: Video aspect ratio wrong with mythfrontend in window [ In reply to ]
#13548: Video aspect ratio wrong with mythfrontend in window
----------------------------------+------------------------------
Reporter: Klaas de Waal | Owner: mark-kendall
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+------------------------------

Comment (by jpilk):

Right. It's good with auto or the setting appropriate to the monitor,
which in this case has square pixels; not (as) good with other settings.
Once upon a time that value seemed to make no difference.

Most logs that get pasted show problems. I'm not sure that this is yet
finished, but if nothing gets broken in the meantime it might be a good
idea to post one that has worked.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13548#comment:23>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13548: Video aspect ratio wrong with mythfrontend in window [ In reply to ]
#13548: Video aspect ratio wrong with mythfrontend in window
----------------------------------+------------------------------
Reporter: Klaas de Waal | Owner: mark-kendall
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+------------------------------

Comment (by mark-kendall):

Replying to [comment:23 jpilk]:
> Right. It's good with auto or the setting appropriate to the monitor,
which in this case has square pixels; not (as) good with other settings.

It's not as good with other settings because you are telling the code you
have a different aspect ratio - it should look broken.

> Once upon a time that value seemed to make no difference.

It was changed two weeks ago.

https://github.com/MythTV/mythtv/commit/a4aad255a7d9259f6c35ac2e8aa955067170d0f8

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13548#comment:24>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13548: Video aspect ratio wrong with mythfrontend in window [ In reply to ]
#13548: Video aspect ratio wrong with mythfrontend in window
----------------------------------+------------------------------
Reporter: Klaas de Waal | Owner: mark-kendall
Type: Bug Report - General | Status: closed
Priority: minor | Milestone: 31.1
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution: Fixed
Keywords: | Ticket locked: 0
----------------------------------+------------------------------
Changes (by Klaas de Waal):

* status: assigned => closed
* resolution: => Fixed


Comment:

Problem is fixed, ticket closed now.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13548#comment:26>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13548: Video aspect ratio wrong with mythfrontend in window [ In reply to ]
#13548: Video aspect ratio wrong with mythfrontend in window
----------------------------------+------------------------------
Reporter: Klaas de Waal | Owner: mark-kendall
Type: Bug Report - General | Status: closed
Priority: minor | Milestone: 31.1
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution: Fixed
Keywords: | Ticket locked: 0
----------------------------------+------------------------------

Comment (by Mark Kendall <mark.kendall@…>):

In [changeset:"33fa19e50111cb2b85726645770b331d4c46af51/mythtv"
33fa19e50/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="33fa19e50111cb2b85726645770b331d4c46af51"
MythDisplay: Assume 'square pixels' for default display aspect
ratio
calculation

- the default (for new installations) now assumes display pixels are
square (i.e. have an aspect ratio of 1) - which means we can calculate
the display aspect ratio from the resolution (which was previously a
fallback).
- behaviour for existing installations will be unchanged
- square pixels are now the norm for the vast majority of displays and
using the screen resolution to calculate the aspect ratio avoids small
rounding errors from using the EDID and incorrect aspect ratios from
broken/misleading EDIDs.
- refs #13548
}}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13548#comment:27>
MythTV <http://www.mythtv.org>
MythTV Media Center

1 2  View All