Mailing List Archive

Ticket #13215: Patch for Finnish EIT weirdness
#13215: Patch for Finnish EIT weirdness
----------------------------------+--------------------------
Reporter: dag@… | Owner:
Type: Patch - Feature | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - General | Version: Unspecified
Severity: medium | Keywords: Finnish EIT
Ticket locked: 0 |
----------------------------------+--------------------------
Finnish EIT info for most channels will have an added (<age limit>) at the
end of the title.
Additionally this can change between different episodes.
This is very bad for scheduling and I created a patch for eitfixup to
remove this.

The patch also removes the disturbing Film: or Elokuva: that is used in
the title of some movies and makes it really hard to find them later in
the listings.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13215>
MythTV <http://www.mythtv.org>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #13215: Patch for Finnish EIT weirdness [ In reply to ]
#13215: Patch for Finnish EIT weirdness
------------------------------+------------------------------
Reporter: dag@… | Owner:
Type: Patch - Feature | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - General | Version: Unspecified
Severity: medium | Resolution:
Keywords: Finnish EIT | Ticket locked: 0
------------------------------+------------------------------
Changes (by dag@…):

Attachment "finnish-eit.patch" added

https://code.mythtv.org/trac/raw-attachment/ticket/13215/finnish-eit.patch

Patch for eitfixup fixing Finnish EIT

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13215>
MythTV <http://www.mythtv.org>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #13215: Patch for Finnish EIT weirdness [ In reply to ]
#13215: Patch for Finnish EIT weirdness
------------------------------+------------------------------
Reporter: dag@… | Owner:
Type: Patch - Feature | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - General | Version: Unspecified
Severity: medium | Resolution:
Keywords: Finnish EIT | Ticket locked: 0
------------------------------+------------------------------
Changes (by dag@…):

Attachment "finnish-eit.2.patch" added

https://code.mythtv.org/trac/raw-attachment/ticket/13215/finnish-eit.2.patch

Fixed patch

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13215>
MythTV <http://www.mythtv.org>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #13215: Patch for Finnish EIT weirdness [ In reply to ]
#13215: Patch for Finnish EIT weirdness
------------------------------+------------------------------
Reporter: dag@… | Owner:
Type: Patch - Feature | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - General | Version: Unspecified
Severity: medium | Resolution:
Keywords: Finnish EIT | Ticket locked: 0
------------------------------+------------------------------

Comment (by dag@…):

Fxed the patch not to react to a year in parenthesis at the end of the
title

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13215#comment:1>
MythTV <http://www.mythtv.org>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #13215: Patch for Finnish EIT weirdness [ In reply to ]
#13215: Patch for Finnish EIT weirdness
------------------------------+------------------------------
Reporter: dag@… | Owner:
Type: Patch - Feature | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - General | Version: Unspecified
Severity: medium | Resolution:
Keywords: Finnish EIT | Ticket locked: 0
------------------------------+------------------------------

Comment (by dag@…):

Still modified the regexp not even to accept (1T) nor (1S).

This is as good as we can get.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13215#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #13215: Patch for Finnish EIT weirdness [ In reply to ]
#13215: Patch for Finnish EIT weirdness
------------------------------+------------------------------
Reporter: dag@… | Owner:
Type: Patch - Feature | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - General | Version: Unspecified
Severity: medium | Resolution:
Keywords: Finnish EIT | Ticket locked: 0
------------------------------+------------------------------
Changes (by dag@…):

Attachment "eitfixup.cpp.diff" added

https://code.mythtv.org/trac/raw-attachment/ticket/13215/eitfixup.cpp.diff

FIx for too loose regexp

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13215>
MythTV <http://www.mythtv.org>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #13215: Patch for Finnish EIT weirdness [ In reply to ]
#13215: Patch for Finnish EIT weirdness
------------------------------+------------------------------
Reporter: dag@… | Owner:
Type: Patch - Feature | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - General | Version: Unspecified
Severity: medium | Resolution:
Keywords: Finnish EIT | Ticket locked: 0
------------------------------+------------------------------
Changes (by dag@…):

Attachment "finnish-eit.3.patch" added

https://code.mythtv.org/trac/raw-attachment/ticket/13215/finnish-eit.3.patch

Sorry, wrong file uploaded disregard previous one. This is the real one

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13215>
MythTV <http://www.mythtv.org>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #13215: Patch for Finnish EIT weirdness [ In reply to ]
#13215: Patch for Finnish EIT weirdness
------------------------------+---------------------------
Reporter: dag@… | Owner:
Type: Patch - Feature | Status: new
Priority: minor | Milestone: 29.2
Component: MythTV - General | Version: v29-fixes
Severity: medium | Resolution:
Keywords: Finnish EIT | Ticket locked: 0
------------------------------+---------------------------
Changes (by stuarta):

* version: Unspecified => v29-fixes
* milestone: needs_triage => 29.2


--
Ticket URL: <https://code.mythtv.org/trac/ticket/13215#comment:3>
MythTV <http://www.mythtv.org>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #13215: Patch for Finnish EIT weirdness [ In reply to ]
#13215: Patch for Finnish EIT weirdness
------------------------------+---------------------------
Reporter: dag@… | Owner: (none)
Type: Patch - Feature | Status: new
Priority: minor | Milestone: 29.2
Component: MythTV - General | Version: v29-fixes
Severity: medium | Resolution:
Keywords: Finnish EIT | Ticket locked: 0
------------------------------+---------------------------

Comment (by dagnygren):

Just check out 0.30-fixes and had to reapply this patch. Could someone
commit it please?

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13215#comment:4>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13215: Patch for Finnish EIT weirdness [ In reply to ]
#13215: Patch for Finnish EIT weirdness
------------------------------+---------------------------
Reporter: dag@… | Owner: (none)
Type: Patch - Feature | Status: new
Priority: minor | Milestone: 29.2
Component: MythTV - General | Version: v29-fixes
Severity: medium | Resolution:
Keywords: Finnish EIT | Ticket locked: 0
------------------------------+---------------------------

Comment (by Jarno Suni):

I think "Elokuva:" (or "Film:", which I did not find examples of) can
help in finding films in listings by Mythtv frontend and by Kodi (which
has more advanced program search). BTW Yle channels use "Kino:", "Kino
Suomi:" and "Uusi Kino:" How would you distinguish movies from series and
other programs without such prefixes? I think duplicate matching could be
improved to be more flexible by allowing some editing of fields by user
defined regular expressions before comparing them.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13215#comment:5>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13215: Patch for Finnish EIT weirdness [ In reply to ]
#13215: Patch for Finnish EIT weirdness
------------------------------+---------------------------
Reporter: dag@… | Owner: (none)
Type: Patch - Feature | Status: new
Priority: minor | Milestone: 29.2
Component: MythTV - General | Version: v29-fixes
Severity: medium | Resolution:
Keywords: Finnish EIT | Ticket locked: 0
------------------------------+---------------------------

Comment (by dagnygren):

1. Film or Elokuva depends on your language settings as we have two
official languages in Finland

2. A title is a title in my opinion and should not be messed with by the
broadcaster. There is a category in the EIT (and in Mythtv) that should be
used for telling if it is a series or a movie - And a lot of other things,
but the broadcasters in Finland doesn't seem aware of it. There is also a
unique ID in there, but that also to have been overlooked as it is empty
in Finland.What we might be able to do is to force the category to Movie
when we see these weird additions to the title. Feel free to expand the
patch! And I might also expand it with the Kino-stuff when it starts
irritating me enough ;-)

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13215#comment:6>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13215: Patch for Finnish EIT weirdness [ In reply to ]
#13215: Patch for Finnish EIT weirdness
------------------------------+------------------------------------
Reporter: dag@… | Owner: Dag Nygren <dag@…>
Type: Patch - Feature | Status: closed
Priority: minor | Milestone: 29.2
Component: MythTV - General | Version: v29-fixes
Severity: medium | Resolution: fixed
Keywords: Finnish EIT | Ticket locked: 0
------------------------------+------------------------------------
Changes (by Dag Nygren <dag@…>):

* owner: (none) => Dag Nygren <dag@…>
* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"753a062b10d93485830a4dbf7a52d8336e2edf96/mythtv"
753a062b1/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="753a062b10d93485830a4dbf7a52d8336e2edf96"
Update Finish EIT fixups.

1) Remove 'Film' or 'Elokuva' at the start of titles. 2) Remove age
limit at the end of the title.

Fixes #13215.

Signed-off-by: David Hampton <mythtv@love2code.net>
}}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13215#comment:7>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13215: Patch for Finnish EIT weirdness [ In reply to ]
#13215: Patch for Finnish EIT weirdness
------------------------------+------------------------------------
Reporter: dag@… | Owner: Dag Nygren <dag@…>
Type: Patch - Feature | Status: closed
Priority: minor | Milestone: 29.2
Component: MythTV - General | Version: v29-fixes
Severity: medium | Resolution: fixed
Keywords: Finnish EIT | Ticket locked: 0
------------------------------+------------------------------------

Comment (by Dag Nygren <dag@…>):

In [changeset:"4d995941851b277b6365fed4ea003b8706432c2d/mythtv"
4d9959418/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="4d995941851b277b6365fed4ea003b8706432c2d"
Update Finish EIT fixups.

1) Remove 'Film' or 'Elokuva' at the start of titles. 2) Remove age
limit at the end of the title.

Fixes #13215.

Signed-off-by: David Hampton <mythtv@love2code.net>
(cherry picked from commit 753a062b10d93485830a4dbf7a52d8336e2edf96)
}}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13215#comment:8>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13215: Patch for Finnish EIT weirdness [ In reply to ]
#13215: Patch for Finnish EIT weirdness
------------------------------+------------------------------------
Reporter: dag@… | Owner: Dag Nygren <dag@…>
Type: Patch - Feature | Status: closed
Priority: minor | Milestone: 29.2
Component: MythTV - General | Version: v29-fixes
Severity: medium | Resolution: fixed
Keywords: Finnish EIT | Ticket locked: 0
------------------------------+------------------------------------

Comment (by Jarno Suni):

Now how do you search for upcoming films in those Finnish channels? Many
series are listed as films in parenthesis in guide. Can you still see the
age limit on guide, for example?

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13215#comment:9>
MythTV <http://www.mythtv.org>
MythTV Media Center