Mailing List Archive

Ticket #10894: Enable mythconfirmation dialog to pause playback
#10894: Enable mythconfirmation dialog to pause playback
-----------------------------------------+---------------------------------
Reporter: Tobias Maier <diespambox@…> | Type: Patch - Feature
Status: new | Priority: minor
Milestone: unknown | Component: MythTV -
Version: Master Head | General
Keywords: | Severity: medium
| Ticket locked: 0
-----------------------------------------+---------------------------------
First patch (Enable-mythconfirmation-dialog-to-pause-playback.patch)
enhances the behavior of the MythConfirmationDialog during playback: If a
MythUserMessage with ExtraData set to "pauseplayback" (instead of a
timeout) is received while in playback, playback is paused until the
dialog is dissmissed.

The second patch (add-network-control-command-message_pause.patch) adds
the network control command "message_pause" which uses the feature
introduce in the first patch. I'm not really happy with the command name,
but i did not want to change the syntax of "message" because i think this
would break a lot of peoples scripts...

Both patches were created against the master branch.

Since i don't know what's the preferred way to submit patches here are the
patches as commits on github:

Enable-mythconfirmation-dialog-to-pause-playback.patch:

https://github.com/tobser/mythtv/commit/238d243481669fc54011db7bc939268d1b6390df

add-network-control-command-message_pause.patch:

https://github.com/tobser/mythtv/commit/35b707d55bf13557fc64a1b89150318dec9acf95

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10894>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://www.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #10894: Enable mythconfirmation dialog to pause playback [ In reply to ]
#10894: Enable mythconfirmation dialog to pause playback
-----------------------------------------+-----------------------------
Reporter: Tobias Maier <diespambox@…> | Owner:
Type: Patch - Feature | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
-----------------------------------------+-----------------------------

Comment (by Tobias Maier <diespambox@…>):

sorry but i was somehow tricked by the merge... and broke the OSD menu.
0001-fix-osd-menu-broken-in-commit-238d243481669fc54011db.patch fixes the
OSD menu.

https://github.com/tobser/mythtv/commit/80cdcf545ff37cb2285775f91abc540a958b70ce

I'm sorry for the mess...

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10894#comment:1>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://www.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #10894: Enable mythconfirmation dialog to pause playback [ In reply to ]
#10894: Enable mythconfirmation dialog to pause playback
-----------------------------------------+-----------------------------
Reporter: Tobias Maier <diespambox@…> | Owner: (none)
Type: Patch - Feature | Status: closed
Priority: minor | Milestone: unknown
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution: Won't Fix
Keywords: | Ticket locked: 0
-----------------------------------------+-----------------------------
Changes (by Stuart Auchterlonie):

* status: new => closed
* resolution: => Won't Fix


Comment:

Closing old tickets.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/10894#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center