Mailing List Archive

Ticket #8774: Store channel type in database
#8774: Store channel type in database
------------------------------------------+---------------------------------
Reporter: stuarta | Owner: stuarta
Type: task | Status: new
Priority: minor | Milestone: 0.25
Component: MythTV - Channel Scanner | Version: Trunk Head
Severity: medium | Keywords:
Ticket locked: 0 |
------------------------------------------+---------------------------------
Store channel type (TV/Radio/Data etc)
into database when we find that information
during channel scanning.

This information can then be leveraged in
other areas, such as when setting up a
recorder and the type of streams it expects
to find.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8774>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-------------------------------------
Reporter: stuarta | Owner: stuarta
Type: task | Status: assigned
Priority: minor | Milestone: 0.25
Component: MythTV - Channel Scanner | Version: Trunk Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
--------------------------------------+-------------------------------------
Changes (by stuarta):

* status: new => assigned


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8774#comment:1>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-------------------------------------
Reporter: stuarta | Owner: stuarta
Type: task | Status: assigned
Priority: minor | Milestone: 0.25
Component: MythTV - Channel Scanner | Version: Trunk Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
--------------------------------------+-------------------------------------

Comment (by gillessoixantequatorze@…):

in the same time, is it possible to have the HDTV channel statut ?

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8774#comment:2>
MythTV <http://www.mythtv.org/>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-----------------------------
Reporter: stuarta | Owner: stuarta
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 0.25
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
--------------------------------------+-----------------------------
Changes (by stuartm):

* type: task => Developer Task


Comment:

This seems like an interesting and very simple addition, one for 0.26
maybe?

--
Ticket URL: <http://code.mythtv.org/trac/ticket/8774#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://www.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-----------------------------
Reporter: stuarta | Owner: stuarta
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 0.26
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
--------------------------------------+-----------------------------
Changes (by stuarta):

* milestone: 0.25 => 0.26


Comment:

Yes, its a good one for 0.26.
Fixing the milestone

--
Ticket URL: <http://code.mythtv.org/trac/ticket/8774#comment:4>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://www.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-----------------------------
Reporter: stuarta | Owner: stuarta
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 0.27
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
--------------------------------------+-----------------------------
Changes (by kenni):

* milestone: 0.26 => 0.27


--
Ticket URL: <http://code.mythtv.org/trac/ticket/8774#comment:5>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://www.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-----------------------------
Reporter: stuarta | Owner: stuarta
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 0.28
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
--------------------------------------+-----------------------------
Changes (by paulh):

* milestone: 0.27 => 0.28


--
Ticket URL: <http://code.mythtv.org/trac/ticket/8774#comment:6>
MythTV <http://www.mythtv.org>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://www.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-----------------------------
Reporter: stuarta | Owner: stuarta
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 0.28
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: schemachange | Ticket locked: 0
--------------------------------------+-----------------------------
Changes (by dekarl):

* keywords: => schemachange


Comment:

I'd love to see us store the SD/HD/UHD/3D part of the service type, too.
My plan is to use it in MFDB for a fixup similar to FixHD on EIT.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/8774#comment:7>
MythTV <http://www.mythtv.org>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+------------------------------------
Reporter: Stuart Auchterlonie | Owner: Stuart
| Auchterlonie
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 29.2
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: schemachange | Ticket locked: 0
--------------------------------------+------------------------------------

Comment (by Klaas de Waal):

This would be useful to setup the buffering parameters for Live TV/Radio.
At the moment the Live TV is setup for 8Mbit/s for all channels. This is
OK for TV but for radio/audio-only channels a much lower setting would be
better.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/8774#comment:13>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-------------------------------
Reporter: Stuart Auchterlonie | Owner: Klaas de Waal
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: schemachange | Ticket locked: 0
--------------------------------------+-------------------------------
Changes (by Stuart Auchterlonie):

* owner: Stuart Auchterlonie => Klaas de Waal
* milestone: 29.2 => 31.0


Comment:

Klaas you are welcome to do this.

Regards
Stuart

--
Ticket URL: <https://code.mythtv.org/trac/ticket/8774#comment:14>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-------------------------------
Reporter: Stuart Auchterlonie | Owner: Klaas de Waal
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: schemachange | Ticket locked: 0
--------------------------------------+-------------------------------

Comment (by Klaas de Waal):

It looks like the best value to use for channel type is the service_type
as described in the DVB Bluebook A038, Feb 2019, pages 82 and 83. The way
to do this is to extend database table channel with a field service_type
and copy the service_type into this field when found during the channel
scan.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/8774#comment:15>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-------------------------------
Reporter: Stuart Auchterlonie | Owner: Klaas de Waal
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: schemachange | Ticket locked: 0
--------------------------------------+-------------------------------

Comment (by Stuart Auchterlonie):

Klass, this just needs a DB schema update to add an appropriate column,
and then the code as you mention to store the relevant info

--
Ticket URL: <https://code.mythtv.org/trac/ticket/8774#comment:16>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-------------------------------
Reporter: Stuart Auchterlonie | Owner: Klaas de Waal
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: schemachange | Ticket locked: 0
--------------------------------------+-------------------------------

Comment (by Klaas de Waal):

Column service_type is added to database table channel in commit
8ae1c0b7958f3693ca4361bc9d116e55958a47ad which bumps the database schema
version to 1352.

The code to retrieve and store the data as described in comment:15 is
added in commit c7ad89a7eb999982c702eda9347603a9a7a1f532.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/8774#comment:17>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-------------------------------
Reporter: Stuart Auchterlonie | Owner: Klaas de Waal
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: schemachange | Ticket locked: 0
--------------------------------------+-------------------------------

Comment (by Klaas de Waal <kdewaal@…>):

In [changeset:"8ae1c0b7958f3693ca4361bc9d116e55958a47ad/mythtv"
8ae1c0b79/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="8ae1c0b7958f3693ca4361bc9d116e55958a47ad"
Update database schema to version 1352

Revert type change in update to version 1351, part of
commit 6f876b31e9e1a3dbc4f1ef3a27d58f25daacae07
In update to version 1352:
- change type of region_id and bouquet_id from int to unsigned int
- add service_type to table channel for ticket #8774
- change schema version number to 1352

Refs #8774
}}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/8774#comment:18>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-------------------------------
Reporter: Stuart Auchterlonie | Owner: Klaas de Waal
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: schemachange | Ticket locked: 0
--------------------------------------+-------------------------------

Comment (by Klaas de Waal <klaas@…>):

In [changeset:"bba208158d18c7c613085f48f3e7bdd3c75b692e/mythtv"
bba208158/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="bba208158d18c7c613085f48f3e7bdd3c75b692e"
Support for channel service_type in services API

Add support for service_type in the C++ code of the services API.
Partial support added for perl, python and php bindings.

Refs #8774
}}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/8774#comment:19>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-------------------------------
Reporter: Stuart Auchterlonie | Owner: Klaas de Waal
Type: Developer Task | Status: closed
Priority: minor | Milestone: 31.0
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution: Fixed
Keywords: schemachange | Ticket locked: 0
--------------------------------------+-------------------------------
Changes (by Klaas de Waal):

* status: assigned => closed
* resolution: => Fixed


Comment:

The possible values of the service_type are enumerated in file
dvbdescriptors.h in class ServiceDescriptorMapping.

An example on how to use this class:


{{{
#include "dvbdescriptors.h"
{
uint32_t service_type =
ServiceDescriptorMapping::kServiceTypeDigitalTelevision;
ServiceDescriptorMapping st(service_type);
LOG(VB_GENERAL, LOG_INFO, QString("service_type:%1 '%2' IsDTV:%3")
.arg(st.ServiceType()).arg(st.toString()).arg(st.IsDTV()));
}

}}}
which gives the following output:

{{{
service_type:1 ' (TV)' IsDTV:1

}}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/8774#comment:20>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-------------------------------
Reporter: Stuart Auchterlonie | Owner: Klaas de Waal
Type: Developer Task | Status: new
Priority: minor | Milestone: 32.0
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: schemachange | Ticket locked: 0
--------------------------------------+-------------------------------
Changes (by Klaas de Waal):

* status: closed => new
* resolution: Fixed =>
* milestone: 31.0 => 32.0


Comment:

The mythtv-setup channel scanner feature "Import Existing Scan" fails in
v31 and in master because the new field service_type is missing in
database table channelscan_channel.

For now the "Import Existing Scan" feature will be temporarily fixed by
importing the scan results without the service_type field.

The service_type was added to database channel but it was not added to
table channelscan_channel.

Adding this field to table channelscan_channel and restoring the
functionality to use it will be done before the v32 release so that the
database schema version of master will be the same as v31 for a while.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/8774#comment:21>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-------------------------------
Reporter: Stuart Auchterlonie | Owner: Klaas de Waal
Type: Developer Task | Status: accepted
Priority: minor | Milestone: 32.0
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: schemachange | Ticket locked: 0
--------------------------------------+-------------------------------
Changes (by Klaas de Waal):

* status: new => accepted


--
Ticket URL: <https://code.mythtv.org/trac/ticket/8774#comment:22>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-------------------------------
Reporter: Stuart Auchterlonie | Owner: Klaas de Waal
Type: Developer Task | Status: accepted
Priority: minor | Milestone: 32.0
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution:
Keywords: schemachange | Ticket locked: 0
--------------------------------------+-------------------------------

Comment (by Klaas de Waal <kdewaal@…>):

In [changeset:"c970d583788757295e38b6965611098b79f37cf6/mythtv"
c970d5837/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="c970d583788757295e38b6965611098b79f37cf6"
Fix "Import Existing Scan" option

Fix the Channel Scan option "Import Existing Scan".
This option has been broken since adding the field service_type
to database table channel in ticket #8774.
The functionality has been restored, but excluding the service_type value
which
will be added before release of v32 as this requires a database schema
change.

Other changes are:
- Present the saved scans in descending chronological order, so with the
newest on top
- When saving a new scan, delete all scans older than 14 days from that
video source
Previously, only scans created with the same capture card were deleted.
- Delete al saved scans of a video source when the video source is deleted

Refs #8774
Refs #13472
}}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/8774#comment:23>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #8774: Store channel type in database [ In reply to ]
#8774: Store channel type in database
--------------------------------------+-------------------------------
Reporter: Stuart Auchterlonie | Owner: Klaas de Waal
Type: Developer Task | Status: closed
Priority: minor | Milestone: 32.0
Component: MythTV - Channel Scanner | Version: Master Head
Severity: medium | Resolution: Fixed
Keywords: schemachange | Ticket locked: 0
--------------------------------------+-------------------------------
Changes (by Klaas de Waal):

* status: accepted => closed
* resolution: => Fixed


Comment:

The last bit of this, storing the service_type in database table
channelscan_channel for use in the "Import existing scan" feature, has
been implemented in commit 2e11e33b7af24c8a867b5b5f056a7c42c730c7c7 and
hence this ticket is now closed.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/8774#comment:24>
MythTV <http://www.mythtv.org>
MythTV Media Center