Mailing List Archive

Author: stevehay
Date: Thu Sep 26 17:05:30 2019
New Revision: 1867594

URL: http://svn.apache.org/viewvc?rev=1867594&view=rev
Log:
Fix t/api/request_rec.t failures on non-Windows platforms

These failures were introduced by rev. 1865449.

Use FINFO_SIZE rather than FINFO_NAME for the finfo() test since FINFO_NAME isn't dealt with in the 'unix' version of APR's filestat.c, causing "APR::Finfo::stat: (70008) Partial results are valid but processing is incomplete" errors -- the very errors that were fixed by rev. 1865449 on Windows!

Modified:
perl/modperl/trunk/t/response/TestAPI/request_rec.pm

Modified: perl/modperl/trunk/t/response/TestAPI/request_rec.pm
URL: http://svn.apache.org/viewvc/perl/modperl/trunk/t/response/TestAPI/request_rec.pm?rev=1867594&r1=1867593&r2=1867594&view=diff
==============================================================================
--- perl/modperl/trunk/t/response/TestAPI/request_rec.pm (original)
+++ perl/modperl/trunk/t/response/TestAPI/request_rec.pm Thu Sep 26 17:05:30 2019
@@ -15,7 +15,7 @@ use APR::Finfo ();
use APR::Pool ();

use Apache2::Const -compile => qw(OK M_GET M_PUT);
-use APR::Const -compile => qw(FINFO_NAME);
+use APR::Const -compile => qw(FINFO_SIZE);

#this test module is only for testing fields in the request_rec
#listed in apache_structures.map
@@ -165,12 +165,13 @@ sub handler {

# finfo
{
- my $finfo = APR::Finfo::stat(__FILE__, APR::Const::FINFO_NAME, $r->pool);
+ my $size = (stat __FILE__)[7];
+ my $finfo = APR::Finfo::stat(__FILE__, APR::Const::FINFO_SIZE, $r->pool);
$r->finfo($finfo);
# just one field test, all accessors are fully tested in
# TestAPR::finfo
- ok t_cmp($r->finfo->fname,
- __FILE__,
+ ok t_cmp($r->finfo->size,
+ $size,
'$r->finfo');
}