Mailing List Archive

[lvs-users] [PATCH v8 0/2] Allow tunneling with gue encapsulation
This patchset allows tunneling with gue encapsulation.

v8->v7:
1) fixed a few style issues from scripts/checkpatch.pl --strict
2) use up to 4 letters in the comments
3) updated document for new options

v7->v6:
1) fix type of local variable in parse_tun_type
2) use up to 4 letters in the comments
3) document new options

v6->v5:
1) split the patch into two:
- ipvsadm: convert options to unsigned long long
- ipvsadm: allow tunneling with gue encapsulation
2) do not mix static and dynamic allocation in fwd_tun_info
3) use correct nla_get/put function for tun_flags
4) fixed || style
5) use correct return value for parse_tun_type

v5->v4:
1) add checksum support for gue encapsulation

v4->v3:
1) removed changes to setsockopt interface
2) use correct nla_get/put function for tun_port

v3->v2:
1) added missing break statements to a few switch cases

v2->v1:
1) pass tun_type and tun_port as new optional parameters
instead of a few bits in existing conn_flags parameters

Jacky Hu (2):
ipvsadm: convert options to unsigned long long
ipvsadm: allow tunneling with gue encapsulation

ipvsadm.8 | 70 ++++++++
ipvsadm.c | 426 +++++++++++++++++++++++++++++++++++++++-------
libipvs/ip_vs.h | 28 +++
libipvs/libipvs.c | 15 ++
4 files changed, 473 insertions(+), 66 deletions(-)

--
2.21.0


_______________________________________________
Please read the documentation before posting - it's available at:
http://www.linuxvirtualserver.org/

LinuxVirtualServer.org mailing list - lvs-users@LinuxVirtualServer.org
Send requests to lvs-users-request@LinuxVirtualServer.org
or go to http://lists.graemef.net/mailman/listinfo/lvs-users
Re: [lvs-users] [PATCH v8 0/2] Allow tunneling with gue encapsulation [ In reply to ]
Hello,

On Thu, 30 May 2019, Jacky Hu wrote:

> This patchset allows tunneling with gue encapsulation.
>
> v8->v7:
> 1) fixed a few style issues from scripts/checkpatch.pl --strict
> 2) use up to 4 letters in the comments
> 3) updated document for new options
>
> v7->v6:
> 1) fix type of local variable in parse_tun_type
> 2) use up to 4 letters in the comments
> 3) document new options
>
> v6->v5:
> 1) split the patch into two:
> - ipvsadm: convert options to unsigned long long
> - ipvsadm: allow tunneling with gue encapsulation
> 2) do not mix static and dynamic allocation in fwd_tun_info
> 3) use correct nla_get/put function for tun_flags
> 4) fixed || style
> 5) use correct return value for parse_tun_type
>
> v5->v4:
> 1) add checksum support for gue encapsulation
>
> v4->v3:
> 1) removed changes to setsockopt interface
> 2) use correct nla_get/put function for tun_port
>
> v3->v2:
> 1) added missing break statements to a few switch cases
>
> v2->v1:
> 1) pass tun_type and tun_port as new optional parameters
> instead of a few bits in existing conn_flags parameters
>
> Jacky Hu (2):
> ipvsadm: convert options to unsigned long long
> ipvsadm: allow tunneling with gue encapsulation
>
> ipvsadm.8 | 70 ++++++++
> ipvsadm.c | 426 +++++++++++++++++++++++++++++++++++++++-------
> libipvs/ip_vs.h | 28 +++
> libipvs/libipvs.c | 15 ++
> 4 files changed, 473 insertions(+), 66 deletions(-)
>
> --
> 2.21.0

Both patches look ok to me, thanks!

Acked-by: Julian Anastasov <ja@ssi.bg>

Jesper, this patchset is based on the kernel patch
"[PATCH v4] ipvs: add checksum support for gue encapsulation"
which is to be applied to kernel trees. If needed, I can ping
you when the patch is accepted.

Regards

--
Julian Anastasov <ja@ssi.bg>

_______________________________________________
Please read the documentation before posting - it's available at:
http://www.linuxvirtualserver.org/

LinuxVirtualServer.org mailing list - lvs-users@LinuxVirtualServer.org
Send requests to lvs-users-request@LinuxVirtualServer.org
or go to http://lists.graemef.net/mailman/listinfo/lvs-users
Re: [lvs-users] [PATCH v8 0/2] Allow tunneling with gue encapsulation [ In reply to ]
On Thu, 30 May 2019 21:37:34 +0300 (EEST) Julian Anastasov <ja@ssi.bg> wrote:

> On Thu, 30 May 2019, Jacky Hu wrote:
>
> > This patchset allows tunneling with gue encapsulation.
> >
[...]
>
> Both patches look ok to me, thanks!
>
> Acked-by: Julian Anastasov <ja@ssi.bg>
>
> Jesper, this patchset is based on the kernel patch
> "[PATCH v4] ipvs: add checksum support for gue encapsulation"
> which is to be applied to kernel trees. If needed, I can ping
> you when the patch is accepted.

Yes, that would be great! I'll apply it as soon as the kernel patch is
accepted.

--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer

_______________________________________________
Please read the documentation before posting - it's available at:
http://www.linuxvirtualserver.org/

LinuxVirtualServer.org mailing list - lvs-users@LinuxVirtualServer.org
Send requests to lvs-users-request@LinuxVirtualServer.org
or go to http://lists.graemef.net/mailman/listinfo/lvs-users
Re: [lvs-users] [PATCH v8 0/2] Allow tunneling with gue encapsulation [ In reply to ]
attached keepalived.conf

Le ven. 31 mai 2019 à 07:53, Jesper Dangaard Brouer <brouer@redhat.com> a
écrit :

>
> On Thu, 30 May 2019 21:37:34 +0300 (EEST) Julian Anastasov <ja@ssi.bg>
> wrote:
>
> > On Thu, 30 May 2019, Jacky Hu wrote:
> >
> > > This patchset allows tunneling with gue encapsulation.
> > >
> [...]
> >
> > Both patches look ok to me, thanks!
> >
> > Acked-by: Julian Anastasov <ja@ssi.bg>
> >
> > Jesper, this patchset is based on the kernel patch
> > "[PATCH v4] ipvs: add checksum support for gue encapsulation"
> > which is to be applied to kernel trees. If needed, I can ping
> > you when the patch is accepted.
>
> Yes, that would be great! I'll apply it as soon as the kernel patch is
> accepted.
>
> --
> Best regards,
> Jesper Dangaard Brouer
> MSc.CS, Principal Kernel Engineer at Red Hat
> LinkedIn: http://www.linkedin.com/in/brouer
>
> _______________________________________________
> Please read the documentation before posting - it's available at:
> http://www.linuxvirtualserver.org/
>
> LinuxVirtualServer.org mailing list - lvs-users@LinuxVirtualServer.org
> Send requests to lvs-users-request@LinuxVirtualServer.org
> or go to http://lists.graemef.net/mailman/listinfo/lvs-users
>
Re: [lvs-users] [PATCH v8 0/2] Allow tunneling with gue encapsulation [ In reply to ]
On Fri, 31 May 2019 08:49:55 +0200
Jesper Dangaard Brouer <brouer@redhat.com> wrote:

> On Thu, 30 May 2019 21:37:34 +0300 (EEST) Julian Anastasov <ja@ssi.bg> wrote:
>
> > On Thu, 30 May 2019, Jacky Hu wrote:
> >
> > > This patchset allows tunneling with gue encapsulation.
> > >
> [...]
> >
> > Both patches look ok to me, thanks!
> >
> > Acked-by: Julian Anastasov <ja@ssi.bg>
> >
> > Jesper, this patchset is based on the kernel patch
> > "[PATCH v4] ipvs: add checksum support for gue encapsulation"
> > which is to be applied to kernel trees. If needed, I can ping
> > you when the patch is accepted.

Looks like this commit got applied to the kernel in commit 29930e314da3
("ipvs: add checksum support for gue encapsulation"), but only net-next.

Thus, I've applied this user-side patchset to ipvsadm.
https://git.kernel.org/pub/scm/utils/kernel/ipvsadm/ipvsadm.git/

As you might have noticed, I've created a release v1.30 prio to applying
these. As we have to wait for a kernel release, likely kernel v5.3,
before making an ipvsadm release with this GUE feature.

It should also make it easier for Julian's GRE work, to build on top.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer

commit 29930e314da3833437a2ddc7b17f6a954f38d8fb
Author: Jacky Hu <hengqing.hu@gmail.com>
Date: Thu May 30 08:16:40 2019 +0800

ipvs: add checksum support for gue encapsulation

Add checksum support for gue encapsulation with the tun_flags parameter,
which could be one of the values below:
IP_VS_TUNNEL_ENCAP_FLAG_NOCSUM
IP_VS_TUNNEL_ENCAP_FLAG_CSUM
IP_VS_TUNNEL_ENCAP_FLAG_REMCSUM

Signed-off-by: Jacky Hu <hengqing.hu@gmail.com>
Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

_______________________________________________
Please read the documentation before posting - it's available at:
http://www.linuxvirtualserver.org/

LinuxVirtualServer.org mailing list - lvs-users@LinuxVirtualServer.org
Send requests to lvs-users-request@LinuxVirtualServer.org
or go to http://lists.graemef.net/mailman/listinfo/lvs-users
Re: [lvs-users] [PATCH v8 0/2] Allow tunneling with gue encapsulation [ In reply to ]
Hello,

On Tue, 2 Jul 2019, Jesper Dangaard Brouer wrote:

> > On Thu, 30 May 2019 21:37:34 +0300 (EEST) Julian Anastasov <ja@ssi.bg> wrote:
> >
> > > On Thu, 30 May 2019, Jacky Hu wrote:
> > >
> > > > This patchset allows tunneling with gue encapsulation.
> > > >
> > [...]
> > >
> > > Both patches look ok to me, thanks!
> > >
> > > Acked-by: Julian Anastasov <ja@ssi.bg>
> > >
> > > Jesper, this patchset is based on the kernel patch
> > > "[PATCH v4] ipvs: add checksum support for gue encapsulation"
> > > which is to be applied to kernel trees. If needed, I can ping
> > > you when the patch is accepted.
>
> Looks like this commit got applied to the kernel in commit 29930e314da3
> ("ipvs: add checksum support for gue encapsulation"), but only net-next.

Yes, I waited net-next to be sent to Linus but it is
fine to have these patches applied.

> Thus, I've applied this user-side patchset to ipvsadm.
> https://git.kernel.org/pub/scm/utils/kernel/ipvsadm/ipvsadm.git/
>
> As you might have noticed, I've created a release v1.30 prio to applying
> these. As we have to wait for a kernel release, likely kernel v5.3,
> before making an ipvsadm release with this GUE feature.

Very good, thanks! The GUE+GRE work can be part of next release.

> It should also make it easier for Julian's GRE work, to build on top.
> --
> Best regards,
> Jesper Dangaard Brouer
> MSc.CS, Principal Kernel Engineer at Red Hat
> LinkedIn: http://www.linkedin.com/in/brouer
>
> commit 29930e314da3833437a2ddc7b17f6a954f38d8fb
> Author: Jacky Hu <hengqing.hu@gmail.com>
> Date: Thu May 30 08:16:40 2019 +0800
>
> ipvs: add checksum support for gue encapsulation
>
> Add checksum support for gue encapsulation with the tun_flags parameter,
> which could be one of the values below:
> IP_VS_TUNNEL_ENCAP_FLAG_NOCSUM
> IP_VS_TUNNEL_ENCAP_FLAG_CSUM
> IP_VS_TUNNEL_ENCAP_FLAG_REMCSUM
>
> Signed-off-by: Jacky Hu <hengqing.hu@gmail.com>
> Signed-off-by: Julian Anastasov <ja@ssi.bg>
> Signed-off-by: Simon Horman <horms@verge.net.au>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

Regards

--
Julian Anastasov <ja@ssi.bg>

_______________________________________________
Please read the documentation before posting - it's available at:
http://www.linuxvirtualserver.org/

LinuxVirtualServer.org mailing list - lvs-users@LinuxVirtualServer.org
Send requests to lvs-users-request@LinuxVirtualServer.org
or go to http://lists.graemef.net/mailman/listinfo/lvs-users