Mailing List Archive: [lvs-users] [PATCH v7 0/2] Allow tunneling with gue encapsulation

This patchset allows tunneling with gue encapsulation.

v7->v6:
1) fix type of local variable in parse_tun_type
2) use up to 4 letters in the comments
3) document new options

v6->v5:
1) split the patch into two:
- ipvsadm: convert options to unsigned long long
- ipvsadm: allow tunneling with gue encapsulation
2) do not mix static and dynamic allocation in fwd_tun_info
3) use correct nla_get/put function for tun_flags
4) fixed || style
5) use correct return value for parse_tun_type

v5->v4:
1) add checksum support for gue encapsulation

v4->v3:
1) removed changes to setsockopt interface
2) use correct nla_get/put function for tun_port

v3->v2:
1) added missing break statements to a few switch cases

v2->v1:
1) pass tun_type and tun_port as new optional parameters
instead of a few bits in existing conn_flags parameters

Jacky Hu (2):
ipvsadm: convert options to unsigned long long
ipvsadm: allow tunneling with gue encapsulation

ipvsadm.8 | 72 ++++++++
ipvsadm.c | 427 +++++++++++++++++++++++++++++++++++++++-------
libipvs/ip_vs.h | 28 +++
libipvs/libipvs.c | 15 ++
4 files changed, 476 insertions(+), 66 deletions(-)

--
2.21.0

_______________________________________________
Please read the documentation before posting - it's available at:
http://www.linuxvirtualserver.org/

LinuxVirtualServer.org mailing list - lvs-users@LinuxVirtualServer.org
Send requests to lvs-users-request@LinuxVirtualServer.org
or go to http://lists.graemef.net/mailman/listinfo/lvs-users

Hello,

On Sun, 26 May 2019, Jacky Hu wrote:

> This patchset allows tunneling with gue encapsulation.
>
> v7->v6:
> 1) fix type of local variable in parse_tun_type
> 2) use up to 4 letters in the comments
> 3) document new options

May be we should fix some final styling problems:

scripts/checkpatch.pl --strict file.patch

For patch 1/2: all

For patch 2/2: some of them:

- "spaces preferred around" ...
- "Please don't use multiple blank lines"

Also, in the new examples multiple -a lines do not give
much information, one -a would be enough. Or may be we can add
variations with the 3 csum options. If you prefer you can also
use 10.0.0.1 as VIP.

> v6->v5:
> 1) split the patch into two:
> - ipvsadm: convert options to unsigned long long
> - ipvsadm: allow tunneling with gue encapsulation
> 2) do not mix static and dynamic allocation in fwd_tun_info
> 3) use correct nla_get/put function for tun_flags
> 4) fixed || style
> 5) use correct return value for parse_tun_type
>
> v5->v4:
> 1) add checksum support for gue encapsulation
>
> v4->v3:
> 1) removed changes to setsockopt interface
> 2) use correct nla_get/put function for tun_port
>
> v3->v2:
> 1) added missing break statements to a few switch cases
>
> v2->v1:
> 1) pass tun_type and tun_port as new optional parameters
> instead of a few bits in existing conn_flags parameters
>
> Jacky Hu (2):
> ipvsadm: convert options to unsigned long long
> ipvsadm: allow tunneling with gue encapsulation
>
> ipvsadm.8 | 72 ++++++++
> ipvsadm.c | 427 +++++++++++++++++++++++++++++++++++++++-------
> libipvs/ip_vs.h | 28 +++
> libipvs/libipvs.c | 15 ++
> 4 files changed, 476 insertions(+), 66 deletions(-)
>
> --
> 2.21.0

Regards

--
Julian Anastasov <ja@ssi.bg>

_______________________________________________
Please read the documentation before posting - it's available at:
http://www.linuxvirtualserver.org/

LinuxVirtualServer.org mailing list - lvs-users@LinuxVirtualServer.org
Send requests to lvs-users-request@LinuxVirtualServer.org
or go to http://lists.graemef.net/mailman/listinfo/lvs-users