Mailing List Archive

Hi Karl,

I fixed the boxing issue errorprone has been complaining about after your
recent commits. Some of those validation checks (errorprone) are slow(er)
and run only on the CI (github and jenkins) so a local gradle check may not
find them all.

Also, is there any reference to the problem your commits are trying to
solve (issue number)? They just appear on the main branch without a
reference - it'll be difficult to backport them to 9x, should such backport
be needed.

I'd encourage you again to create a pull request on github (off the branch
you're working on) - makes life so much easier for everyone involved (runs
full CI checks, allows others to comment, preserves the history of commits
for that particular issue as a branch/diff).

Thanks,
Dawid

On Wed, Nov 23, 2022 at 7:32 AM Policeman Jenkins Server <
jenkins@thetaphi.de> wrote:

> Build: https://jenkins.thetaphi.de/job/Lucene-main-Linux/38480/
> Java: 64bit/jdk-17.0.3 -XX:-UseCompressedOops -XX:+UseParallelGC
>
> All tests passed
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: builds-unsubscribe@lucene.apache.org
> For additional commands, e-mail: builds-help@lucene.apache.org