Mailing List Archive

What's weird is that tidy should have been called from within the release
wizard - it was added in this issue.

https://github.com/apache/lucene/pull/11748

Have I missed something obvious here?

Dawid

On Mon, Oct 24, 2022 at 5:28 PM Ignacio Vera <iverase@gmail.com> wrote:

> I pushed a fix for this spotless error.
>
> On Mon, Oct 24, 2022 at 4:17 PM Apache Jenkins Server <
> jenkins@builds.apache.org> wrote:
>
>> Build: https://ci-builds.apache.org/job/Lucene/job/Lucene-Check-9.4/509/
>>
>> All tests passed
>>
>> Build Log:
>> [...truncated 1292 lines...]
>> BUILD FAILED in 19m 30s
>> 797 actionable tasks: 797 executed
>> Build step 'Invoke Gradle script' changed build result to FAILURE
>> Build step 'Invoke Gradle script' marked build as failure
>> Archiving artifacts
>> Recording test results
>> [Checks API] No suitable checks publisher found.
>> Email was triggered for: Failure - Any
>> Sending email for trigger: Failure - Any
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: builds-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: builds-help@lucene.apache.org
>
>

I think the problem here is that at the point of running those commands I
had lost trust in the release wizard and I was running the commands
manually. The instructions for those steps do not contain running tidy
(maybe we should add them there too).

One of the problems at the moment in the release wizard is that any step
that involves running a gradle task on main branch fails because it
requires java 17 and we run all commands with java 11. I think that should
be addressed, those steps were missing for the 9.4.0 release and I fixed
them too.

On Mon, Oct 24, 2022 at 7:57 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:

>
> What's weird is that tidy should have been called from within the release
> wizard - it was added in this issue.
>
> https://github.com/apache/lucene/pull/11748
>
> Have I missed something obvious here?
>
> Dawid
>
> On Mon, Oct 24, 2022 at 5:28 PM Ignacio Vera <iverase@gmail.com> wrote:
>
>> I pushed a fix for this spotless error.
>>
>> On Mon, Oct 24, 2022 at 4:17 PM Apache Jenkins Server <
>> jenkins@builds.apache.org> wrote:
>>
>>> Build: https://ci-builds.apache.org/job/Lucene/job/Lucene-Check-9.4/509/
>>>
>>> All tests passed
>>>
>>> Build Log:
>>> [...truncated 1292 lines...]
>>> BUILD FAILED in 19m 30s
>>> 797 actionable tasks: 797 executed
>>> Build step 'Invoke Gradle script' changed build result to FAILURE
>>> Build step 'Invoke Gradle script' marked build as failure
>>> Archiving artifacts
>>> Recording test results
>>> [Checks API] No suitable checks publisher found.
>>> Email was triggered for: Failure - Any
>>> Sending email for trigger: Failure - Any
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: builds-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: builds-help@lucene.apache.org
>>
>>

> I think the problem here is that at the point of running those commands I
> had lost trust in the release wizard and I was running the commands
> manually.
>

Ok, that explains it. :)


> One of the problems at the moment in the release wizard is that any step
> that involves running a gradle task on main branch fails because it
> requires java 17 and we run all commands with java 11. I think that should
> be addressed, those steps were missing for the 9.4.0 release and I fixed
> them too.
>

I'm not sure how to handle cross-major version releases with the release
wizard. Should the wizard/scripts from 9x be used (and not the main
version)?

Dawid

>

That's a good question. The wizard already has a mapping from Solr version to Java version and a method to find correct java_home and java_cmd:
https://github.com/dweiss/lucene/blob/main/dev-tools/scripts/releaseWizard.py#L590:L600

So perhaps we need some logic to set correct JAVA_HOME and path for each command depending on branch?

Also the Java version for Lucene 10 (main) must be updated here https://github.com/dweiss/lucene/blob/main/dev-tools/scripts/releaseWizard.py#L69:L70

Jan

> 25. okt. 2022 kl. 10:49 skrev Dawid Weiss <dawid.weiss@gmail.com>:
>
>
> I think the problem here is that at the point of running those commands I had lost trust in the release wizard and I was running the commands manually.
>
> Ok, that explains it. :)
>
> One of the problems at the moment in the release wizard is that any step that involves running a gradle task on main branch fails because it requires java 17 and we run all commands with java 11. I think that should be addressed, those steps were missing for the 9.4.0 release and I fixed them too.
>
> I'm not sure how to handle cross-major version releases with the release wizard. Should the wizard/scripts from 9x be used (and not the main version)?
>
> Dawid

Hi Jan,

The pointers are at my local fork but I filed a patch that updates the
Java version for Lucene 10, here:
https://github.com/apache/lucene/pull/11872

Dawid

On Tue, Oct 25, 2022 at 12:07 PM Jan Høydahl <jan.asf@cominvent.com> wrote:
>
> That's a good question. The wizard already has a mapping from Solr version to Java version and a method to find correct java_home and java_cmd:
> https://github.com/dweiss/lucene/blob/main/dev-tools/scripts/releaseWizard.py#L590:L600
>
> So perhaps we need some logic to set correct JAVA_HOME and path for each command depending on branch?
>
> Also the Java version for Lucene 10 (main) must be updated here https://github.com/dweiss/lucene/blob/main/dev-tools/scripts/releaseWizard.py#L69:L70
>
> Jan
>
> 25. okt. 2022 kl. 10:49 skrev Dawid Weiss <dawid.weiss@gmail.com>:
>
>
>> I think the problem here is that at the point of running those commands I had lost trust in the release wizard and I was running the commands manually.
>
>
> Ok, that explains it. :)
>
>>
>> One of the problems at the moment in the release wizard is that any step that involves running a gradle task on main branch fails because it requires java 17 and we run all commands with java 11. I think that should be addressed, those steps were missing for the 9.4.0 release and I fixed them too.
>
>
> I'm not sure how to handle cross-major version releases with the release wizard. Should the wizard/scripts from 9x be used (and not the main version)?
>
> Dawid
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org