Let's reconfigure GitHub Action to pass tests.nightly=true
Not sure why it was configured like that. The sysproo makes no sense to me (why only on nightly tests?).
I would say: Let's add a separate project property like "cibuild=true". I can put that into Gradle property file on all nenks, too. So errorprone runs on all ci builds.
Uwe
Am 13. Mai 2022 19:54:07 UTC schrieb Dawid Weiss <dawid.weiss@gmail.com>:
>Apologies for not fixing it myself - I had the time to look at the jenkins
>log only. Maybe it'd be a good idea to run errorprone on github so that
>this doesn't surprise people again.
>
>D.
>
>On Fri, May 13, 2022 at 7:25 PM Julie Tibshirani <julietibs@gmail.com>
>wrote:
>
>> I pushed a fix yesterday (both main and branch_9x), sorry for the noise!
>>
>> On Thu, May 12, 2022 at 11:03 PM Dawid Weiss <dawid.weiss@gmail.com>
>> wrote:
>>
>>> This is errorprone-caused failure:
>>>
>>> > Task :lucene:core:compileTestJava FAILED
>>>
>>> /home/jenkins/jenkins-slave/workspace/Lucene/Lucene-NightlyTests-9.x/checkout/lucene/core/src/test/org/apache/lucene/util/TestSparseFixedBitSet.java:106:
>>> warning: [LongFloatConversion] Conversion from long to float may lose
>>> precision; use an explicit cast to float if this was intentional
>>> assertEquals(orCopy.ramBytesUsed(), original.ramBytesUsed(), 64L);
>>> ^
>>> (see https://errorprone.info/bugpattern/LongFloatConversion)
>>> Did you mean 'assertEquals((float) orCopy.ramBytesUsed(),
>>> original.ramBytesUsed(), 64L);'?
>>>
>>> /home/jenkins/jenkins-slave/workspace/Lucene/Lucene-NightlyTests-9.x/checkout/lucene/core/src/test/org/apache/lucene/util/TestSparseFixedBitSet.java:106:
>>> warning: [LongFloatConversion] Conversion from long to float may lose
>>> precision; use an explicit cast to float if this was intentional
>>> assertEquals(orCopy.ramBytesUsed(), original.ramBytesUsed(), 64L);
>>> ^
>>> (see https://errorprone.info/bugpattern/LongFloatConversion)
>>> Did you mean 'assertEquals(orCopy.ramBytesUsed(), (float)
>>> original.ramBytesUsed(), 64L);'?
>>>
>>> /home/jenkins/jenkins-slave/workspace/Lucene/Lucene-NightlyTests-9.x/checkout/lucene/core/src/test/org/apache/lucene/util/TestSparseFixedBitSet.java:106:
>>> warning: [LongFloatConversion] Conversion from long to float may lose
>>> precision; use an explicit cast to float if this was intentional
>>> assertEquals(orCopy.ramBytesUsed(), original.ramBytesUsed(), 64L);
>>> ^
>>> (see https://errorprone.info/bugpattern/LongFloatConversion)
>>> Did you mean 'assertEquals(orCopy.ramBytesUsed(),
>>> original.ramBytesUsed(), (float) 64L);'?
>>> error: warnings found and -Werror specified
>>> Note: Some input files use or override a deprecated API.
>>> Note: Recompile with -Xlint:deprecation for details.
>>> 1 error
>>> 3 warnings
>>>
>>> On Fri, May 13, 2022 at 4:23 AM Apache Jenkins Server
>>> <jenkins@builds.apache.org> wrote:
>>> >
>>> > Build:
>>> https://ci-builds.apache.org/job/Lucene/job/Lucene-NightlyTests-9.x/192/
>>> >
>>> > All tests passed
>>> >
>>> > Build Log:
>>> > [...truncated 513 lines...]
>>> > BUILD FAILED in 1h 1m 40s
>>> > 222 actionable tasks: 222 executed
>>> > Build step 'Invoke Gradle script' changed build result to FAILURE
>>> > Build step 'Invoke Gradle script' marked build as failure
>>> > Archiving artifacts
>>> > Recording test results
>>> > [Checks API] No suitable checks publisher found.
>>> > Email was triggered for: Failure - Any
>>> > Sending email for trigger: Failure - Any
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: builds-unsubscribe@lucene.apache.org
>>> > For additional commands, e-mail: builds-help@lucene.apache.org
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>>
--
Uwe Schindler
Achterdiek 19, 28357 Bremen
https://www.thetaphi.de
Not sure why it was configured like that. The sysproo makes no sense to me (why only on nightly tests?).
I would say: Let's add a separate project property like "cibuild=true". I can put that into Gradle property file on all nenks, too. So errorprone runs on all ci builds.
Uwe
Am 13. Mai 2022 19:54:07 UTC schrieb Dawid Weiss <dawid.weiss@gmail.com>:
>Apologies for not fixing it myself - I had the time to look at the jenkins
>log only. Maybe it'd be a good idea to run errorprone on github so that
>this doesn't surprise people again.
>
>D.
>
>On Fri, May 13, 2022 at 7:25 PM Julie Tibshirani <julietibs@gmail.com>
>wrote:
>
>> I pushed a fix yesterday (both main and branch_9x), sorry for the noise!
>>
>> On Thu, May 12, 2022 at 11:03 PM Dawid Weiss <dawid.weiss@gmail.com>
>> wrote:
>>
>>> This is errorprone-caused failure:
>>>
>>> > Task :lucene:core:compileTestJava FAILED
>>>
>>> /home/jenkins/jenkins-slave/workspace/Lucene/Lucene-NightlyTests-9.x/checkout/lucene/core/src/test/org/apache/lucene/util/TestSparseFixedBitSet.java:106:
>>> warning: [LongFloatConversion] Conversion from long to float may lose
>>> precision; use an explicit cast to float if this was intentional
>>> assertEquals(orCopy.ramBytesUsed(), original.ramBytesUsed(), 64L);
>>> ^
>>> (see https://errorprone.info/bugpattern/LongFloatConversion)
>>> Did you mean 'assertEquals((float) orCopy.ramBytesUsed(),
>>> original.ramBytesUsed(), 64L);'?
>>>
>>> /home/jenkins/jenkins-slave/workspace/Lucene/Lucene-NightlyTests-9.x/checkout/lucene/core/src/test/org/apache/lucene/util/TestSparseFixedBitSet.java:106:
>>> warning: [LongFloatConversion] Conversion from long to float may lose
>>> precision; use an explicit cast to float if this was intentional
>>> assertEquals(orCopy.ramBytesUsed(), original.ramBytesUsed(), 64L);
>>> ^
>>> (see https://errorprone.info/bugpattern/LongFloatConversion)
>>> Did you mean 'assertEquals(orCopy.ramBytesUsed(), (float)
>>> original.ramBytesUsed(), 64L);'?
>>>
>>> /home/jenkins/jenkins-slave/workspace/Lucene/Lucene-NightlyTests-9.x/checkout/lucene/core/src/test/org/apache/lucene/util/TestSparseFixedBitSet.java:106:
>>> warning: [LongFloatConversion] Conversion from long to float may lose
>>> precision; use an explicit cast to float if this was intentional
>>> assertEquals(orCopy.ramBytesUsed(), original.ramBytesUsed(), 64L);
>>> ^
>>> (see https://errorprone.info/bugpattern/LongFloatConversion)
>>> Did you mean 'assertEquals(orCopy.ramBytesUsed(),
>>> original.ramBytesUsed(), (float) 64L);'?
>>> error: warnings found and -Werror specified
>>> Note: Some input files use or override a deprecated API.
>>> Note: Recompile with -Xlint:deprecation for details.
>>> 1 error
>>> 3 warnings
>>>
>>> On Fri, May 13, 2022 at 4:23 AM Apache Jenkins Server
>>> <jenkins@builds.apache.org> wrote:
>>> >
>>> > Build:
>>> https://ci-builds.apache.org/job/Lucene/job/Lucene-NightlyTests-9.x/192/
>>> >
>>> > All tests passed
>>> >
>>> > Build Log:
>>> > [...truncated 513 lines...]
>>> > BUILD FAILED in 1h 1m 40s
>>> > 222 actionable tasks: 222 executed
>>> > Build step 'Invoke Gradle script' changed build result to FAILURE
>>> > Build step 'Invoke Gradle script' marked build as failure
>>> > Archiving artifacts
>>> > Recording test results
>>> > [Checks API] No suitable checks publisher found.
>>> > Email was triggered for: Failure - Any
>>> > Sending email for trigger: Failure - Any
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: builds-unsubscribe@lucene.apache.org
>>> > For additional commands, e-mail: builds-help@lucene.apache.org
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>>
--
Uwe Schindler
Achterdiek 19, 28357 Bremen
https://www.thetaphi.de