It's been >72h since the vote was initiated and the result is:
+1 11 (10 binding)
0 1
-1 0
This vote has PASSED.
On Mon, Dec 6, 2021 at 10:15 AM Adrien Grand <jpountz@gmail.com> wrote:
>
> Thanks Uwe for finding this issue. I agree with your and Tomoko's
> judgement that it doesn't need to be a blocker for this release
> candidate.
>
> Tomoko's suggestion to add a note to the release announcement sounds
> like a good idea to me. I added the following note at
> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+9.0:
>
> ```
> Using Lucene 9 with the module system should be considered
> experimental. We expect to make progress on this in future 9.x
> releases.
> ```
>
> I wasn't sure if we should say "experimental" or not supported at all.
> You know more about this than I do so feel free to hack on the release
> announcement.
>
> On Mon, Dec 6, 2021 at 6:18 AM Tomoko Uchida
> <tomoko.uchida.1111@gmail.com> wrote:
> >
> > > I don't want to hold the release, so still my +1, but in case of respoin please fix Luke startup. To use Luke, NIOFSDirectory is fine. Just not in production.
> >
> > Thanks Uwe, for the alert. I didn't notice NIOFSDirectory is selected
> > as the default (in the RC Luke).
> > I don't fully grasp the use-cases of the app, but I think most people
> > use it for local debugging purposes, on relatively small indices.
> > Anyway, it requires a GUI system...
> > From my perspective, it's not a blocker so +1 to release (non-binding,
> > just in case)
> >
> > > So we should really tell people in release note that using Lucene 9.0 with module system is not supported!
> >
> > Maybe we can note that in the release announcement and/or the website?
> >
> > Tomoko
> >
> > 2021?12?6?(?) 4:27 Uwe Schindler <uwe@thetaphi.de>:
> > >
> > > Here is the issue: https://issues.apache.org/jira/browse/LUCENE-10287
> > > PR: https://github.com/apache/lucene/pull/517
> > >
> > > -----
> > > Uwe Schindler
> > > Achterdiek 19, D-28357 Bremen
> > > https://www.thetaphi.de
> > > eMail: uwe@thetaphi.de
> > >
> > > > -----Original Message-----
> > > > From: Uwe Schindler <uwe@thetaphi.de>
> > > > Sent: Sunday, December 5, 2021 8:00 PM
> > > > To: dev@lucene.apache.org
> > > > Subject: RE: [VOTE] Release Lucene 9.0.0 RC4
> > > >
> > > > Hi,
> > > >
> > > > as always I did my smoke tests on Policeman Jenkins, this works:
> > > >
> > > > SUCCESS! [0:27:39.140181]
> > > > (https://jenkins.thetaphi.de/job/Lucene-Release-Tester/8/console; tested with
> > > > Java 11 and Java 17)
> > > >
> > > > Unfortunately, I again found a module-system problem in combination with
> > > > Luke (sorry in my personal opinion, this was way too early to release with
> > > > module system support, we should have reverted the module system changes
> > > > for 9.0!). The problem is the following: When using module system,
> > > > sun.misc.Unsafe is not available (it contrast, it is avail in classpath mode by
> > > > default). This causes Luke to never use MMapDirectory, because
> > > > MMapDirectory disables itsself, as it cannot unmap (without sun.misc.Unsafe).
> > > >
> > > > I will open a PR to fix this in later versions, also Dawids JMS branch needs to
> > > > add the module to lucene-core's requires. To start Luke, you need to modify the
> > > > startup script like this: java [...] --add-modules
> > > > org.apache.logging.log4j,jdk.unsupported --module org.apache.lucene.luke
> > > >
> > > > I don't want to hold the release, so still my +1, but in case of respoin please fix
> > > > Luke startup. To use Luke, NIOFSDirectory is fine. Just not in production. So we
> > > > should really tell people in release note that using Lucene 9.0 with module
> > > > system is not supported!
> > > >
> > > > Everything else looks fine, in the documentation we unfortunately did not
> > > > merge the index.html changes (they are only in 9.x) to show correct path of
> > > > Luke to start it.
> > > >
> > > > +/-0 to release (so don't count a vote from me), in case of respin: fix activated
> > > > modules for luke as stated above and fix index.html of documentation
> > > >
> > > > Uwe
> > > > -----
> > > > Uwe Schindler
> > > > Achterdiek 19, D-28357 Bremen
> > > > https://www.thetaphi.de
> > > > eMail: uwe@thetaphi.de
> > > >
> > > > > -----Original Message-----
> > > > > From: Adrien Grand <jpountz@gmail.com>
> > > > > Sent: Wednesday, December 1, 2021 5:57 PM
> > > > > To: Lucene Dev <dev@lucene.apache.org>
> > > > > Subject: [VOTE] Release Lucene 9.0.0 RC4
> > > > >
> > > > > Please vote for release candidate 4 for Lucene 9.0.0
> > > > >
> > > > > The artifacts can be downloaded from:
> > > > > https://dist.apache.org/repos/dist/dev/lucene/lucene-9.0.0-RC4-rev-
> > > > > 0b18b3b965cedaf5eb129aa41243a44c83ca826d
> > > > >
> > > > > You can run the smoke tester directly with this command:
> > > > >
> > > > > python3 -u dev-tools/scripts/smokeTestRelease.py \
> > > > > https://dist.apache.org/repos/dist/dev/lucene/lucene-9.0.0-RC4-rev-
> > > > > 0b18b3b965cedaf5eb129aa41243a44c83ca826d
> > > > >
> > > > > The vote will be open until 2021-12-06 08:00 UTC.
> > > > >
> > > > > [ ] +1 approve
> > > > > [ ] +0 no opinion
> > > > > [ ] -1 disapprove (and reason why)
> > > > >
> > > > > Here is my +1
> > > > >
> > > > > --
> > > > > Adrien
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > > > > For additional commands, e-mail: dev-help@lucene.apache.org
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > > > For additional commands, e-mail: dev-help@lucene.apache.org
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > > For additional commands, e-mail: dev-help@lucene.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: dev-help@lucene.apache.org
> >
>
>
> --
> Adrien
--
Adrien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
+1 11 (10 binding)
0 1
-1 0
This vote has PASSED.
On Mon, Dec 6, 2021 at 10:15 AM Adrien Grand <jpountz@gmail.com> wrote:
>
> Thanks Uwe for finding this issue. I agree with your and Tomoko's
> judgement that it doesn't need to be a blocker for this release
> candidate.
>
> Tomoko's suggestion to add a note to the release announcement sounds
> like a good idea to me. I added the following note at
> https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+9.0:
>
> ```
> Using Lucene 9 with the module system should be considered
> experimental. We expect to make progress on this in future 9.x
> releases.
> ```
>
> I wasn't sure if we should say "experimental" or not supported at all.
> You know more about this than I do so feel free to hack on the release
> announcement.
>
> On Mon, Dec 6, 2021 at 6:18 AM Tomoko Uchida
> <tomoko.uchida.1111@gmail.com> wrote:
> >
> > > I don't want to hold the release, so still my +1, but in case of respoin please fix Luke startup. To use Luke, NIOFSDirectory is fine. Just not in production.
> >
> > Thanks Uwe, for the alert. I didn't notice NIOFSDirectory is selected
> > as the default (in the RC Luke).
> > I don't fully grasp the use-cases of the app, but I think most people
> > use it for local debugging purposes, on relatively small indices.
> > Anyway, it requires a GUI system...
> > From my perspective, it's not a blocker so +1 to release (non-binding,
> > just in case)
> >
> > > So we should really tell people in release note that using Lucene 9.0 with module system is not supported!
> >
> > Maybe we can note that in the release announcement and/or the website?
> >
> > Tomoko
> >
> > 2021?12?6?(?) 4:27 Uwe Schindler <uwe@thetaphi.de>:
> > >
> > > Here is the issue: https://issues.apache.org/jira/browse/LUCENE-10287
> > > PR: https://github.com/apache/lucene/pull/517
> > >
> > > -----
> > > Uwe Schindler
> > > Achterdiek 19, D-28357 Bremen
> > > https://www.thetaphi.de
> > > eMail: uwe@thetaphi.de
> > >
> > > > -----Original Message-----
> > > > From: Uwe Schindler <uwe@thetaphi.de>
> > > > Sent: Sunday, December 5, 2021 8:00 PM
> > > > To: dev@lucene.apache.org
> > > > Subject: RE: [VOTE] Release Lucene 9.0.0 RC4
> > > >
> > > > Hi,
> > > >
> > > > as always I did my smoke tests on Policeman Jenkins, this works:
> > > >
> > > > SUCCESS! [0:27:39.140181]
> > > > (https://jenkins.thetaphi.de/job/Lucene-Release-Tester/8/console; tested with
> > > > Java 11 and Java 17)
> > > >
> > > > Unfortunately, I again found a module-system problem in combination with
> > > > Luke (sorry in my personal opinion, this was way too early to release with
> > > > module system support, we should have reverted the module system changes
> > > > for 9.0!). The problem is the following: When using module system,
> > > > sun.misc.Unsafe is not available (it contrast, it is avail in classpath mode by
> > > > default). This causes Luke to never use MMapDirectory, because
> > > > MMapDirectory disables itsself, as it cannot unmap (without sun.misc.Unsafe).
> > > >
> > > > I will open a PR to fix this in later versions, also Dawids JMS branch needs to
> > > > add the module to lucene-core's requires. To start Luke, you need to modify the
> > > > startup script like this: java [...] --add-modules
> > > > org.apache.logging.log4j,jdk.unsupported --module org.apache.lucene.luke
> > > >
> > > > I don't want to hold the release, so still my +1, but in case of respoin please fix
> > > > Luke startup. To use Luke, NIOFSDirectory is fine. Just not in production. So we
> > > > should really tell people in release note that using Lucene 9.0 with module
> > > > system is not supported!
> > > >
> > > > Everything else looks fine, in the documentation we unfortunately did not
> > > > merge the index.html changes (they are only in 9.x) to show correct path of
> > > > Luke to start it.
> > > >
> > > > +/-0 to release (so don't count a vote from me), in case of respin: fix activated
> > > > modules for luke as stated above and fix index.html of documentation
> > > >
> > > > Uwe
> > > > -----
> > > > Uwe Schindler
> > > > Achterdiek 19, D-28357 Bremen
> > > > https://www.thetaphi.de
> > > > eMail: uwe@thetaphi.de
> > > >
> > > > > -----Original Message-----
> > > > > From: Adrien Grand <jpountz@gmail.com>
> > > > > Sent: Wednesday, December 1, 2021 5:57 PM
> > > > > To: Lucene Dev <dev@lucene.apache.org>
> > > > > Subject: [VOTE] Release Lucene 9.0.0 RC4
> > > > >
> > > > > Please vote for release candidate 4 for Lucene 9.0.0
> > > > >
> > > > > The artifacts can be downloaded from:
> > > > > https://dist.apache.org/repos/dist/dev/lucene/lucene-9.0.0-RC4-rev-
> > > > > 0b18b3b965cedaf5eb129aa41243a44c83ca826d
> > > > >
> > > > > You can run the smoke tester directly with this command:
> > > > >
> > > > > python3 -u dev-tools/scripts/smokeTestRelease.py \
> > > > > https://dist.apache.org/repos/dist/dev/lucene/lucene-9.0.0-RC4-rev-
> > > > > 0b18b3b965cedaf5eb129aa41243a44c83ca826d
> > > > >
> > > > > The vote will be open until 2021-12-06 08:00 UTC.
> > > > >
> > > > > [ ] +1 approve
> > > > > [ ] +0 no opinion
> > > > > [ ] -1 disapprove (and reason why)
> > > > >
> > > > > Here is my +1
> > > > >
> > > > > --
> > > > > Adrien
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > > > > For additional commands, e-mail: dev-help@lucene.apache.org
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > > > For additional commands, e-mail: dev-help@lucene.apache.org
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > > For additional commands, e-mail: dev-help@lucene.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: dev-help@lucene.apache.org
> >
>
>
> --
> Adrien
--
Adrien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org