Mailing List Archive: Taxonomy backward compatibility tests

Taxonomy backward compatibility tests

Nov 2, 2021, 6:09 AM

Post #1 of 6 (436 views)

Hello here,

As part of changing the version of the main branch from 9.0 to 10.0, I had
to address some backward compatibility logic and tests. In particular,
lucene/facet had a backward compatibility test for the taxonomy index due
to the move from doc values to stored fields.

I deleted this test, since we no longer use different approaches depending
on the version that was used to create the taxonomy index. Please let me
know if you disagree with this approach and I can work on resurrecting this
test.

--
Adrien

Re: Taxonomy backward compatibility tests [ In reply to ]

worah.gautam at gmail

Nov 2, 2021, 10:36 AM

Post #2 of 6 (436 views)

Permalink

I think this makes sense. Lucene 9 continues to be backwards compatible
with Lucene 8. Lucene 10 will be able to read Lucene 9,10 taxonomy indexes.
LGTM!

--
Gautam Worah.

On Tue, Nov 2, 2021 at 6:09 AM Adrien Grand <jpountz@gmail.com> wrote:

> Hello here,
>
> As part of changing the version of the main branch from 9.0 to 10.0, I had
> to address some backward compatibility logic and tests. In particular,
> lucene/facet had a backward compatibility test for the taxonomy index due
> to the move from doc values to stored fields.
>
> I deleted this test, since we no longer use different approaches depending
> on the version that was used to create the taxonomy index. Please let me
> know if you disagree with this approach and I can work on resurrecting this
> test.
>
> --
> Adrien
>

Re: Taxonomy backward compatibility tests [ In reply to ]

jpountz at gmail

Nov 2, 2021, 10:40 AM

Post #3 of 6 (436 views)

Permalink

Thanks Gautam!

On Tue, Nov 2, 2021 at 6:36 PM Gautam Worah <worah.gautam@gmail.com> wrote:

> I think this makes sense. Lucene 9 continues to be backwards compatible
> with Lucene 8. Lucene 10 will be able to read Lucene 9,10 taxonomy indexes.
> LGTM!
>
> --
> Gautam Worah.
>
>
> On Tue, Nov 2, 2021 at 6:09 AM Adrien Grand <jpountz@gmail.com> wrote:
>
>> Hello here,
>>
>> As part of changing the version of the main branch from 9.0 to 10.0, I
>> had to address some backward compatibility logic and tests. In particular,
>> lucene/facet had a backward compatibility test for the taxonomy index due
>> to the move from doc values to stored fields.
>>
>> I deleted this test, since we no longer use different approaches
>> depending on the version that was used to create the taxonomy index. Please
>> let me know if you disagree with this approach and I can work on
>> resurrecting this test.
>>
>> --
>> Adrien
>>
>

--
Adrien

Re: Taxonomy backward compatibility tests [ In reply to ]

zhai7631 at gmail

Nov 2, 2021, 10:49 AM

Post #4 of 6 (436 views)

Permalink

Hey Adrien,
I'm making a change that let taxonomy to use NumericDocValues instead of
term positions to store the parent array:
https://github.com/apache/lucene/pull/420.
It'll also need to pass the backward compatibility check, so for me, it
seems it's better to keep it. And if I can make it work before the 9.0
release then we can delete it after, and if not, we need a backward
compatibility test between 9 and 10 I guess?

Best
Patrick

Adrien Grand <jpountz@gmail.com> ?2021?11?2??? ??10:41???

> Thanks Gautam!
>
> On Tue, Nov 2, 2021 at 6:36 PM Gautam Worah <worah.gautam@gmail.com>
> wrote:
>
>> I think this makes sense. Lucene 9 continues to be backwards compatible
>> with Lucene 8. Lucene 10 will be able to read Lucene 9,10 taxonomy indexes.
>> LGTM!
>>
>> --
>> Gautam Worah.
>>
>>
>> On Tue, Nov 2, 2021 at 6:09 AM Adrien Grand <jpountz@gmail.com> wrote:
>>
>>> Hello here,
>>>
>>> As part of changing the version of the main branch from 9.0 to 10.0, I
>>> had to address some backward compatibility logic and tests. In particular,
>>> lucene/facet had a backward compatibility test for the taxonomy index due
>>> to the move from doc values to stored fields.
>>>
>>> I deleted this test, since we no longer use different approaches
>>> depending on the version that was used to create the taxonomy index. Please
>>> let me know if you disagree with this approach and I can work on
>>> resurrecting this test.
>>>
>>> --
>>> Adrien
>>>
>>
>
> --
> Adrien
>

Re: Taxonomy backward compatibility tests [ In reply to ]

jpountz at gmail

Nov 2, 2021, 11:22 AM

Post #5 of 6 (436 views)

Permalink

Hi Patrick,

Lucene 9.0 is supposed to be feature frozen, so in theory this change
shouldn't make it to 9.0. That said, having it merged before 9.0 would help
not have to carry over the backward compatibility logic in 10.x, so I'm
inclined to allow merging it if you can get the change merged in the next
couple of days while I'm focusing on the 8.7 release.

On Tue, Nov 2, 2021 at 6:57 PM Patrick Zhai <zhai7631@gmail.com> wrote:

> Hey Adrien,
> I'm making a change that let taxonomy to use NumericDocValues instead of
> term positions to store the parent array:
> https://github.com/apache/lucene/pull/420.
> It'll also need to pass the backward compatibility check, so for me, it
> seems it's better to keep it. And if I can make it work before the 9.0
> release then we can delete it after, and if not, we need a backward
> compatibility test between 9 and 10 I guess?
>
> Best
> Patrick
>
> Adrien Grand <jpountz@gmail.com> ?2021?11?2??? ??10:41???
>
>> Thanks Gautam!
>>
>> On Tue, Nov 2, 2021 at 6:36 PM Gautam Worah <worah.gautam@gmail.com>
>> wrote:
>>
>>> I think this makes sense. Lucene 9 continues to be backwards compatible
>>> with Lucene 8. Lucene 10 will be able to read Lucene 9,10 taxonomy indexes.
>>> LGTM!
>>>
>>> --
>>> Gautam Worah.
>>>
>>>
>>> On Tue, Nov 2, 2021 at 6:09 AM Adrien Grand <jpountz@gmail.com> wrote:
>>>
>>>> Hello here,
>>>>
>>>> As part of changing the version of the main branch from 9.0 to 10.0, I
>>>> had to address some backward compatibility logic and tests. In particular,
>>>> lucene/facet had a backward compatibility test for the taxonomy index due
>>>> to the move from doc values to stored fields.
>>>>
>>>> I deleted this test, since we no longer use different approaches
>>>> depending on the version that was used to create the taxonomy index. Please
>>>> let me know if you disagree with this approach and I can work on
>>>> resurrecting this test.
>>>>
>>>> --
>>>> Adrien
>>>>
>>>
>>
>> --
>> Adrien
>>
>

--
Adrien

Re: Taxonomy backward compatibility tests [ In reply to ]

zhai7631 at gmail

Nov 3, 2021, 10:20 AM

Post #6 of 6 (436 views)

Permalink

Got it, thanks Adrien. I'll try to make it ready these days.

Adrien Grand <jpountz@gmail.com> ?2021?11?2??? ??11:23???

> Hi Patrick,
>
> Lucene 9.0 is supposed to be feature frozen, so in theory this change
> shouldn't make it to 9.0. That said, having it merged before 9.0 would help
> not have to carry over the backward compatibility logic in 10.x, so I'm
> inclined to allow merging it if you can get the change merged in the next
> couple of days while I'm focusing on the 8.7 release.
>
> On Tue, Nov 2, 2021 at 6:57 PM Patrick Zhai <zhai7631@gmail.com> wrote:
>
>> Hey Adrien,
>> I'm making a change that let taxonomy to use NumericDocValues instead of
>> term positions to store the parent array:
>> https://github.com/apache/lucene/pull/420.
>> It'll also need to pass the backward compatibility check, so for me, it
>> seems it's better to keep it. And if I can make it work before the 9.0
>> release then we can delete it after, and if not, we need a backward
>> compatibility test between 9 and 10 I guess?
>>
>> Best
>> Patrick
>>
>> Adrien Grand <jpountz@gmail.com> ?2021?11?2??? ??10:41???
>>
>>> Thanks Gautam!
>>>
>>> On Tue, Nov 2, 2021 at 6:36 PM Gautam Worah <worah.gautam@gmail.com>
>>> wrote:
>>>
>>>> I think this makes sense. Lucene 9 continues to be backwards compatible
>>>> with Lucene 8. Lucene 10 will be able to read Lucene 9,10 taxonomy indexes.
>>>> LGTM!
>>>>
>>>> --
>>>> Gautam Worah.
>>>>
>>>>
>>>> On Tue, Nov 2, 2021 at 6:09 AM Adrien Grand <jpountz@gmail.com> wrote:
>>>>
>>>>> Hello here,
>>>>>
>>>>> As part of changing the version of the main branch from 9.0 to 10.0, I
>>>>> had to address some backward compatibility logic and tests. In particular,
>>>>> lucene/facet had a backward compatibility test for the taxonomy index due
>>>>> to the move from doc values to stored fields.
>>>>>
>>>>> I deleted this test, since we no longer use different approaches
>>>>> depending on the version that was used to create the taxonomy index. Please
>>>>> let me know if you disagree with this approach and I can work on
>>>>> resurrecting this test.
>>>>>
>>>>> --
>>>>> Adrien
>>>>>
>>>>
>>>
>>> --
>>> Adrien
>>>
>>
>
> --
> Adrien
>